24547 – Add more action logs for holds

Bug 24547 - Add more action logs for holds

Summary: Add more action logs for holds

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Hold requests (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Kyle M Hall (khall)
QA Contact:	Testopia

URL:
Keywords:

Depends on:	14642
Blocks:
	Show dependency tree / graph

Reported:	2020-01-30 15:24 UTC by Kyle M Hall (khall)
Modified:	2020-11-30 21:47 UTC (History)
CC List:	6 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:	Trapping and filling holds will now create entries in the logs, when HoldsLog system preference is activated.
Version(s) released in:	20.05.00, 19.11.06, 19.05.11
Circulation function:

Attachments
Bug 24547: Add more action logs for holds (1.28 KB, patch) 2020-01-30 15:30 UTC, Kyle M Hall (khall)	Details \| Diff \| Splinter Review
Bug 24547: Add more action logs for holds (1.31 KB, patch) 2020-01-31 08:01 UTC, David Nind	Details \| Diff \| Splinter Review
Bug 24547: Add more action logs for holds (1.38 KB, patch) 2020-04-08 12:36 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 16547: Remove more multi_holds inconsistencies (4.79 KB, patch) 2020-04-08 13:48 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kyle M Hall (khall) 2020-01-30 15:24:21 UTC

It seems like ModReserveFill and ModReserveAffect should both produce action logs for holds.

Comment 1 Kyle M Hall (khall) 2020-01-30 15:30:31 UTC

Created attachment 98174 [details] [review]
Bug 24547: Add more action logs for holds

It seems like ModReserveFill and ModReserveAffect should both produce action logs for holds.

Test Plan:
1) Apply this patch
2) Place a hold
3) Check in the item to trap the hold
4) Check out the item to fill the hold
5) Check the action logs for that reserve id
6) Note the new logs!

Comment 2 David Nind 2020-01-31 08:01:43 UTC

Created attachment 98215 [details] [review]
Bug 24547: Add more action logs for holds

It seems like ModReserveFill and ModReserveAffect should both produce action logs for holds.

Test Plan:
0) Enable HoldsLog system preference
1) Apply this patch
2) Place a hold
3) Check in the item to trap the hold
4) Check out the item to fill the hold
5) Check the action logs for that reserve id
6) Note the new logs!

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Jonathan Druart 2020-04-08 12:36:56 UTC

Created attachment 102565 [details] [review]
Bug 24547: Add more action logs for holds

It seems like ModReserveFill and ModReserveAffect should both produce action logs for holds.

Test Plan:
1) Apply this patch
2) Place a hold
3) Check in the item to trap the hold
4) Check out the item to fill the hold
5) Check the action logs for that reserve id
6) Note the new logs!

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Comment 4 Jonathan Druart 2020-04-08 13:48:12 UTC Comment hidden (obsolete)

Created attachment 102569 [details] [review]
Bug 16547: Remove more multi_holds inconsistencies

There was a bug, on the biblio's hold list view, if the pickup library
was changed, the next screen was "place a hold for no title"

http://pro.kohadev.org/cgi-bin/koha/reserve/request.pl?multi_hold=1&biblionumbers=

Comment 5 Martin Renvoize (ashimema) 2020-04-14 16:23:41 UTC

Nice work everyone!

Pushed to master for 20.05

Comment 6 Joy Nelson 2020-05-05 22:07:30 UTC

backported to 19.11.x for 19.11.06

Comment 7 Lucas Gass (lukeg) 2020-05-13 22:21:16 UTC

Simple and useful enhancement, backporting to 19.05.x for 19.05.11