Bugzilla – Attachment 98961 Details for
Bug 24619
Phase out jquery.cookie.js: MARC Frameworks
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23947: Phase out jquery.cookie.js: MARC Frameworks
Bug-23947-Phase-out-jquerycookiejs-MARC-Frameworks.patch (text/plain), 2.44 KB, created by
Katrin Fischer
on 2020-02-14 15:17:22 UTC
(
hide
)
Description:
Bug 23947: Phase out jquery.cookie.js: MARC Frameworks
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-02-14 15:17:22 UTC
Size:
2.44 KB
patch
obsolete
>From e57d7e184c672ec8d5c19e4d8c563fd11aaab7c2 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 10 Feb 2020 17:58:04 +0000 >Subject: [PATCH] Bug 23947: Phase out jquery.cookie.js: MARC Frameworks > >This patch removes the use of the jquery.cookie plugin on the MARC >Frameworks page and replaces it with a call to the new js-cookie >library. > >To test, apply the patch and go to Administration -> MARC >bibliographic frameworks. > > - Choose the 'MARC structure' menu item for one of the frameworks > listed. > - On the page which lists the tags in the framework, check the box > labeled "Display only used tags/subfields." The page should reload. > - The checkbox should remain checked and the list of tags should now > show only used tags. > - Uncheck the checkbox and the page should reload again. > >You can also follow the changes to the cookie using the browser's >developer console. Look for a cookie named >'marctagstructure_selectdisplay' and confirm that the value flips from 0 >to 1 and back. > >https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector >https://developers.google.com/web/tools/chrome-devtools/storage/cookies > >https://bugs.koha-community.org/show_bug.cgi?id=24619 > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt >index 3bfc6cded1..eda4824ade 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt >@@ -242,7 +242,6 @@ > [% MACRO jsinclude BLOCK %] > [% INCLUDE 'datatables.inc' %] > [% Asset.js("js/admin-menu.js") | $raw %] >- [% Asset.js("lib/jquery/plugins/jquery.cookie.min.js") | $raw %] > <script> > $(document).ready(function() { > $("#table_marctagstructure").dataTable($.extend(true, {}, dataTablesDefaults, { >@@ -253,7 +252,7 @@ > })); > $("#select_display").on("change",function(){ > var checked = $(this).prop("checked") ? 1: 0; >- $.cookie('marctagstructure_selectdisplay', checked); >+ Cookies.set("marctagstructure_selectdisplay", checked); > this.form.submit(); > }); > }); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24619
:
98677
|
98920
| 98961