Bugzilla – Attachment 98981 Details for
Bug 22655
Add setup of a hold rule to the onboarding tool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22655: Adding holds rules to Onboarding tool
Bug-22655-Adding-holds-rules-to-Onboarding-tool.patch (text/plain), 4.61 KB, created by
Owen Leonard
on 2020-02-14 17:06:00 UTC
(
hide
)
Description:
Bug 22655: Adding holds rules to Onboarding tool
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2020-02-14 17:06:00 UTC
Size:
4.61 KB
patch
obsolete
>From 0dad52eabf4b56c81f3adbcc56365a7ae270499c Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Thu, 13 Feb 2020 02:47:20 +0000 >Subject: [PATCH] Bug 22655: Adding holds rules to Onboarding tool > >This patch adds the following fields to the circ rule step in the >onboarding tool: >- holds allowed (total) >- holds allowed (daily) >- holds per record (count) > >To test: >1) Apply patch, drop and recreate database, restart memcached and refresh page >2) Go through the installer and get to the final step of the onboarding >tool >3) Confirm the above fields are now available to set in your circulation >rule >4) Save and log in to Koha >5) Go to Admin -> Circ and fines rules >6) Confirm the fields saved correctly > >Sponsored-by: Catalyst IT > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > installer/onboarding.pl | 9 ++++++--- > .../prog/en/modules/onboarding/onboardingstep5.tt | 17 ++++++++++++++++- > 2 files changed, 22 insertions(+), 4 deletions(-) > >diff --git a/installer/onboarding.pl b/installer/onboarding.pl >index ab07d520213..547df29e0da 100755 >--- a/installer/onboarding.pl >+++ b/installer/onboarding.pl >@@ -242,6 +242,9 @@ if ( $step == 5 ) { > my $lengthunit = $input->param('lengthunit'); > my $renewalsallowed = $input->param('renewalsallowed'); > my $renewalperiod = $input->param('renewalperiod'); >+ my $reservesallowed = $input->param('reservesallowed'); >+ my $holds_per_day = $input->param('holds_per_day'); >+ my $holds_per_record = $input->param('holds_per_record'); > my $onshelfholds = $input->param('onshelfholds') || 0; > $maxissueqty =~ s/\s//g; > $maxissueqty = undef if $maxissueqty !~ /^\d+/; >@@ -267,8 +270,8 @@ if ( $step == 5 ) { > firstremind => 0, > hardduedate => "", > hardduedatecompare => -1, >- holds_per_day => undef, >- holds_per_record => 1, >+ holds_per_day => $holds_per_day, >+ holds_per_record => $holds_per_record, > maxissueqty => "", > maxonsiteissueqty => "", > maxsuspensiondays => "", >@@ -278,7 +281,7 @@ if ( $step == 5 ) { > opacitemholds => "N", > overduefinescap => "", > rentaldiscount => 0, >- reservesallowed => 0, >+ reservesallowed => $reservesallowed, > suspension_chargeperiod => undef, > } > }; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt >index b04013e9510..b5592555912 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt >@@ -110,6 +110,21 @@ > </li> > > <li> >+ <label for="reservesallowed">Holds allowed (total): </label> >+ <input type="number" name="reservesallowed" id="reservesallowed" size="10" value="10" min="0"> >+ </li> >+ >+ <li> >+ <label for="holds_per_day">Holds allowed (daily): </label> >+ <input type="number" name="holds_per_day" id="holds_per_day" size="10" value="10" min="0"> >+ </li> >+ >+ <li> >+ <label for="holds_per_record">Holds per record (count): </label> >+ <input type="number" name="holds_per_record" id="holds_per_record" size="10" value="1" min="0"> >+ </li> >+ >+ <li> > <label for="onshelfholds">On shelf holds allowed: </label> > <select name="onshelfholds" id="onshelfholds" required="required"> > <option value="">Choose</option> >@@ -139,4 +154,4 @@ > <script src="[% interface | html %]/[% theme | html %]/js/onboarding.js"></script> > [% END %] > >-[% INCLUDE 'installer-intranet-bottom.inc' %] >\ No newline at end of file >+[% INCLUDE 'installer-intranet-bottom.inc' %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22655
:
98785
|
98981
|
99358