Attachment 99407 Details for Bug 24584 – Bug 24584: Rewrite optional/patron_categories to YAML

[patch] Bug 24584: Rewrite optional/patron_categories to YAML

Bug-24584-Rewrite-optionalpatroncategories-to-YAML.patch (text/plain), 9.64 KB, created by Martin Renvoize (ashimema) on 2020-02-21 16:39:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-02-21 16:39:39 UTC

Size: 9.64 KB

patch

obsolete

>From 96689358d007f1786365870014fea4805856b2c5 Mon Sep 17 00:00:00 2001
>From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Date: Wed, 5 Feb 2020 09:32:10 -0300
>Subject: [PATCH] Bug 24584: Rewrite optional/patron_categories to YAML
>
>YAML version of optional patron_categories
>
>To test:
>1) Same test plan of first patch, only check table
>   categories
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../mysql/en/optional/patron_categories.sql   |  23 --
> .../mysql/en/optional/patron_categories.txt   |  21 --
> .../mysql/en/optional/patron_categories.yml   | 209 ++++++++++++++++++
> 3 files changed, 209 insertions(+), 44 deletions(-)
> delete mode 100644 installer/data/mysql/en/optional/patron_categories.sql
> delete mode 100644 installer/data/mysql/en/optional/patron_categories.txt
> create mode 100644 installer/data/mysql/en/optional/patron_categories.yml
>
>diff --git a/installer/data/mysql/en/optional/patron_categories.sql b/installer/data/mysql/en/optional/patron_categories.sql
>deleted file mode 100644
>index 57a00dabdb..0000000000
>--- a/installer/data/mysql/en/optional/patron_categories.sql
>+++ /dev/null
>@@ -1,23 +0,0 @@
>-INSERT INTO `categories` (`categorycode`, `description`, `enrolmentperiod`, `upperagelimit`, `dateofbirthrequired`, `finetype`, `bulk`, `enrolmentfee`, `overduenoticerequired`, `issuelimit`, `reservefee`, `category_type`) VALUES
>-
>--- Adult Patrons
>-('PT','Patron',99,999,18,NULL,NULL,'0.000000',1,NULL,'0.000000','A'),
>-('ST','Student',99,999,18,NULL,NULL,'0.000000',1,NULL,'0.000000','A'),
>-('HB','Home Bound',99,999,18,NULL,NULL,'0.000000',1,NULL,'0.000000','A'),
>-
>--- Children
>-('K','Kid',99,17,5,NULL,NULL,'0.000000',1,NULL,'0.000000','C'),
>-('J','Juvenile',99,17,5,NULL,NULL,'0.000000',1,NULL,'0.000000','C'),
>-('YA','Young Adult',99,17,5,NULL,NULL,'0.000000',1,NULL,'0.000000','C'),
>-
>--- Professionals
>-('T','Teacher',99,999,18,NULL,NULL,'0.000000',0,NULL,'0.000000','P'),
>-('B','Board',99,17,5,NULL,NULL,'0.000000',1,NULL,'0.000000','P'),
>-
>--- Institutional
>-('IL','Inter-Library Loan',99,999,18,NULL,NULL,'0.000000',1,NULL,'0.000000','I'),
>-('SC','School',99,999,18,NULL,NULL,'0.000000',1,NULL,'0.000000','I'),
>-('L','Library',99,999,18,NULL,NULL,'0.000000',1,NULL,'0.000000','I'),
>-
>--- Staff
>-('S','Staff',99,999,18,NULL,NULL,'0.000000',0,NULL,'0.000000','S');
>diff --git a/installer/data/mysql/en/optional/patron_categories.txt b/installer/data/mysql/en/optional/patron_categories.txt
>deleted file mode 100644
>index 45102b31d5..0000000000
>--- a/installer/data/mysql/en/optional/patron_categories.txt
>+++ /dev/null
>@@ -1,21 +0,0 @@
>-Sample patron types and categories. Types are currently hardcoded but you can manage categories after installation from the administration module.
>-
>-Adult patron - default patron type
>-                PT  - Patron
>-                ST  - Student
>-                BH  - Homebound
>-
>-Child - patron with a guarantor
>-                K   - Kid
>-                J   - Juvenile
>-                YA  - Young Adult
>-
>-Organization - patron is an institution, not a person
>-                ILL - Inter-library Loan
>-                SC  - School
>-                L   - Library
>-
>-Professional - a member of an organization (organization is guarantor)
>-                T   - Teacher
>-                S   - Staff
>-                B   - Board
>diff --git a/installer/data/mysql/en/optional/patron_categories.yml b/installer/data/mysql/en/optional/patron_categories.yml
>new file mode 100644
>index 0000000000..71590a1a77
>--- /dev/null
>+++ b/installer/data/mysql/en/optional/patron_categories.yml
>@@ -0,0 +1,209 @@
>+---
>+#
>+#  Copyright 2020 Koha Development Team
>+#
>+#  This file is part of Koha.
>+#
>+#  Koha is free software; you can redistribute it and/or modify it under the
>+#  terms of the GNU General Public License as published by the Free Software
>+#  Foundation; either version 2 of the License, or (at your option) any later
>+#  version.
>+#
>+#  Koha is distributed in the hope that it will be useful, but WITHOUT ANY
>+#  WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
>+#  A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
>+#
>+#  You should have received a copy of the GNU General Public License along
>+#  with Koha; if not, write to the Free Software Foundation, Inc.,
>+#  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>+#
>+
>+description:
>+  - "Sample patron types and categories. Types are currently hardcoded but you can manage categories after installation from the administration module."
>+  - ""
>+  - "Adult patron - default patron type"
>+  - "                PT  - Patron"
>+  - "                ST  - Student"
>+  - "                BH  - Homebound"
>+  - ""
>+  - "Child - patron with a guarantor"
>+  - "                K   - Kid"
>+  - "                J   - Juvenile"
>+  - "                YA  - Young Adult"
>+  - ""
>+  - "Organization - patron is an institution, not a person"
>+  - "                ILL - Inter-library Loan"
>+  - "                SC  - School"
>+  - "                L   - Library"
>+  - ""
>+  - "Professional - a member of an organization (organization is guarantor)"
>+  - "                T   - Teacher"
>+  - "                S   - Staff"
>+  - "                B   - Board"
>+
>+
>+tables:
>+  - categories:
>+      translatable: [ description ]
>+      multiline: []
>+      rows:
>+        #  Adult Patrons
>+        - categorycode: 'PT'
>+          description: 'Patron'
>+          enrolmentperiod: 99
>+          upperagelimit: 999
>+          dateofbirthrequired: 18
>+          finetype: ~
>+          bulk: ~
>+          enrolmentfee: '0.000000'
>+          overduenoticerequired: 1
>+          issuelimit: ~
>+          reservefee: '0.000000'
>+          category_type: 'A'
>+
>+        - categorycode: 'ST'
>+          description: 'Student'
>+          enrolmentperiod: 99
>+          upperagelimit: 999
>+          dateofbirthrequired: 18
>+          finetype: ~
>+          bulk: ~
>+          enrolmentfee: '0.000000'
>+          overduenoticerequired: 1
>+          issuelimit: ~
>+          reservefee: '0.000000'
>+          category_type: 'A'
>+
>+        - categorycode: 'HB'
>+          description: 'Home Bound'
>+          enrolmentperiod: 99
>+          upperagelimit: 999
>+          dateofbirthrequired: 18
>+          finetype: ~
>+          bulk: ~
>+          enrolmentfee: '0.000000'
>+          overduenoticerequired: 1
>+          issuelimit: ~
>+          reservefee: '0.000000'
>+          category_type: 'A'
>+
>+        #  Children
>+        - categorycode: 'K'
>+          description: 'Kid'
>+          enrolmentperiod: 99
>+          upperagelimit: 17
>+          dateofbirthrequired: 5
>+          finetype: ~
>+          bulk: ~
>+          enrolmentfee: '0.000000'
>+          overduenoticerequired: 1
>+          issuelimit: ~
>+          reservefee: '0.000000'
>+          category_type: 'C'
>+
>+        - categorycode: 'J'
>+          description: 'Juvenile'
>+          enrolmentperiod: 99
>+          upperagelimit: 17
>+          dateofbirthrequired: 5
>+          finetype: ~
>+          bulk: ~
>+          enrolmentfee: '0.000000'
>+          overduenoticerequired: 1
>+          issuelimit: ~
>+          reservefee: '0.000000'
>+          category_type: 'C'
>+
>+        - categorycode: 'YA'
>+          description: 'Young Adult'
>+          enrolmentperiod: 99
>+          upperagelimit: 17
>+          dateofbirthrequired: 5
>+          finetype: ~
>+          bulk: ~
>+          enrolmentfee: '0.000000'
>+          overduenoticerequired: 1
>+          issuelimit: ~
>+          reservefee: '0.000000'
>+          category_type: 'C'
>+
>+        #  Professionals
>+        - categorycode: 'T'
>+          description: 'Teacher'
>+          enrolmentperiod: 99
>+          upperagelimit: 999
>+          dateofbirthrequired: 18
>+          finetype: ~
>+          bulk: ~
>+          enrolmentfee: '0.000000'
>+          overduenoticerequired: 0
>+          issuelimit: ~
>+          reservefee: '0.000000'
>+          category_type: 'P'
>+
>+        - categorycode: 'B'
>+          description: 'Board'
>+          enrolmentperiod: 99
>+          upperagelimit: 17
>+          dateofbirthrequired: 5
>+          finetype: ~
>+          bulk: ~
>+          enrolmentfee: '0.000000'
>+          overduenoticerequired: 1
>+          issuelimit: ~
>+          reservefee: '0.000000'
>+          category_type: 'P'
>+
>+        #  Institutional
>+        - categorycode: 'IL'
>+          description: 'Inter-Library Loan'
>+          enrolmentperiod: 99
>+          upperagelimit: 999
>+          dateofbirthrequired: 18
>+          finetype: ~
>+          bulk: ~
>+          enrolmentfee: '0.000000'
>+          overduenoticerequired: 1
>+          issuelimit: ~
>+          reservefee: '0.000000'
>+          category_type: 'I'
>+
>+        - categorycode: 'SC'
>+          description: 'School'
>+          enrolmentperiod: 99
>+          upperagelimit: 999
>+          dateofbirthrequired: 18
>+          finetype: ~
>+          bulk: ~
>+          enrolmentfee: '0.000000'
>+          overduenoticerequired: 1
>+          issuelimit: ~
>+          reservefee: '0.000000'
>+          category_type: 'I'
>+
>+        - categorycode: 'L'
>+          description: 'Library'
>+          enrolmentperiod: 99
>+          upperagelimit: 999
>+          dateofbirthrequired: 18
>+          finetype: ~
>+          bulk: ~
>+          enrolmentfee: '0.000000'
>+          overduenoticerequired: 1
>+          issuelimit: ~
>+          reservefee: '0.000000'
>+          category_type: 'I'
>+
>+        #  Staff
>+        - categorycode: 'S'
>+          description: 'Staff'
>+          enrolmentperiod: 99
>+          upperagelimit: 999
>+          dateofbirthrequired: 18
>+          finetype: ~
>+          bulk: ~
>+          enrolmentfee: '0.000000'
>+          overduenoticerequired: 0
>+          issuelimit: ~
>+          reservefee: '0.000000'
>+          category_type: 'S'
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24584: 98464 | 98465 | 98466 | 98467 | 98468 | 98469 | 98470 | 98471 | 98472 | 98473 | 98474 | 98475 | 98476 | 98477 | 99402 | 99403 | 99404 | 99405 | 99406 | 99407 | 99408 | 99409 | 99410 | 99411 | 99412 | 99413 | 99414 | 99415 | 100352 | 100353 | 100354 | 100355 | 100356 | 100357 | 100358 | 100359 | 100360 | 100361 | 100362 | 100363 | 100364 | 100365