A complete rewrite of optional instalation files from SQL to YAML is presented, one patch for each file, the result could be squashed. The goal is to allow the translation of the installation files
Created attachment 98464 [details] [review] Bug 24584: Rewrite optional/csv_profiles to YAML YAML version of optional csv_profiles. To test: 1) Do a clean install with optional data, dump table export_format, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No major differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files
Created attachment 98465 [details] [review] Bug 24584: Rewrite optional/marc21_holdings_coded_values to YAML YAML version of optional marc21_holdings_coded_values To test: 1) Same test plan of first patch, only check table authorised_values
Created attachment 98466 [details] [review] Bug 24584: Rewrite optional/marc21_relatorterms to YAML YAML version of optional marc21_relatorterms To test: 1) Same test plan of first patch, only check table authorised_values
Created attachment 98467 [details] [review] Bug 24584: Rewrite optional/parameters to YAML YAML version of optional parameters To test: 1) Same test plan of first patch, only check table currency
Created attachment 98468 [details] [review] Bug 24584: Rewrite optional/patron_atributes to YAML YAML version of optional patron_atributes To test: 1) Same test plan of first patch, only check table borrower_attribute_types
Created attachment 98469 [details] [review] Bug 24584: Rewrite optional/patron_categories to YAML YAML version of optional patron_categories To test: 1) Same test plan of first patch, only check table categories
Created attachment 98470 [details] [review] Bug 24584: Rewrite optional/sample_creator_data to YAML YAML version of optional sample_creator_data To test: 1) Same test plan of first patch, only check tables creator_layouts, creator_templates and printers_profile
Created attachment 98471 [details] [review] Bug 24584: Rewrite optional/sample_itemtypes to YAML YAML version of optional sample_itemtypes To test: 1) Same test plan of first patch, only check table itemtypes
Created attachment 98472 [details] [review] Bug 24584: Rewrite optional/sample_libraries to YAML YAML version of optional sample_libraries To test: 1) Same test plan of first patch, only check table branches
Created attachment 98473 [details] [review] Bug 24584: Rewrite optional/sample_libraries_holidays to YAML YAML version of optional sample_libraries_holidays To test: 1) Same test plan of first patch, only check table repeatable_holidays
Created attachment 98474 [details] [review] Bug 24584: Rewrite optional/sample_news to YAML YAML version of optional sample_news To test: 1) Same test plan of first patch, only check table opac_news
Created attachment 98475 [details] [review] Bug 24584: Rewrite optional/sample_patrons to YAML YAML version of optional sample_patrons To test: 1) Same test plan of first patch, only check table borrowers
Created attachment 98476 [details] [review] Bug 24584: Rewrite optional/sample_quotes to YAML YAML version of optional sample_quotes To test: 1) Same test plan of first patch, only check table quotes
Created attachment 98477 [details] [review] Bug 24584: Rewrite optional/sample_z3950_servers to YAML YAML version of optional sample_z3950_servers To test: 1) Same test plan of first patch, only check table z3950servers
(In reply to Bernardo Gonzalez Kriegel from comment #13) > Created attachment 98476 [details] [review] [review] > Bug 24584: Rewrite optional/sample_quotes to YAML > > YAML version of optional sample_quotes > > To test: > 1) Same test plan of first patch, only check table > quotes I am getting an error with sample_quotes.yml DBD::mysql::st execute failed: Field 'timestamp' doesn't have a default value at /kohadevbox/koha/C4/Installer.pm line 502. As it is the only one I think we should fix it at DB level ('timestamp' should be set to the current timestamp)
(In reply to Jonathan Druart from comment #15) > (In reply to Bernardo Gonzalez Kriegel from comment #13) > > Created attachment 98476 [details] [review] [review] [review] > > Bug 24584: Rewrite optional/sample_quotes to YAML > > > > YAML version of optional sample_quotes > > > > To test: > > 1) Same test plan of first patch, only check table > > quotes > > I am getting an error with sample_quotes.yml > > DBD::mysql::st execute failed: Field 'timestamp' doesn't have a default > value at /kohadevbox/koha/C4/Installer.pm line 502. > > As it is the only one I think we should fix it at DB level ('timestamp' > should be set to the current timestamp) See bug 24640.
Created attachment 99402 [details] [review] Bug 24584: Rewrite optional/csv_profiles to YAML YAML version of optional csv_profiles. To test: 1) Do a clean install with optional data, dump table export_format, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No major differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 99403 [details] [review] Bug 24584: Rewrite optional/marc21_holdings_coded_values to YAML YAML version of optional marc21_holdings_coded_values To test: 1) Same test plan of first patch, only check table authorised_values Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 99404 [details] [review] Bug 24584: Rewrite optional/marc21_relatorterms to YAML YAML version of optional marc21_relatorterms To test: 1) Same test plan of first patch, only check table authorised_values Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 99405 [details] [review] Bug 24584: Rewrite optional/parameters to YAML YAML version of optional parameters To test: 1) Same test plan of first patch, only check table currency Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 99406 [details] [review] Bug 24584: Rewrite optional/patron_atributes to YAML YAML version of optional patron_atributes To test: 1) Same test plan of first patch, only check table borrower_attribute_types Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 99407 [details] [review] Bug 24584: Rewrite optional/patron_categories to YAML YAML version of optional patron_categories To test: 1) Same test plan of first patch, only check table categories Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 99408 [details] [review] Bug 24584: Rewrite optional/sample_creator_data to YAML YAML version of optional sample_creator_data To test: 1) Same test plan of first patch, only check tables creator_layouts, creator_templates and printers_profile Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 99409 [details] [review] Bug 24584: Rewrite optional/sample_itemtypes to YAML YAML version of optional sample_itemtypes To test: 1) Same test plan of first patch, only check table itemtypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 99410 [details] [review] Bug 24584: Rewrite optional/sample_libraries to YAML YAML version of optional sample_libraries To test: 1) Same test plan of first patch, only check table branches Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 99411 [details] [review] Bug 24584: Rewrite optional/sample_libraries_holidays to YAML YAML version of optional sample_libraries_holidays To test: 1) Same test plan of first patch, only check table repeatable_holidays Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 99412 [details] [review] Bug 24584: Rewrite optional/sample_news to YAML YAML version of optional sample_news To test: 1) Same test plan of first patch, only check table opac_news Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 99413 [details] [review] Bug 24584: Rewrite optional/sample_patrons to YAML YAML version of optional sample_patrons To test: 1) Same test plan of first patch, only check table borrowers Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 99414 [details] [review] Bug 24584: Rewrite optional/sample_quotes to YAML YAML version of optional sample_quotes To test: 1) Same test plan of first patch, only check table quotes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 99415 [details] [review] Bug 24584: Rewrite optional/sample_z3950_servers to YAML YAML version of optional sample_z3950_servers To test: 1) Same test plan of first patch, only check table z3950servers Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works well for me.. Signing off
Created attachment 100352 [details] [review] Bug 24584: Rewrite optional/csv_profiles to YAML YAML version of optional csv_profiles. To test: 1) Do a clean install with optional data, dump table export_format, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No major differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100353 [details] [review] Bug 24584: Rewrite optional/marc21_holdings_coded_values to YAML YAML version of optional marc21_holdings_coded_values To test: 1) Same test plan of first patch, only check table authorised_values Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100354 [details] [review] Bug 24584: Rewrite optional/marc21_relatorterms to YAML YAML version of optional marc21_relatorterms To test: 1) Same test plan of first patch, only check table authorised_values Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100355 [details] [review] Bug 24584: Rewrite optional/parameters to YAML YAML version of optional parameters To test: 1) Same test plan of first patch, only check table currency Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100356 [details] [review] Bug 24584: Rewrite optional/patron_atributes to YAML YAML version of optional patron_atributes To test: 1) Same test plan of first patch, only check table borrower_attribute_types Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100357 [details] [review] Bug 24584: Rewrite optional/patron_categories to YAML YAML version of optional patron_categories To test: 1) Same test plan of first patch, only check table categories Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100358 [details] [review] Bug 24584: Rewrite optional/sample_creator_data to YAML YAML version of optional sample_creator_data To test: 1) Same test plan of first patch, only check tables creator_layouts, creator_templates and printers_profile Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100359 [details] [review] Bug 24584: Rewrite optional/sample_itemtypes to YAML YAML version of optional sample_itemtypes To test: 1) Same test plan of first patch, only check table itemtypes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100360 [details] [review] Bug 24584: Rewrite optional/sample_libraries to YAML YAML version of optional sample_libraries To test: 1) Same test plan of first patch, only check table branches Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100361 [details] [review] Bug 24584: Rewrite optional/sample_libraries_holidays to YAML YAML version of optional sample_libraries_holidays To test: 1) Same test plan of first patch, only check table repeatable_holidays Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100362 [details] [review] Bug 24584: Rewrite optional/sample_news to YAML YAML version of optional sample_news To test: 1) Same test plan of first patch, only check table opac_news Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100363 [details] [review] Bug 24584: Rewrite optional/sample_patrons to YAML YAML version of optional sample_patrons To test: 1) Same test plan of first patch, only check table borrowers Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100364 [details] [review] Bug 24584: Rewrite optional/sample_quotes to YAML YAML version of optional sample_quotes To test: 1) Same test plan of first patch, only check table quotes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100365 [details] [review] Bug 24584: Rewrite optional/sample_z3950_servers to YAML YAML version of optional sample_z3950_servers To test: 1) Same test plan of first patch, only check table z3950servers Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
enhancement not backported to 19.11.x