Bugzilla – Attachment 99922 Details for
Bug 24776
Remove useless Borrowers Template Toolkit plugin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24776: Remove Borrowers.IsDebarred call
Bug-24776-Remove-BorrowersIsDebarred-call.patch (text/plain), 2.55 KB, created by
Fridolin Somers
on 2020-03-02 14:39:22 UTC
(
hide
)
Description:
Bug 24776: Remove Borrowers.IsDebarred call
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2020-03-02 14:39:22 UTC
Size:
2.55 KB
patch
obsolete
>From 98de38f9b0b448322e1e761acd6e328cd2d587d0 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Mon, 2 Mar 2020 17:27:10 +0300 >Subject: [PATCH] Bug 24776: Remove Borrowers.IsDebarred call > >Borrowers Template Toolkit plugin contains method IsDebarred that can be directly called from Koha::Patron object. > >Also in template circ/returns.tt, when patron is restricted and checkin was backdated, var "patron" is undefined, should be "issue.patron". > >Test plan : >1) Enable system preference SpecifyReturnDate >2) For a patron without restriction create a checkout >3) Create a manual restriction to debarre patron >4) Go to return page and click on "Checkin settings" >5) Specify a date in the past, barcode and click "Check in" >6) You see message "Jon Doe is restricted. Please verify this patron should still be restricted." >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 29818882c9..3e741dfee6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -3,7 +3,6 @@ > [% USE KohaDates %] > [% USE Branches %] > [% USE Koha %] >-[% USE Borrowers %] > [% USE ItemTypes %] > [% USE AuthorisedValues %] > [% USE ColumnsSettings %] >@@ -182,11 +181,11 @@ > [% END %] > > <!-- Patron is restricted and checkin was backdated --> >- [% IF return_date_was_overriden && Borrowers.IsDebarred( borrower ) %] >+ [% IF return_date_was_overriden && issue.patron.is_debarred %] > <div id="restricted_backdated" class="dialog message"> > <h3> >- <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% patron.borrowernumber | uri %]"> >- [% patron.firstname | html %] [% patron.surname | html %] >+ <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% issue.patron.borrowernumber | uri %]"> >+ [% issue.patron.firstname | html %] [% issue.patron.surname | html %] > </a> > is restricted. Please verify this patron should still be restricted. > </h3> >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24776
:
99921
|
99922
|
99925
|
100411
|
100412
|
100413
|
100580
|
100581
|
100582