Borrowers Template Toolkit plugin contains methods IsDebarred and HasOverdues that can be directly called from Koha::Patron object. Also in template circ/returns.tt, when patron is restricted and checkin was backdated, var "patron" is undefined, should be "issue.patron".
Created attachment 99921 [details] [review] Bug 24776: Remove Borrowers.HasOverdues call Borrowers Template Toolkit plugin contains method HasOverdues that can be directly called from Koha::Patron object. Test plan : 1) Go to circulation page of a patron with overdues 2) Click on print button 3) You see "Print overdues" 4) Go to circulation page of a patron without overdues 5) Click on print button 6) You don't see "Print overdues"
Created attachment 99922 [details] [review] Bug 24776: Remove Borrowers.IsDebarred call Borrowers Template Toolkit plugin contains method IsDebarred that can be directly called from Koha::Patron object. Also in template circ/returns.tt, when patron is restricted and checkin was backdated, var "patron" is undefined, should be "issue.patron". Test plan : 1) Enable system preference SpecifyReturnDate 2) For a patron without restriction create a checkout 3) Create a manual restriction to debarre patron 4) Go to return page and click on "Checkin settings" 5) Specify a date in the past, barcode and click "Check in" 6) You see message "Jon Doe is restricted. Please verify this patron should still be restricted."
Created attachment 99925 [details] [review] Bug 24776: Remove file Koha/Template/Plugin/Borrowers.pm
Created attachment 100411 [details] [review] Bug 24776: Remove Borrowers.HasOverdues call Borrowers Template Toolkit plugin contains method HasOverdues that can be directly called from Koha::Patron object. Test plan : 1) Go to circulation page of a patron with overdues 2) Click on print button 3) You see "Print overdues" 4) Go to circulation page of a patron without overdues 5) Click on print button 6) You don't see "Print overdues" Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 100412 [details] [review] Bug 24776: Remove Borrowers.IsDebarred call Borrowers Template Toolkit plugin contains method IsDebarred that can be directly called from Koha::Patron object. Also in template circ/returns.tt, when patron is restricted and checkin was backdated, var "patron" is undefined, should be "issue.patron". Test plan : 1) Enable system preference SpecifyReturnDate 2) For a patron without restriction create a checkout 3) Create a manual restriction to debarre patron 4) Go to return page and click on "Checkin settings" 5) Specify a date in the past, barcode and click "Check in" 6) You see message "Jon Doe is restricted. Please verify this patron should still be restricted." Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 100413 [details] [review] Bug 24776: Remove file Koha/Template/Plugin/Borrowers.pm Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 100580 [details] [review] Bug 24776: Remove Borrowers.HasOverdues call Borrowers Template Toolkit plugin contains method HasOverdues that can be directly called from Koha::Patron object. Test plan : 1) Go to circulation page of a patron with overdues 2) Click on print button 3) You see "Print overdues" 4) Go to circulation page of a patron without overdues 5) Click on print button 6) You don't see "Print overdues" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100581 [details] [review] Bug 24776: Remove Borrowers.IsDebarred call Borrowers Template Toolkit plugin contains method IsDebarred that can be directly called from Koha::Patron object. Also in template circ/returns.tt, when patron is restricted and checkin was backdated, var "patron" is undefined, should be "issue.patron". Test plan : 1) Enable system preference SpecifyReturnDate 2) For a patron without restriction create a checkout 3) Create a manual restriction to debarre patron 4) Go to return page and click on "Checkin settings" 5) Specify a date in the past, barcode and click "Check in" 6) You see message "Jon Doe is restricted. Please verify this patron should still be restricted." Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 100582 [details] [review] Bug 24776: Remove file Koha/Template/Plugin/Borrowers.pm Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
enhancement not backported to 19.11.x branch