Attachment 104834 Details for Bug 25478 – Bug 25478: (25389 backport) Catch errant cases of LOST_RETURNED

[patch] Bug 25478: (25389 backport) Catch errant cases of LOST_RETURNED

Bug-25478-25389-backport-Catch-errant-cases-of-LOS.patch (text/plain), 1.60 KB, created by Martin Renvoize (ashimema) on 2020-05-13 10:02:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-05-13 10:02:37 UTC

Size: 1.60 KB

patch

obsolete

>From 30e77e64118efbe82b28375e56ded4c13183adf2 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 13 May 2020 10:57:55 +0100
>Subject: [PATCH] Bug 25478: (25389 backport) Catch errant cases of
> LOST_RETURNED
>
>For upgrades taking place after the fix for the update in bug 24592 was
>pushed, we need to catch any last remaining error cases and correct
>them.
>
>(cherry picked from commit c5f34fe3ada46e29c9b1ac99b10186fab6d9670f)
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../data/mysql/atomicupdate/bug_25478.perl    | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 installer/data/mysql/atomicupdate/bug_25478.perl
>
>diff --git a/installer/data/mysql/atomicupdate/bug_25478.perl b/installer/data/mysql/atomicupdate/bug_25478.perl
>new file mode 100644
>index 0000000000..3bb7ba9cb7
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_25478.perl
>@@ -0,0 +1,20 @@
>+$DBversion = 'XXX'; # will be replaced by the RM
>+if( CheckVersion( $DBversion ) ) {
>+ 
>+    # Migrate LOST_RETURNED to LOST_RETURN
>+    $dbh->do(qq{
>+        UPDATE
>+          accountlines
>+        SET
>+          credit_type_code = 'LOST_RETURN'
>+        WHERE
>+          credit_type_code = 'LOST_RETURNED'
>+    });
>+ 
>+    # Drop LOST_RETURNED credit type
>+    $dbh->do(qq{
>+        DELETE FROM account_credit_types WHERE code = 'LOST_RETURNED'
>+    });
>+ 
>+    NewVersion( $DBversion, 25389, "Catch errant cases of LOST_RETURNED");
>+}
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25478: 104832 | 104833 | 104834