Bug 25478 - Inconsistent naming of account_credit_type for lost and returned items [19.11 Version]
Summary: Inconsistent naming of account_credit_type for lost and returned items [19.11...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: 19.11
Hardware: All All
: P5 - low blocker
Assignee: Martin Renvoize (ashimema)
QA Contact: Testopia
URL:
Keywords:
Depends on: 22563 23805 25389
Blocks:
  Show dependency tree / graph
 
Reported: 2020-05-13 09:47 UTC by Martin Renvoize (ashimema)
Modified: 2020-11-30 21:47 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 25478: (25389 backport) Correct original DB update for bug 22563 (1.06 KB, patch)
2020-05-13 10:02 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 25478: (25389 backport) Correct stray cases of LOST_RETURNED (1.42 KB, patch)
2020-05-13 10:02 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 25478: (25389 backport) Catch errant cases of LOST_RETURNED (1.60 KB, patch)
2020-05-13 10:02 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2020-05-13 09:47:59 UTC 
+++ This bug was initially created as a clone of Bug #25389 +++

Bug 23805 creates the account_credit_types table with the type "LOST_RETURN."
Bug 22563 updates all existing "CR" account lines to "LOST_RETURNED."

I've got no preference between the two wordings, but we should be consistent about it.
Comment 1 Martin Renvoize (ashimema) 2020-05-13 10:02:30 UTC 
Created attachment 104832 [details] [review]
Bug 25478: (25389 backport) Correct original DB update for bug 22563

(cherry picked from commit ed564837a64a45bfd1551ab54417daf0a3b9c559)
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 2 Martin Renvoize (ashimema) 2020-05-13 10:02:34 UTC 
Created attachment 104833 [details] [review]
Bug 25478: (25389 backport) Correct stray cases of LOST_RETURNED

The original DB update for bug 22563 incorrectly mapped CR to
LOST_RETURNED as aposed to LOST_RETURN.  This patch catches such cases
and updates them in the update for bug 23805

(cherry picked from commit 483e40d2236bbb584022846bd1c85d62f149f096)
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize (ashimema) 2020-05-13 10:02:37 UTC 
Created attachment 104834 [details] [review]
Bug 25478: (25389 backport) Catch errant cases of LOST_RETURNED

For upgrades taking place after the fix for the update in bug 24592 was
pushed, we need to catch any last remaining error cases and correct
them.

(cherry picked from commit c5f34fe3ada46e29c9b1ac99b10186fab6d9670f)
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2020-05-13 10:04:12 UTC 
A backport to make the application of bug 25389 to 19.11.x simple..

You will need to convert the final patch after push from the atomic update to a valid updatedatebase entry for your branch.

Hope it helps Joy.
Comment 5 Joy Nelson 2020-05-13 18:56:18 UTC 
Thanks Martin!  Pushed to 19.11.x for 19.11.06
Comment 6 Lucas Gass (lukeg) 2020-05-15 22:36:52 UTC 
missing dependencies for 19.05.x, no backport