Bugzilla – Attachment 104923 Details for
Bug 25468
Preserve line breaks in hold notes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25468: Preserve line breaks in hold notes
Bug-25468-Preserve-line-breaks-in-hold-notes.patch (text/plain), 1.61 KB, created by
Marcel de Rooy
on 2020-05-15 08:54:31 UTC
(
hide
)
Description:
Bug 25468: Preserve line breaks in hold notes
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2020-05-15 08:54:31 UTC
Size:
1.61 KB
patch
obsolete
>From c440907542da19a5636b3a5217ce960c0673a6e9 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 12 May 2020 10:49:51 -0400 >Subject: [PATCH] Bug 25468: Preserve line breaks in hold notes >Content-Type: text/plain; charset=utf-8 > >In a hold note, line breaks are not preserved when viewing the note. A >note like: >-- >Test 1 > >Test 2 >-- > >will be rendered as: >-- >Test 1 Test 2 >-- > >Test Plan: >1) Place a hold with a note, use line breaks in the note. >2) Note the lines all run together when viewing the hold. >3) Apply this patch. >4) Reload the page. >5) Notes should now display with the original line breaks! > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index 919ccdd9f8..a10e281d3b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -105,7 +105,7 @@ > [% INCLUDE 'patron-title.inc' patron=hold.patron hide_patron_infos_if_needed=1 %] > </td> > >- <td>[% hold.notes | html %]</td> >+ <td>[% hold.notes | html | html_line_break %]</td> > <td> > [% IF Koha.Preference('AllowHoldDateInFuture') %] > <input type="text" class="datepicker" value="[% hold.date | $KohaDates %]" required="required" size="10" name="reservedate" /> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25468
:
104791
|
104792
|
104854
| 104923