Bugzilla – Attachment 115431 Details for
Bug 27450
Making password required for patron registration breaks patron modification
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27450: Remove password from the mandatory fields when editing details
Bug-27450-Remove-password-from-the-mandatory-field.patch (text/plain), 1.58 KB, created by
Nick Clemens
on 2021-01-20 13:25:04 UTC
(
hide
)
Description:
Bug 27450: Remove password from the mandatory fields when editing details
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2021-01-20 13:25:04 UTC
Size:
1.58 KB
patch
obsolete
>From 5f196daac85abc29eb98dab79b69e5ca61d40991 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 20 Jan 2021 12:09:30 +0100 >Subject: [PATCH] Bug 27450: Remove password from the mandatory fields when > editing details > >When a patron edit their personal details at the OPAC, the password must >be removed from the mandatory fields > >Test plan: >0 - Don't apply the patch >1 - Set PatronSelfRegistrationBorrowerMandatoryField to require password >2 - Create or sign in as a patron on the opac >3 - Click 'Your personal details' >4 - Attempt to edit >5 - Save changes >=> They are rejected because not all required fields are populated >6 - Apply the patch >7 - Repeat 3 to 5 >=> details are saved successfully >8 - Test the self registration feature and confirm that the password is >required > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > opac/opac-memberentry.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl >index a3f1ae61b8..36fd00caf2 100755 >--- a/opac/opac-memberentry.pl >+++ b/opac/opac-memberentry.pl >@@ -262,7 +262,7 @@ elsif ( $action eq 'update' ) { > my %borrower = ParseCgiForBorrower($cgi); > $borrower{borrowernumber} = $borrowernumber; > >- my @empty_mandatory_fields = >+ my @empty_mandatory_fields = grep { $_ ne 'password' } # password is not required when editing personal details > ( CheckMandatoryFields( \%borrower, $action ), CheckMandatoryAttributes( \%borrower, $attributes ) ); > my $invalidformfields = CheckForInvalidFields(\%borrower); > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27450
:
115419
|
115431
|
116104