TO recreate: 1 - Set PatronSelfRegistrationBorrowerMandatoryField to require password 2 - Create or sign in as a patron on the opac 3 - Click 'Your personal details' 4 - Attempt to edit 5 - Save changes 6 - They are rejected because not all required fields are populated
IMO this can be best solved in Bug 13188 by separating the OPAC MandatoryField's into two sys prefs: PatronSelfModificationMandatoryField PatronSelfRegistrationBorrowerMandatoryField
Created attachment 115419 [details] [review] Bug 27450: Remove password from the mandatory fields when editing details When a patron edit their personal details at the OPAC, the password must be removed from the mandatory fields Test plan: 0 - Don't apply the patch 1 - Set PatronSelfRegistrationBorrowerMandatoryField to require password 2 - Create or sign in as a patron on the opac 3 - Click 'Your personal details' 4 - Attempt to edit 5 - Save changes => They are rejected because not all required fields are populated 6 - Apply the patch 7 - Repeat 3 to 5 => details are saved successfully 8 - Test the self registration feature and confirm that the password is required
Created attachment 115431 [details] [review] Bug 27450: Remove password from the mandatory fields when editing details When a patron edit their personal details at the OPAC, the password must be removed from the mandatory fields Test plan: 0 - Don't apply the patch 1 - Set PatronSelfRegistrationBorrowerMandatoryField to require password 2 - Create or sign in as a patron on the opac 3 - Click 'Your personal details' 4 - Attempt to edit 5 - Save changes => They are rejected because not all required fields are populated 6 - Apply the patch 7 - Repeat 3 to 5 => details are saved successfully 8 - Test the self registration feature and confirm that the password is required Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 116104 [details] [review] Bug 27450: Remove password from the mandatory fields when editing details When a patron edit their personal details at the OPAC, the password must be removed from the mandatory fields Test plan: 0 - Don't apply the patch 1 - Set PatronSelfRegistrationBorrowerMandatoryField to require password 2 - Create or sign in as a patron on the opac 3 - Click 'Your personal details' 4 - Attempt to edit 5 - Save changes => They are rejected because not all required fields are populated 6 - Apply the patch 7 - Repeat 3 to 5 => details are saved successfully 8 - Test the self registration feature and confirm that the password is required Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Lucas Gass from comment #1) > IMO this can be best solved in Bug 13188 by separating the OPAC > MandatoryField's into two sys prefs: > > PatronSelfModificationMandatoryField > PatronSelfRegistrationBorrowerMandatoryField I believe you are right in that will be the "right" fix, but I think this will be a nice improvement for the stable branches.
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Pushed to 20.05.x for 20.05.09
Backported: Pushed to 19.11.x branch for 19.11.15