Bugzilla – Attachment 115458 Details for
Bug 27483
Use Modern::Perl in other misc scripts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27483: Deleted unnecessary use warnings comments
Bug-27483-Deleted-unnecessary-use-warnings-comment.patch (text/plain), 3.96 KB, created by
Eden
on 2021-01-20 20:44:09 UTC
(
hide
)
Description:
Bug 27483: Deleted unnecessary use warnings comments
Filename:
MIME Type:
Creator:
Eden
Created:
2021-01-20 20:44:09 UTC
Size:
3.96 KB
patch
obsolete
>From 4f7ef8ade3f6d793998ebf94c6e075a7bf1c4e86 Mon Sep 17 00:00:00 2001 >From: Eden Bacani <eden.bacani@gmail.com> >Date: Wed, 20 Jan 2021 03:30:47 +0000 >Subject: [PATCH] Bug 27483: Deleted unnecessary use warnings comments > >Test Plan >1. check on files below that use warings comments does not exist >2. check on files below that Modern::Perl does not exist as it is >unnecessary. >3. Check that use strict; still exists > >misc/batchCompareMARCvsFrameworks.pl >misc/batchDeleteUnusedSubfields.pl >misc/batchImportMARCWithBiblionumbers.pl >misc/batchRebuildBiblioTables.pl >misc/cronjobs/build_browser_and_cloud.pl >misc/exportauth.pl >misc/kohalib.pl >misc/translator/tmpl_process3.pl >--- > misc/batchCompareMARCvsFrameworks.pl | 1 - > misc/batchDeleteUnusedSubfields.pl | 1 - > misc/batchImportMARCWithBiblionumbers.pl | 1 - > misc/batchRebuildBiblioTables.pl | 2 -- > misc/cronjobs/build_browser_and_cloud.pl | 1 - > misc/exportauth.pl | 1 - > misc/kohalib.pl | 2 -- > misc/translator/tmpl_process3.pl | 1 - > 8 files changed, 10 deletions(-) > >diff --git a/misc/batchCompareMARCvsFrameworks.pl b/misc/batchCompareMARCvsFrameworks.pl >index af8a66796e..90d4a506b3 100755 >--- a/misc/batchCompareMARCvsFrameworks.pl >+++ b/misc/batchCompareMARCvsFrameworks.pl >@@ -3,7 +3,6 @@ > > > use strict; >-#use warnings; FIXME - Bug 2505 > BEGIN { > # find Koha's Perl modules > # test carefully before changing this >diff --git a/misc/batchDeleteUnusedSubfields.pl b/misc/batchDeleteUnusedSubfields.pl >index a80d4fdd6f..04141f464d 100755 >--- a/misc/batchDeleteUnusedSubfields.pl >+++ b/misc/batchDeleteUnusedSubfields.pl >@@ -2,7 +2,6 @@ > # small script that rebuilds the non-MARC DB > > use strict; >-#use warnings; FIXME - Bug 2505 > BEGIN { > # find Koha's Perl modules > # test carefully before changing this >diff --git a/misc/batchImportMARCWithBiblionumbers.pl b/misc/batchImportMARCWithBiblionumbers.pl >index f8a12b5c5c..ffce94ed3a 100755 >--- a/misc/batchImportMARCWithBiblionumbers.pl >+++ b/misc/batchImportMARCWithBiblionumbers.pl >@@ -2,7 +2,6 @@ > # load records that already have biblionumber set into a koha system > # Written by TG on 10/04/2006 > use strict; >-#use warnings; FIXME - Bug 2505 > BEGIN { > # find Koha's Perl modules > # test carefully before changing this >diff --git a/misc/batchRebuildBiblioTables.pl b/misc/batchRebuildBiblioTables.pl >index edc7c16d33..ad15de9675 100755 >--- a/misc/batchRebuildBiblioTables.pl >+++ b/misc/batchRebuildBiblioTables.pl >@@ -3,8 +3,6 @@ > # Formerly named rebuildnonmarc.pl > > use strict; >-#use warnings; FIXME - Bug 2505 >- > BEGIN { > # find Koha's Perl modules > # test carefully before changing this >diff --git a/misc/cronjobs/build_browser_and_cloud.pl b/misc/cronjobs/build_browser_and_cloud.pl >index ccf3ddfa2f..79bf50da96 100755 >--- a/misc/cronjobs/build_browser_and_cloud.pl >+++ b/misc/cronjobs/build_browser_and_cloud.pl >@@ -2,7 +2,6 @@ > # small script that builds the tag cloud > > use strict; >-#use warnings; FIXME - Bug 2505 > BEGIN { > # find Koha's Perl modules > # test carefully before changing this >diff --git a/misc/exportauth.pl b/misc/exportauth.pl >index c036b17063..902afb2c98 100755 >--- a/misc/exportauth.pl >+++ b/misc/exportauth.pl >@@ -4,7 +4,6 @@ > # > > use strict; >-#use warnings; FIXME - Bug 2505 > BEGIN { > # find Koha's Perl modules > # test carefully before changing this >diff --git a/misc/kohalib.pl b/misc/kohalib.pl >index 6c20190e66..9362d28fbd 100755 >--- a/misc/kohalib.pl >+++ b/misc/kohalib.pl >@@ -39,8 +39,6 @@ > # > > use strict; >-#use warnings; FIXME - Bug 2505 >- > my $module_dir; > BEGIN { > $module_dir = '__PERL_MODULE_DIR__'; >diff --git a/misc/translator/tmpl_process3.pl b/misc/translator/tmpl_process3.pl >index 3c04618915..f68322f353 100755 >--- a/misc/translator/tmpl_process3.pl >+++ b/misc/translator/tmpl_process3.pl >@@ -15,7 +15,6 @@ using gettext-compatible translation files > =cut > > use strict; >-#use warnings; FIXME - Bug 2505 > use File::Basename; > use Getopt::Long; > use Locale::PO; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27483
:
115409
| 115458