Bug 27483 - Use Modern::Perl in other misc scripts
Summary: Use Modern::Perl in other misc scripts
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Eden
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks: 2505
  Show dependency treegraph
 
Reported: 2021-01-20 02:40 UTC by Aleisha Amohia
Modified: 2021-10-29 18:54 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 27483: Replaces use strict; and use warnings; with Modern::Perl (4.36 KB, patch)
2021-01-20 03:36 UTC, Eden
Details | Diff | Splinter Review
Bug 27483: Deleted unnecessary use warnings comments (3.96 KB, patch)
2021-01-20 20:44 UTC, Eden
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2021-01-20 02:40:25 UTC
use Modern::Perl in the place of use strict; use warnings;

misc/batchCompareMARCvsFrameworks.pl
misc/batchDeleteUnusedSubfields.pl
misc/batchImportMARCWithBiblionumbers.pl
misc/batchRebuildBiblioTables.pl
misc/cronjobs/build_browser_and_cloud.pl
misc/exportauth.pl
misc/kohalib.pl
misc/translator/tmpl_process3.pl
Comment 1 Eden 2021-01-20 03:36:22 UTC
Created attachment 115409 [details] [review]
Bug 27483: Replaces use strict;  and use warnings; with Modern::Perl

Test Plan
1. check on files below that use strict; and use warings; do not exist
2. check on files below that Modern::Perl exists
misc/batchCompareMARCvsFrameworks.pl
misc/batchDeleteUnusedSubfields.pl
misc/batchImportMARCWithBiblionumbers.pl
misc/batchRebuildBiblioTables.pl
misc/cronjobs/build_browser_and_cloud.pl
misc/exportauth.pl
misc/kohalib.pl
misc/translator/tmpl_process3.pl
Comment 2 Eden 2021-01-20 03:54:51 UTC
Still working on this
Comment 3 Eden 2021-01-20 20:44:09 UTC
Created attachment 115458 [details] [review]
Bug 27483: Deleted unnecessary use warnings comments

Test Plan
1. check on files below that use warings comments does not exist
2. check on files below that Modern::Perl does not exist as it is
unnecessary.
3. Check that use strict; still exists

misc/batchCompareMARCvsFrameworks.pl
misc/batchDeleteUnusedSubfields.pl
misc/batchImportMARCWithBiblionumbers.pl
misc/batchRebuildBiblioTables.pl
misc/cronjobs/build_browser_and_cloud.pl
misc/exportauth.pl
misc/kohalib.pl
misc/translator/tmpl_process3.pl
Comment 4 Eden 2021-01-20 21:36:43 UTC
Still working on it
Comment 5 Eden 2021-01-20 22:49:38 UTC
ready for testing
Comment 6 Tomás Cohen Arazi 2021-10-29 18:54:56 UTC
Hi, Eden.

The idea is to introduce

use Modern::Perl;

Modern::Perl implies 

use strict;
use warnings;

which is desirable. The idea is you should replace

use strict;
#use warnings;

for

use Modern::Perl;

and it will make some warnings show up. And those need to be fixed.