Bugzilla – Attachment 121113 Details for
Bug 28304
C4/Templates::new causes error logs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28304: Quiet a warning from C4/Templates
Bug-28304-Quiet-a-warning-from-C4Templates.patch (text/plain), 948 bytes, created by
Owen Leonard
on 2021-05-18 15:00:41 UTC
(
hide
)
Description:
Bug 28304: Quiet a warning from C4/Templates
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2021-05-18 15:00:41 UTC
Size:
948 bytes
patch
obsolete
>From fd1611b59e39effc91caa9c2eb86a52ad2582ee5 Mon Sep 17 00:00:00 2001 >From: Michael Hafen <michael.hafen@washk12.org> >Date: Fri, 7 May 2021 14:25:11 -0600 >Subject: [PATCH] Bug 28304: Quiet a warning from C4/Templates > >Change the code in C4/Templates::new() which I presume initialized an >instance variable for caching. This call ends up calling a package >method instead. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > C4/Templates.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Templates.pm b/C4/Templates.pm >index 2aeedf662e..48511086ea 100644 >--- a/C4/Templates.pm >+++ b/C4/Templates.pm >@@ -82,7 +82,7 @@ sub new { > bless $self, $class; > $self->theme($theme); > $self->lang($lang); >- $self->activethemes($activethemes); >+ $self->{VARS}->{"activethemes"} = $activethemes; > $self->preferredtheme($activethemes->[0]); > $self->filename($filename); > $self->htdocs($htdocs); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28304
:
120723
| 121113