Bug 28304 - C4/Templates::new causes error logs
Summary: C4/Templates::new causes error logs
Status: RESOLVED DUPLICATE of bug 26734
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Michael Hafen
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-07 20:24 UTC by Michael Hafen
Modified: 2021-05-28 12:22 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Proposed fix (942 bytes, patch)
2021-05-07 20:27 UTC, Michael Hafen 		Details | Diff | Splinter Review
Bug 28304: Quiet a warning from C4/Templates (948 bytes, patch)
2021-05-18 15:00 UTC, Owen Leonard 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Hafen 2021-05-07 20:24:57 UTC 
In C4/Templates::new() there is a call to $self->activethemes(), which I presume is to initialize a class variable.  There is a sub in that packaged named activethemes though, which gets called instead, and results in a few lines in the web server error log because of incorrect parameters.
Comment 1 Michael Hafen 2021-05-07 20:27:21 UTC 
Created attachment 120723 [details] [review]
Proposed fix
Comment 2 Owen Leonard 2021-05-18 15:00:41 UTC 
Created attachment 121113 [details] [review]
Bug 28304: Quiet a warning from C4/Templates

Change the code in C4/Templates::new() which I presume initialized an
instance variable for caching.  This call ends up calling a package
method instead.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2021-05-28 12:21:16 UTC 
Duplicate of bug 26734?

*** This bug has been marked as a duplicate of bug 26734 ***
Comment 4 Jonathan Druart 2021-05-28 12:22:20 UTC 
(In reply to Jonathan Druart from comment #3)
> Duplicate of bug 26734?
> 
> *** This bug has been marked as a duplicate of bug 26734 ***

Sorry, caused by bug 26734, but a recent follow-up has been pushed to fix this problem:

  commit e66d69fa3eaa42f484d47f1fffbf7a91156c3223
  Bug 26734: Rename activethemes with availablethemes