Bugzilla – Attachment 123212 Details for
Bug 28769
tabloop not used in cataloguing plugins
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28769: Remove tabloop from cataloguing plugins
Bug-28769-Remove-tabloop-from-cataloguing-plugins.patch (text/plain), 42.77 KB, created by
Jonathan Druart
on 2021-07-27 14:35:57 UTC
(
hide
)
Description:
Bug 28769: Remove tabloop from cataloguing plugins
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-07-27 14:35:57 UTC
Size:
42.77 KB
patch
obsolete
>From 77343a2a03ce7b1085de2cbe3c707929a0ac0211 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 20 Jul 2021 10:30:30 +0200 >Subject: [PATCH] Bug 28769: Remove tabloop from cataloguing plugins > >There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins. >But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array. > >Actually this tabloop variable is never used from cataloguing plugins, we should remove it. > >Test plan: >Read the code and confirm the above. >You can also test a couple of plugins and confirm that they are still >working. >--- > C4/Items.pm | 2 +- > Koha/FrameworkPlugin.pm | 4 ++-- > authorities/authorities.pl | 14 +++++++------- > cataloguing/addbiblio.pl | 12 ++++++------ > cataloguing/additem.pl | 6 +++--- > cataloguing/value_builder/normarc_field_007.pl | 2 +- > cataloguing/value_builder/normarc_field_008.pl | 2 +- > cataloguing/value_builder/normarc_leader.pl | 2 +- > cataloguing/value_builder/unimarc_field_010.pl | 2 +- > cataloguing/value_builder/unimarc_field_100.pl | 2 +- > .../value_builder/unimarc_field_100_authorities.pl | 2 +- > cataloguing/value_builder/unimarc_field_105.pl | 2 +- > cataloguing/value_builder/unimarc_field_106.pl | 2 +- > cataloguing/value_builder/unimarc_field_110.pl | 2 +- > cataloguing/value_builder/unimarc_field_115a.pl | 2 +- > cataloguing/value_builder/unimarc_field_115b.pl | 2 +- > cataloguing/value_builder/unimarc_field_116.pl | 2 +- > cataloguing/value_builder/unimarc_field_117.pl | 2 +- > cataloguing/value_builder/unimarc_field_120.pl | 2 +- > cataloguing/value_builder/unimarc_field_121a.pl | 2 +- > cataloguing/value_builder/unimarc_field_121b.pl | 2 +- > cataloguing/value_builder/unimarc_field_122.pl | 2 +- > cataloguing/value_builder/unimarc_field_123a.pl | 2 +- > cataloguing/value_builder/unimarc_field_123d.pl | 2 +- > cataloguing/value_builder/unimarc_field_123e.pl | 2 +- > cataloguing/value_builder/unimarc_field_123f.pl | 2 +- > cataloguing/value_builder/unimarc_field_123g.pl | 2 +- > cataloguing/value_builder/unimarc_field_123i.pl | 2 +- > cataloguing/value_builder/unimarc_field_123j.pl | 2 +- > cataloguing/value_builder/unimarc_field_124.pl | 2 +- > cataloguing/value_builder/unimarc_field_124a.pl | 2 +- > cataloguing/value_builder/unimarc_field_124b.pl | 2 +- > cataloguing/value_builder/unimarc_field_124c.pl | 2 +- > cataloguing/value_builder/unimarc_field_124d.pl | 2 +- > cataloguing/value_builder/unimarc_field_124e.pl | 2 +- > cataloguing/value_builder/unimarc_field_124f.pl | 2 +- > cataloguing/value_builder/unimarc_field_124g.pl | 2 +- > cataloguing/value_builder/unimarc_field_125.pl | 2 +- > cataloguing/value_builder/unimarc_field_125a.pl | 2 +- > cataloguing/value_builder/unimarc_field_125b.pl | 2 +- > cataloguing/value_builder/unimarc_field_126.pl | 2 +- > cataloguing/value_builder/unimarc_field_126a.pl | 2 +- > cataloguing/value_builder/unimarc_field_126b.pl | 2 +- > cataloguing/value_builder/unimarc_field_127.pl | 2 +- > cataloguing/value_builder/unimarc_field_128a.pl | 2 +- > cataloguing/value_builder/unimarc_field_128b.pl | 2 +- > cataloguing/value_builder/unimarc_field_128c.pl | 2 +- > cataloguing/value_builder/unimarc_field_130.pl | 2 +- > cataloguing/value_builder/unimarc_field_135a.pl | 2 +- > cataloguing/value_builder/unimarc_field_140.pl | 2 +- > cataloguing/value_builder/unimarc_field_141.pl | 2 +- > cataloguing/value_builder/unimarc_field_210c.pl | 2 +- > .../value_builder/unimarc_field_210c_bis.pl | 2 +- > cataloguing/value_builder/unimarc_field_225a.pl | 2 +- > .../value_builder/unimarc_field_225a_bis.pl | 2 +- > cataloguing/value_builder/unimarc_field_4XX.pl | 4 ++-- > cataloguing/value_builder/unimarc_field_686a.pl | 2 +- > cataloguing/value_builder/unimarc_field_700-4.pl | 2 +- > cataloguing/value_builder/unimarc_leader.pl | 2 +- > t/db_dependent/FrameworkPlugin.t | 2 +- > tools/batchMod.pl | 2 +- > 61 files changed, 76 insertions(+), 76 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 14774e48e17..58e3a71a9c3 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -1809,7 +1809,7 @@ sub PrepareItemrecordDisplay { > name => $subfield->{value_builder}, > item_style => 1, > }); >- my $pars = { dbh => $dbh, record => undef, tagslib =>$tagslib, id => $subfield_data{id}, tabloop => undef }; >+ my $pars = { dbh => $dbh, record => undef, tagslib =>$tagslib, id => $subfield_data{id} }; > $plugin->build( $pars ); > if ( $itemrecord and my $field = $itemrecord->field($tag) ) { > $defaultvalue = $field->subfield($subfield->{subfield}) || q{}; >diff --git a/Koha/FrameworkPlugin.pm b/Koha/FrameworkPlugin.pm >index a50328a1f65..2331bfa6b36 100644 >--- a/Koha/FrameworkPlugin.pm >+++ b/Koha/FrameworkPlugin.pm >@@ -155,7 +155,7 @@ sub new { > Generate html and javascript by calling the builder sub of the plugin. > > Params is a hashref supporting keys: id (=html id for the input field), >- record (MARC record or undef), dbh (database handle), tagslib, tabloop. >+ record (MARC record or undef), dbh (database handle), tagslib. > Note that some of these parameters are not used in most (if not all) > plugins and may be obsoleted in the future (kept for now to provide > backward compatibility). >@@ -276,7 +276,7 @@ sub _generate_js { > > my @params = $self->{oldschool}//0 ? > ( $params->{dbh}, $params->{record}, $params->{tagslib}, >- $params->{id}, $params->{tabloop} ): >+ $params->{id} ): > ( $params ); > my @rv = &$sub( @params ); > return $self->_error( 'Builder sub failed: ' . $@ ) if $@; >diff --git a/authorities/authorities.pl b/authorities/authorities.pl >index 33c37aaf4fb..f735d475784 100755 >--- a/authorities/authorities.pl >+++ b/authorities/authorities.pl >@@ -133,8 +133,8 @@ builds the <input ...> entry for a subfield. > =cut > > sub create_input { >- my ( $tag, $subfield, $value, $index_tag, $tabloop, $rec, $authorised_values_sth,$cgi ) = @_; >- >+ my ( $tag, $subfield, $value, $index_tag, $rec, $authorised_values_sth,$cgi ) = @_; >+ > my $index_subfield = CreateKey(); # create a specifique key for each subfield > > # determine maximum length; 9999 bytes per ISO 2709 except for leader and MARC21 008 >@@ -213,7 +213,7 @@ sub create_input { > name => $tagslib->{$tag}->{$subfield}->{'value_builder'}, > }); > my $pars= { dbh => $dbh, record => $rec, tagslib =>$tagslib, >- id => $subfield_data{id}, tabloop => $tabloop }; >+ id => $subfield_data{id} }; > $plugin->build( $pars ); > if( !$plugin->errstr ) { > $subfield_data{marc_value} = { >@@ -410,7 +410,7 @@ sub build_tabs { > push( > @subfields_data, > &create_input( >- $tag, $subfield, $value, $index_tag, $tabloop, $record, >+ $tag, $subfield, $value, $index_tag, $record, > $authorised_values_sth,$input > ) > ); >@@ -426,7 +426,7 @@ sub build_tabs { > push( > @subfields_data, > &create_input( >- $tag, $subfield, $value, $index_tag, $tabloop, >+ $tag, $subfield, $value, $index_tag, > $record, $authorised_values_sth,$input > ) > ); >@@ -444,7 +444,7 @@ sub build_tabs { > push( > @subfields_data, > &create_input( >- $tag, $subfield, '', $index_tag, $tabloop, $record, >+ $tag, $subfield, '', $index_tag, $record, > $authorised_values_sth,$input > ) > ); >@@ -486,7 +486,7 @@ sub build_tabs { > push( > @subfields_data, > &create_input( >- $tag, $subfield->{subfield}, '', $index_tag, $tabloop, $record, >+ $tag, $subfield->{subfield}, '', $index_tag, $record, > $authorised_values_sth,$input > ) > ); >diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl >index 138fceab445..f68735483ab 100755 >--- a/cataloguing/addbiblio.pl >+++ b/cataloguing/addbiblio.pl >@@ -283,7 +283,7 @@ sub GetMandatoryFieldZ3950 { > =cut > > sub create_input { >- my ( $tag, $subfield, $value, $index_tag, $tabloop, $rec, $authorised_values_sth,$cgi ) = @_; >+ my ( $tag, $subfield, $value, $index_tag, $rec, $authorised_values_sth,$cgi ) = @_; > > my $index_subfield = CreateKey(); # create a specifique key for each subfield > >@@ -393,7 +393,7 @@ sub create_input { > name => $tagslib->{$tag}->{$subfield}->{'value_builder'}, > }); > my $pars= { dbh => $dbh, record => $rec, tagslib => $tagslib, >- id => $subfield_data{id}, tabloop => $tabloop }; >+ id => $subfield_data{id} }; > $plugin->build( $pars ); > if( !$plugin->errstr ) { > $subfield_data{marc_value} = { >@@ -566,7 +566,7 @@ sub build_tabs { > push( > @subfields_data, > &create_input( >- $tag, $subfield, $value, $index_tag, $tabloop, $record, >+ $tag, $subfield, $value, $index_tag, $record, > $authorised_values_sth,$input > ) > ); >@@ -581,7 +581,7 @@ sub build_tabs { > push( > @subfields_data, > &create_input( >- $tag, $subfield, $value, $index_tag, $tabloop, >+ $tag, $subfield, $value, $index_tag, > $record, $authorised_values_sth,$input > ) > ); >@@ -609,7 +609,7 @@ sub build_tabs { > push( > @subfields_data, > &create_input( >- $tag, $subfield, '', $index_tag, $tabloop, $record, >+ $tag, $subfield, '', $index_tag, $record, > $authorised_values_sth,$input > ) > ); >@@ -663,7 +663,7 @@ sub build_tabs { > push( > @subfields_data, > &create_input( >- $tag, $subfield->{subfield}, '', $index_tag, $tabloop, $record, >+ $tag, $subfield->{subfield}, '', $index_tag, $record, > $authorised_values_sth,$input > ) > ); >diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl >index 7ad0ad94458..68c04dc944e 100755 >--- a/cataloguing/additem.pl >+++ b/cataloguing/additem.pl >@@ -59,7 +59,7 @@ use List::MoreUtils qw( any uniq ); > our $dbh = C4::Context->dbh; > > sub generate_subfield_form { >- my ($tag, $subfieldtag, $value, $tagslib,$subfieldlib, $branches, $biblionumber, $temp, $subfields, $i, $restrictededition, $item) = @_; >+ my ($tag, $subfieldtag, $value, $tagslib,$subfieldlib, $branches, $biblionumber, $temp, $i, $restrictededition, $item) = @_; > > my $frameworkcode = &GetFrameworkCode($biblionumber); > >@@ -240,7 +240,7 @@ sub generate_subfield_form { > item_style => 1, > }); > my $pars= { dbh => $dbh, record => $temp, tagslib =>$tagslib, >- id => $subfield_data{id}, tabloop => $subfields }; >+ id => $subfield_data{id} }; > $plugin->build( $pars ); > if( !$plugin->errstr ) { > my $class= 'buttonDot'. ( $plugin->noclick? ' disabled': '' ); >@@ -884,7 +884,7 @@ foreach my $tag ( keys %{$tagslib} ) { > $value, $tagslib, > $subfield, $libraries, > $biblionumber, $temp, >- \@subfields, $i, >+ $i, > $restrictededition, $current_item, > ); > push @subfields, $subfield_data; >diff --git a/cataloguing/value_builder/normarc_field_007.pl b/cataloguing/value_builder/normarc_field_007.pl >index f01b45f9fd1..7a41722f9b0 100755 >--- a/cataloguing/value_builder/normarc_field_007.pl >+++ b/cataloguing/value_builder/normarc_field_007.pl >@@ -26,7 +26,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/normarc_field_008.pl b/cataloguing/value_builder/normarc_field_008.pl >index fc1a9417fa1..12cc771a4da 100755 >--- a/cataloguing/value_builder/normarc_field_008.pl >+++ b/cataloguing/value_builder/normarc_field_008.pl >@@ -36,7 +36,7 @@ sub plugin_javascript { > my $lang = C4::Context->preference('DefaultLanguageField008' ); > $lang = "eng" unless $lang; > $lang = pack("A3", $lang); >- my ($dbh, $record, $tagslib, $field_number, $tabloop) = @_; >+ my ($dbh, $record, $tagslib, $field_number) = @_; > my $function_name = $field_number; > my $res = " > <script> >diff --git a/cataloguing/value_builder/normarc_leader.pl b/cataloguing/value_builder/normarc_leader.pl >index 15ae94a62d2..eac91279ae1 100755 >--- a/cataloguing/value_builder/normarc_leader.pl >+++ b/cataloguing/value_builder/normarc_leader.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_010.pl b/cataloguing/value_builder/unimarc_field_010.pl >index 56a5c5c3ceb..00f5eb05b1a 100755 >--- a/cataloguing/value_builder/unimarc_field_010.pl >+++ b/cataloguing/value_builder/unimarc_field_010.pl >@@ -26,7 +26,7 @@ use C4::Output qw( output_html_with_http_headers ); > > > sub plugin_javascript { >- my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+ my ($dbh,$record,$tagslib,$field_number) = @_; > my $res=" > <script> > function Blur$field_number() { >diff --git a/cataloguing/value_builder/unimarc_field_100.pl b/cataloguing/value_builder/unimarc_field_100.pl >index ef2e08bb9b4..df4c970291d 100755 >--- a/cataloguing/value_builder/unimarc_field_100.pl >+++ b/cataloguing/value_builder/unimarc_field_100.pl >@@ -30,7 +30,7 @@ use C4::Output qw( output_html_with_http_headers ); > > > sub plugin_javascript { >- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my ( $dbh, $record, $tagslib, $field_number ) = @_; > my $res = " > <script> > function Clic$field_number(i) { >diff --git a/cataloguing/value_builder/unimarc_field_100_authorities.pl b/cataloguing/value_builder/unimarc_field_100_authorities.pl >index ff7aa576f32..f15185c430a 100755 >--- a/cataloguing/value_builder/unimarc_field_100_authorities.pl >+++ b/cataloguing/value_builder/unimarc_field_100_authorities.pl >@@ -27,7 +27,7 @@ use C4::Output qw( output_html_with_http_headers ); > > > sub plugin_javascript { >- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my ( $dbh, $record, $tagslib, $field_number ) = @_; > my $res = " > <script> > function Clic$field_number(i) { >diff --git a/cataloguing/value_builder/unimarc_field_105.pl b/cataloguing/value_builder/unimarc_field_105.pl >index e239de664e8..f0ff7f2dd8b 100755 >--- a/cataloguing/value_builder/unimarc_field_105.pl >+++ b/cataloguing/value_builder/unimarc_field_105.pl >@@ -30,7 +30,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >- my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+ my ($dbh,$record,$tagslib,$field_number) = @_; > my $res=" > <script> > function Clic$field_number() { >diff --git a/cataloguing/value_builder/unimarc_field_106.pl b/cataloguing/value_builder/unimarc_field_106.pl >index 488b6ba8891..7b91dd4410b 100755 >--- a/cataloguing/value_builder/unimarc_field_106.pl >+++ b/cataloguing/value_builder/unimarc_field_106.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= "106".(int(rand(100000))+1); > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_110.pl b/cataloguing/value_builder/unimarc_field_110.pl >index 79b173aca75..b3e88e2c207 100755 >--- a/cataloguing/value_builder/unimarc_field_110.pl >+++ b/cataloguing/value_builder/unimarc_field_110.pl >@@ -30,7 +30,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >- my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+ my ($dbh,$record,$tagslib,$field_number) = @_; > my $res=" > <script> > function Clic$field_number() { >diff --git a/cataloguing/value_builder/unimarc_field_115a.pl b/cataloguing/value_builder/unimarc_field_115a.pl >index c741a8fa44c..fc0223a3e65 100755 >--- a/cataloguing/value_builder/unimarc_field_115a.pl >+++ b/cataloguing/value_builder/unimarc_field_115a.pl >@@ -29,7 +29,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my ( $dbh, $record, $tagslib, $field_number ) = @_; > my $res = " > <script> > function Clic$field_number(i) { >diff --git a/cataloguing/value_builder/unimarc_field_115b.pl b/cataloguing/value_builder/unimarc_field_115b.pl >index 55adaf2ca19..901e73eb3e0 100755 >--- a/cataloguing/value_builder/unimarc_field_115b.pl >+++ b/cataloguing/value_builder/unimarc_field_115b.pl >@@ -29,7 +29,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my ( $dbh, $record, $tagslib, $field_number ) = @_; > my $res = " > <script> > function Clic$field_number() { >diff --git a/cataloguing/value_builder/unimarc_field_116.pl b/cataloguing/value_builder/unimarc_field_116.pl >index 858ab48d8a5..8781a5da2f4 100755 >--- a/cataloguing/value_builder/unimarc_field_116.pl >+++ b/cataloguing/value_builder/unimarc_field_116.pl >@@ -29,7 +29,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my ( $dbh, $record, $tagslib, $field_number ) = @_; > my $res = " > <script> > function Clic$field_number(i) { >diff --git a/cataloguing/value_builder/unimarc_field_117.pl b/cataloguing/value_builder/unimarc_field_117.pl >index 4d4223c5c2f..92868261458 100755 >--- a/cataloguing/value_builder/unimarc_field_117.pl >+++ b/cataloguing/value_builder/unimarc_field_117.pl >@@ -29,7 +29,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $res=" > <script> > function Clic$field_number(i) { >diff --git a/cataloguing/value_builder/unimarc_field_120.pl b/cataloguing/value_builder/unimarc_field_120.pl >index 1450a5e35be..4c4d06139d2 100755 >--- a/cataloguing/value_builder/unimarc_field_120.pl >+++ b/cataloguing/value_builder/unimarc_field_120.pl >@@ -30,7 +30,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name=$field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_121a.pl b/cataloguing/value_builder/unimarc_field_121a.pl >index 0da0894d429..e1967e38ca6 100755 >--- a/cataloguing/value_builder/unimarc_field_121a.pl >+++ b/cataloguing/value_builder/unimarc_field_121a.pl >@@ -29,7 +29,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_121b.pl b/cataloguing/value_builder/unimarc_field_121b.pl >index bc5bf1ec951..bcdc22aac0a 100755 >--- a/cataloguing/value_builder/unimarc_field_121b.pl >+++ b/cataloguing/value_builder/unimarc_field_121b.pl >@@ -27,7 +27,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_122.pl b/cataloguing/value_builder/unimarc_field_122.pl >index 0b326c443c6..ecedc74cc23 100755 >--- a/cataloguing/value_builder/unimarc_field_122.pl >+++ b/cataloguing/value_builder/unimarc_field_122.pl >@@ -27,7 +27,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_123a.pl b/cataloguing/value_builder/unimarc_field_123a.pl >index cf74e41029d..3d3fa4f56f8 100755 >--- a/cataloguing/value_builder/unimarc_field_123a.pl >+++ b/cataloguing/value_builder/unimarc_field_123a.pl >@@ -27,7 +27,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_123d.pl b/cataloguing/value_builder/unimarc_field_123d.pl >index 9fb25ffb2ea..50865fb2eba 100755 >--- a/cataloguing/value_builder/unimarc_field_123d.pl >+++ b/cataloguing/value_builder/unimarc_field_123d.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_123e.pl b/cataloguing/value_builder/unimarc_field_123e.pl >index 9fb25ffb2ea..50865fb2eba 100755 >--- a/cataloguing/value_builder/unimarc_field_123e.pl >+++ b/cataloguing/value_builder/unimarc_field_123e.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_123f.pl b/cataloguing/value_builder/unimarc_field_123f.pl >index 660d601df6f..4fb190e52a8 100755 >--- a/cataloguing/value_builder/unimarc_field_123f.pl >+++ b/cataloguing/value_builder/unimarc_field_123f.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_123g.pl b/cataloguing/value_builder/unimarc_field_123g.pl >index 9fb25ffb2ea..50865fb2eba 100755 >--- a/cataloguing/value_builder/unimarc_field_123g.pl >+++ b/cataloguing/value_builder/unimarc_field_123g.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_123i.pl b/cataloguing/value_builder/unimarc_field_123i.pl >index 51d6477673c..a62c23ab37b 100755 >--- a/cataloguing/value_builder/unimarc_field_123i.pl >+++ b/cataloguing/value_builder/unimarc_field_123i.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_123j.pl b/cataloguing/value_builder/unimarc_field_123j.pl >index 7ca7f07d3ab..aa2a3c31e07 100755 >--- a/cataloguing/value_builder/unimarc_field_123j.pl >+++ b/cataloguing/value_builder/unimarc_field_123j.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_124.pl b/cataloguing/value_builder/unimarc_field_124.pl >index cfcb8d7c7fe..82ab72d4f41 100755 >--- a/cataloguing/value_builder/unimarc_field_124.pl >+++ b/cataloguing/value_builder/unimarc_field_124.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_124a.pl b/cataloguing/value_builder/unimarc_field_124a.pl >index 9d14d7a9fd2..ef2e7dccb70 100755 >--- a/cataloguing/value_builder/unimarc_field_124a.pl >+++ b/cataloguing/value_builder/unimarc_field_124a.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_124b.pl b/cataloguing/value_builder/unimarc_field_124b.pl >index e004bddfd89..9008ea673c5 100755 >--- a/cataloguing/value_builder/unimarc_field_124b.pl >+++ b/cataloguing/value_builder/unimarc_field_124b.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_124c.pl b/cataloguing/value_builder/unimarc_field_124c.pl >index 19f8a130ab5..3433ea9a93c 100755 >--- a/cataloguing/value_builder/unimarc_field_124c.pl >+++ b/cataloguing/value_builder/unimarc_field_124c.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_124d.pl b/cataloguing/value_builder/unimarc_field_124d.pl >index a100375532b..e65d93eaa2c 100755 >--- a/cataloguing/value_builder/unimarc_field_124d.pl >+++ b/cataloguing/value_builder/unimarc_field_124d.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_124e.pl b/cataloguing/value_builder/unimarc_field_124e.pl >index 73226113aea..11d1aabfa34 100755 >--- a/cataloguing/value_builder/unimarc_field_124e.pl >+++ b/cataloguing/value_builder/unimarc_field_124e.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_124f.pl b/cataloguing/value_builder/unimarc_field_124f.pl >index 8a0836a7a55..96df17be7a7 100755 >--- a/cataloguing/value_builder/unimarc_field_124f.pl >+++ b/cataloguing/value_builder/unimarc_field_124f.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_124g.pl b/cataloguing/value_builder/unimarc_field_124g.pl >index 3f40b1e9e9e..4dfe3a7d9f9 100755 >--- a/cataloguing/value_builder/unimarc_field_124g.pl >+++ b/cataloguing/value_builder/unimarc_field_124g.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_125.pl b/cataloguing/value_builder/unimarc_field_125.pl >index 4eb86d9cbf3..fa312008618 100755 >--- a/cataloguing/value_builder/unimarc_field_125.pl >+++ b/cataloguing/value_builder/unimarc_field_125.pl >@@ -34,7 +34,7 @@ plugin_parameters : other parameters added when the plugin is called by the dopo > =cut > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_125a.pl b/cataloguing/value_builder/unimarc_field_125a.pl >index 947050f38d8..c4585d7e24e 100755 >--- a/cataloguing/value_builder/unimarc_field_125a.pl >+++ b/cataloguing/value_builder/unimarc_field_125a.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_125b.pl b/cataloguing/value_builder/unimarc_field_125b.pl >index d5569498355..2429d3e48bd 100755 >--- a/cataloguing/value_builder/unimarc_field_125b.pl >+++ b/cataloguing/value_builder/unimarc_field_125b.pl >@@ -29,7 +29,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_126.pl b/cataloguing/value_builder/unimarc_field_126.pl >index cfcb8d7c7fe..82ab72d4f41 100755 >--- a/cataloguing/value_builder/unimarc_field_126.pl >+++ b/cataloguing/value_builder/unimarc_field_126.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_126a.pl b/cataloguing/value_builder/unimarc_field_126a.pl >index f5ed0f7f03b..d1cfd84c4c9 100755 >--- a/cataloguing/value_builder/unimarc_field_126a.pl >+++ b/cataloguing/value_builder/unimarc_field_126a.pl >@@ -29,7 +29,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_126b.pl b/cataloguing/value_builder/unimarc_field_126b.pl >index 1c261bcc807..79778cfe44d 100755 >--- a/cataloguing/value_builder/unimarc_field_126b.pl >+++ b/cataloguing/value_builder/unimarc_field_126b.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_127.pl b/cataloguing/value_builder/unimarc_field_127.pl >index 9845a547edc..85adba0dad0 100755 >--- a/cataloguing/value_builder/unimarc_field_127.pl >+++ b/cataloguing/value_builder/unimarc_field_127.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_128a.pl b/cataloguing/value_builder/unimarc_field_128a.pl >index 4b6ad8e90ad..9f235e1e5d4 100755 >--- a/cataloguing/value_builder/unimarc_field_128a.pl >+++ b/cataloguing/value_builder/unimarc_field_128a.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_128b.pl b/cataloguing/value_builder/unimarc_field_128b.pl >index 1c860bf3b91..7d2e215fb8e 100755 >--- a/cataloguing/value_builder/unimarc_field_128b.pl >+++ b/cataloguing/value_builder/unimarc_field_128b.pl >@@ -29,7 +29,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_128c.pl b/cataloguing/value_builder/unimarc_field_128c.pl >index 56ce4a1d688..a0ff9ddd4e4 100755 >--- a/cataloguing/value_builder/unimarc_field_128c.pl >+++ b/cataloguing/value_builder/unimarc_field_128c.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_130.pl b/cataloguing/value_builder/unimarc_field_130.pl >index 19db6d63217..411eb80a8ea 100755 >--- a/cataloguing/value_builder/unimarc_field_130.pl >+++ b/cataloguing/value_builder/unimarc_field_130.pl >@@ -30,7 +30,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_135a.pl b/cataloguing/value_builder/unimarc_field_135a.pl >index 050f8ec8209..db5bf3c8b07 100755 >--- a/cataloguing/value_builder/unimarc_field_135a.pl >+++ b/cataloguing/value_builder/unimarc_field_135a.pl >@@ -29,7 +29,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_140.pl b/cataloguing/value_builder/unimarc_field_140.pl >index 467ecb412a1..a5b303158bb 100755 >--- a/cataloguing/value_builder/unimarc_field_140.pl >+++ b/cataloguing/value_builder/unimarc_field_140.pl >@@ -30,7 +30,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_141.pl b/cataloguing/value_builder/unimarc_field_141.pl >index 907f3e39af4..a7a28ea3060 100755 >--- a/cataloguing/value_builder/unimarc_field_141.pl >+++ b/cataloguing/value_builder/unimarc_field_141.pl >@@ -28,7 +28,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res=" > <script> >diff --git a/cataloguing/value_builder/unimarc_field_210c.pl b/cataloguing/value_builder/unimarc_field_210c.pl >index 4ffc85f6030..d767023471a 100755 >--- a/cataloguing/value_builder/unimarc_field_210c.pl >+++ b/cataloguing/value_builder/unimarc_field_210c.pl >@@ -30,7 +30,7 @@ use C4::Koha qw( getnbpages ); > ###TODO To rewrite in order to use SearchAuthorities > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > #---- build editors list. > #---- the editor list is built from the "EDITORS" thesaurus >diff --git a/cataloguing/value_builder/unimarc_field_210c_bis.pl b/cataloguing/value_builder/unimarc_field_210c_bis.pl >index 5204ddd6623..b558d520d27 100755 >--- a/cataloguing/value_builder/unimarc_field_210c_bis.pl >+++ b/cataloguing/value_builder/unimarc_field_210c_bis.pl >@@ -48,7 +48,7 @@ use C4::Auth qw( get_template_and_user ); > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my ( $dbh, $record, $tagslib, $field_number ) = @_; > my $function_name = $field_number; > my $res = " > <script> >diff --git a/cataloguing/value_builder/unimarc_field_225a.pl b/cataloguing/value_builder/unimarc_field_225a.pl >index 761302cd23e..31556ae5067 100755 >--- a/cataloguing/value_builder/unimarc_field_225a.pl >+++ b/cataloguing/value_builder/unimarc_field_225a.pl >@@ -56,7 +56,7 @@ plugin_parameters : other parameters added when the plugin is called by the dopo > =cut > > sub plugin_javascript { >- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my ( $dbh, $record, $tagslib, $field_number ) = @_; > my $function_name = $field_number; > my $res = " > <script> >diff --git a/cataloguing/value_builder/unimarc_field_225a_bis.pl b/cataloguing/value_builder/unimarc_field_225a_bis.pl >index 5bfedad414c..1ca62775a99 100755 >--- a/cataloguing/value_builder/unimarc_field_225a_bis.pl >+++ b/cataloguing/value_builder/unimarc_field_225a_bis.pl >@@ -31,7 +31,7 @@ use C4::Context; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my ( $dbh, $record, $tagslib, $field_number ) = @_; > my $function_name = $field_number; > my $res = " > <script> >diff --git a/cataloguing/value_builder/unimarc_field_4XX.pl b/cataloguing/value_builder/unimarc_field_4XX.pl >index 832305929af..4a055ae3dab 100755 >--- a/cataloguing/value_builder/unimarc_field_4XX.pl >+++ b/cataloguing/value_builder/unimarc_field_4XX.pl >@@ -36,12 +36,12 @@ use Koha::SearchEngine; > use Koha::SearchEngine::Search; > > sub plugin_parameters { >- my ( $dbh, $record, $tagslib, $i, $tabloop ) = @_; >+ my ( $dbh, $record, $tagslib, $i ) = @_; > return ""; > } > > sub plugin_javascript { >- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my ( $dbh, $record, $tagslib, $field_number ) = @_; > my $function_name = $field_number; > my $res = " > <script> >diff --git a/cataloguing/value_builder/unimarc_field_686a.pl b/cataloguing/value_builder/unimarc_field_686a.pl >index 38a1e48513e..d766b038c63 100755 >--- a/cataloguing/value_builder/unimarc_field_686a.pl >+++ b/cataloguing/value_builder/unimarc_field_686a.pl >@@ -27,7 +27,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res = " > <script> >diff --git a/cataloguing/value_builder/unimarc_field_700-4.pl b/cataloguing/value_builder/unimarc_field_700-4.pl >index 895db7a1d28..0d083e9d399 100755 >--- a/cataloguing/value_builder/unimarc_field_700-4.pl >+++ b/cataloguing/value_builder/unimarc_field_700-4.pl >@@ -29,7 +29,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name= $field_number; > my $res = " > <script> >diff --git a/cataloguing/value_builder/unimarc_leader.pl b/cataloguing/value_builder/unimarc_leader.pl >index 44d8c9319c2..838f5a88f09 100755 >--- a/cataloguing/value_builder/unimarc_leader.pl >+++ b/cataloguing/value_builder/unimarc_leader.pl >@@ -29,7 +29,7 @@ use C4::Search; > use C4::Output qw( output_html_with_http_headers ); > > sub plugin_javascript { >- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my ( $dbh, $record, $tagslib, $field_number ) = @_; > my $function_name = $field_number; > my $res = " > <script> >diff --git a/t/db_dependent/FrameworkPlugin.t b/t/db_dependent/FrameworkPlugin.t >index f05c8105faa..4310b65f0e9 100755 >--- a/t/db_dependent/FrameworkPlugin.t >+++ b/t/db_dependent/FrameworkPlugin.t >@@ -203,7 +203,7 @@ sub old01 { > # includes a typical empty Clic function and plugin subroutine > return mytempfile( <<'HERE' > sub plugin_javascript { >- my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >+ my ($dbh,$record,$tagslib,$field_number) = @_; > my $function_name = $field_number; > my $res = " > <script type=\"text/javascript\"> >diff --git a/tools/batchMod.pl b/tools/batchMod.pl >index 4f0efe833e7..6986531be68 100755 >--- a/tools/batchMod.pl >+++ b/tools/batchMod.pl >@@ -532,7 +532,7 @@ foreach my $tag (sort keys %{$tagslib}) { > }); > my $temp; > my $pars= { dbh => $dbh, record => $temp, tagslib => $tagslib, >- id => $subfield_data{id}, tabloop => \@loop_data }; >+ id => $subfield_data{id} }; > $plugin->build( $pars ); > if( !$plugin->errstr ) { > $subfield_data{marc_value} = { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28769
:
123212
|
125748
|
126085
|
126304
|
126305