There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins. But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array. Actually this tabloop variable is never used from cataloguing plugins, we should remove it.
Created attachment 123212 [details] [review] Bug 28769: Remove tabloop from cataloguing plugins There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins. But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array. Actually this tabloop variable is never used from cataloguing plugins, we should remove it. Test plan: Read the code and confirm the above. You can also test a couple of plugins and confirm that they are still working.
This is a trivial change, *but* it needs to be advertised because it might break custom cataloguing plugins.
Created attachment 125748 [details] [review] Bug 28769: Remove tabloop from cataloguing plugins There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins. But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array. Actually this tabloop variable is never used from cataloguing plugins, we should remove it. Test plan: Read the code and confirm the above. You can also test a couple of plugins and confirm that they are still working. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 126085 [details] [review] Bug 28769: Remove tabloop from cataloguing plugins There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins. But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array. Actually this tabloop variable is never used from cataloguing plugins, we should remove it. Test plan: Read the code and confirm the above. You can also test a couple of plugins and confirm that they are still working. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(In reply to Tomás Cohen Arazi from comment #2) > This is a trivial change, *but* it needs to be advertised because it might > break custom cataloguing plugins. Hmm. So trivial for skipping QA ?
Do you think it needs an additional pair of eyes on this patch, Marcel?
(In reply to Jonathan Druart from comment #6) > Do you think it needs an additional pair of eyes on this patch, Marcel? Well, at least might need. I will do it this week. Note that comment2 is no recommendation for using the fast lane :)
QAing
I wonder who wrote this in 2014: Note that some of these parameters are not used in most (if not all) plugins and may be obsoleted in the future (kept for now to provide backward compatibility). Somehow I mixed up tabloop and tagslib. Tabloop is probably the most useless one to pass. But tagslib might be a good candidate too now, especially since we cache these structures now.
Created attachment 126304 [details] [review] Bug 28769: Remove tabloop from cataloguing plugins There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins. But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array. Actually this tabloop variable is never used from cataloguing plugins, we should remove it. Test plan: Read the code and confirm the above. You can also test a couple of plugins and confirm that they are still working. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 126305 [details] [review] Bug 28769: (QA follow-up) Fix another occurrence Framework plugin unimarc_leader_authorities.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 21.11, thanks to everybody involved!