Bugzilla – Attachment 126429 Details for
Bug 27287
Make note fields from orders searchable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27287: (QA follow-up) Unit tests
Bug-27287-QA-follow-up-Unit-tests.patch (text/plain), 3.98 KB, created by
Nick Clemens (kidclamp)
on 2021-10-18 11:44:04 UTC
(
hide
)
Description:
Bug 27287: (QA follow-up) Unit tests
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-10-18 11:44:04 UTC
Size:
3.98 KB
patch
obsolete
>From 233e2e17f7f7cc199b725fa45a7f2e38e39da4c3 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 18 Oct 2021 11:43:07 +0000 >Subject: [PATCH] Bug 27287: (QA follow-up) Unit tests > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/db_dependent/Acquisition.t | 29 +++++++++++++++++++---------- > 1 file changed, 19 insertions(+), 10 deletions(-) > >diff --git a/t/db_dependent/Acquisition.t b/t/db_dependent/Acquisition.t >index f9f27d1d54..402e222d79 100755 >--- a/t/db_dependent/Acquisition.t >+++ b/t/db_dependent/Acquisition.t >@@ -19,7 +19,7 @@ use Modern::Perl; > > use POSIX qw(strftime); > >-use Test::More tests => 66; >+use Test::More tests => 70; > use t::lib::Mocks; > use Koha::Database; > use Koha::DateUtils qw(dt_from_string output_pref); >@@ -173,7 +173,7 @@ my ( $biblionumber5, $biblioitemnumber5 ) = AddBiblio( MARC::Record->new, '' ); > > > >-# Prepare 5 orders, and make distinction beween fields to be tested with eq and with == >+# Prepare 6 orders, and make distinction beween fields to be tested with eq and with == > # Ex : a price of 50.1 will be stored internally as 5.100000 > > my @order_content = ( >@@ -183,8 +183,8 @@ my @order_content = ( > biblionumber => $biblionumber1, > budget_id => $budget->{budget_id}, > uncertainprice => 0, >- order_internalnote => "internal note", >- order_vendornote => "vendor note", >+ order_internalnote => "internal note foo", >+ order_vendornote => "vendor note bar", > ordernumber => '', > }, > num => { >@@ -209,8 +209,8 @@ my @order_content = ( > biblionumber => $biblionumber2, > budget_id => $budget->{budget_id}, > uncertainprice => 0, >- order_internalnote => "internal note", >- order_vendornote => "vendor note" >+ order_internalnote => "internal note foo", >+ order_vendornote => "vendor note bar" > }, > num => { > quantity => 4, >@@ -246,8 +246,8 @@ my @order_content = ( > basketno => $basketno, > biblionumber => $biblionumber4, > budget_id => $budget->{budget_id}, >- order_internalnote => "internal note", >- order_vendornote => "vendor note" >+ order_internalnote => "internal note bar", >+ order_vendornote => "vendor note foo" > }, > num => { > quantity => 1, >@@ -281,7 +281,7 @@ my @order_content = ( > } > ); > >-# Create 5 orders in database >+# Create 6 orders in database > for ( 0 .. 5 ) { > my %ocontent; > @ocontent{ keys %{ $order_content[$_]->{num} } } = >@@ -444,7 +444,7 @@ is( $order2->{order_internalnote}, "my notes", > my $order1 = GetOrder( $ordernumbers[0] ); > is( > $order1->{order_internalnote}, >- "internal note", >+ "internal note foo", > "ModReceiveOrder only changes the supplied orders internal notes" > ); > >@@ -466,6 +466,15 @@ is( scalar( @$orders ), 1, 'GetHistory with a given ordernumbers returns 1 order > $orders = GetHistory( ordernumbers => \@ordernumbers ); > is( scalar( @$orders ), scalar( @ordernumbers ) - 1, 'GetHistory with a list of ordernumbers returns N-1 orders (was has been deleted [3])' ); > >+$orders = GetHistory( internalnote => 'internal note foo' ); >+is( scalar( @$orders ), 2, 'GetHistory returns correctly a search for internalnote' ); >+$orders = GetHistory( vendornote => 'vendor note bar' ); >+is( scalar( @$orders ), 2, 'GetHistory returns correctly a search for vendornote' ); >+$orders = GetHistory( internalnote => 'internal note bar' ); >+is( scalar( @$orders ), 1, 'GetHistory returns correctly a search for internalnote' ); >+$orders = GetHistory( vendornote => 'vendor note foo' ); >+is( scalar( @$orders ), 1, 'GetHistory returns correctly a search for vendornote' ); >+ > > # Test GetHistory() with and without SearchWithISBNVariations > # The ISBN passed as a param is the ISBN-10 version of the 13-digit ISBN in the sample record declared in $marcxml >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27287
:
123864
|
123874
|
126428
| 126429 |
126654