Bugzilla – Attachment 129767 Details for
Bug 29944
Non-superlibrarian patrons can't see holds from other libraries, but superlibrarian can.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29944: Non-superlibrarian patrons can't see holds from other libraries, but superlibrarian can.
Bug-29944-Non-superlibrarian-patrons-cant-see-hold.patch (text/plain), 2.72 KB, created by
The Minh Luong
on 2022-01-25 15:32:28 UTC
(
hide
)
Description:
Bug 29944: Non-superlibrarian patrons can't see holds from other libraries, but superlibrarian can.
Filename:
MIME Type:
Creator:
The Minh Luong
Created:
2022-01-25 15:32:28 UTC
Size:
2.72 KB
patch
obsolete
>From 9d2ed0c8bee12914088831f92f521e6ef6005754 Mon Sep 17 00:00:00 2001 >From: The Minh Luong <the-minh.luong@inlibro.com> >Date: Tue, 25 Jan 2022 10:30:36 -0500 >Subject: [PATCH] Bug 29944: Non-superlibrarian patrons can't see holds from > other libraries, but superlibrarian can. > >The module "Holds queue" is modified in this patch. Holds from all libraries are displayed for superlibrarian patrons. However, holds from other libraries are not displayed for non-superlibrarian patrons. > >To test: >1) Select "Yes" for the preferences "IndependentBranches", "IndependentBranchesPatronModifications" and "IndependentBranchesTransfers". > >2) Create a patron with limited permissions (Not superlibrarian). > >3) To give permissions to a patron, click on "More" on the patron's profile (on the top right), then in the drop-down menu, click on "Set permissions". You can now give your patron permissions. Here is an example of permissions that you can give to a limited patron: > - circulate (all) > - catalogue > - borrowers > - delete_borrowers > - edit_borrowers > - reserveforothers (all) > - reports (all) > >4) Create a superlibrarian patron. (Make sure that patron is in a different library than your limited patron) > >5) Log in in OPAC as your superlibrarian patron. > >6) Place an hold for an available item. > >7) Run misc/cronjobs/holds/build_holds_queue.pl > >8) Go to Circulation > Holds queue, click "Submit" and make sure you can see the hold. > >9) Log in as your limited patron. > >11) Go to Circulation > Holds queue > >10) In the drop-down menu, choose "All" and click "Submit". > >12) Notice that you can see your superlibrarian patron's hold. > >13) Apply the patch. > >14) Notice that the "All" option is no longer available for the limited patron. Limited patrons can't see holds from other libraries anymore. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >index b3c73577b2..c409c612a8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >@@ -237,7 +237,9 @@ > <li> > <label for="branchlimit">Library: </label> > <select name="branchlimit" id="branchlimit"> >+ [% IF Koha.Preference('IndependentBranches') && CAN_user_superlibrarian %] > <option value="">All</option> >+ [% END %] > [% PROCESS options_for_libraries libraries => Branches.all( selected => branchlimit, only_from_group => 1 ) %] > </select> > </li> >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29944
: 129767