The module "Holds queue" is modified in this patch. Holds from all libraries are displayed for superlibrarian patrons. However, holds from other libraries are not displayed for non-superlibrarian patrons. To test: 1) Select "Yes" for the preferences "IndependentBranches", "IndependentBranchesPatronModifications" and "IndependentBranchesTransfers". 2) Create a patron with limited permissions (Not superlibrarian). 3) To give permissions to a patron, click on "More" on the patron's profile (on the top right), then in the drop-down menu, click on "Set permissions". You can now give your patron permissions. Here is an example of permissions that you can give to a limited patron: - circulate (all) - catalogue - borrowers - delete_borrowers - edit_borrowers - reserveforothers (all) - reports (all) 4) Create a superlibrarian patron. (Make sure that patron is in a different library than your limited patron) 5) Log in in OPAC as your superlibrarian patron. 6) Place an hold for an available item. 7) Run misc/cronjobs/holds/build_holds_queue.pl 8) Go to Circulation > Holds queue, click "Submit" and make sure you can see the hold. 9) Log in as your limited patron. 11) Go to Circulation > Holds queue 10) In the drop-down menu, choose "All" and click "Submit". 12) Notice that you can see your superlibrarian patron's hold. 13) Apply the patch. 14) Notice that the "All" option is no longer available for the limited patron. Limited patrons can't see holds from other libraries anymore.
Created attachment 129767 [details] [review] Bug 29944: Non-superlibrarian patrons can't see holds from other libraries, but superlibrarian can. The module "Holds queue" is modified in this patch. Holds from all libraries are displayed for superlibrarian patrons. However, holds from other libraries are not displayed for non-superlibrarian patrons. To test: 1) Select "Yes" for the preferences "IndependentBranches", "IndependentBranchesPatronModifications" and "IndependentBranchesTransfers". 2) Create a patron with limited permissions (Not superlibrarian). 3) To give permissions to a patron, click on "More" on the patron's profile (on the top right), then in the drop-down menu, click on "Set permissions". You can now give your patron permissions. Here is an example of permissions that you can give to a limited patron: - circulate (all) - catalogue - borrowers - delete_borrowers - edit_borrowers - reserveforothers (all) - reports (all) 4) Create a superlibrarian patron. (Make sure that patron is in a different library than your limited patron) 5) Log in in OPAC as your superlibrarian patron. 6) Place an hold for an available item. 7) Run misc/cronjobs/holds/build_holds_queue.pl 8) Go to Circulation > Holds queue, click "Submit" and make sure you can see the hold. 9) Log in as your limited patron. 11) Go to Circulation > Holds queue 10) In the drop-down menu, choose "All" and click "Submit". 12) Notice that you can see your superlibrarian patron's hold. 13) Apply the patch. 14) Notice that the "All" option is no longer available for the limited patron. Limited patrons can't see holds from other libraries anymore.
*** This bug has been marked as a duplicate of bug 28975 ***