Bugzilla – Attachment 139927 Details for
Bug 31315
Remove GetItemsInfo from moredetail
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31315: (QA follow-up) Show itemtype description instead of database code
Bug-31315-QA-follow-up-Show-itemtype-description-i.patch (text/plain), 2.24 KB, created by
Joonas Kylmälä
on 2022-08-28 15:30:50 UTC
(
hide
)
Description:
Bug 31315: (QA follow-up) Show itemtype description instead of database code
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2022-08-28 15:30:50 UTC
Size:
2.24 KB
patch
obsolete
>From 06fe8da89278bc6b7bdbdcf5454c2b5e4880baa8 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi> >Date: Sun, 28 Aug 2022 15:26:28 +0000 >Subject: [PATCH] Bug 31315: (QA follow-up) Show itemtype description instead > of database code >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This restores the previous definition for itype that displayed the >description instead of itemtype. > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> >--- > catalogue/moredetail.pl | 3 ++- > .../intranet-tmpl/prog/en/modules/catalogue/moredetail.tt | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/catalogue/moredetail.pl b/catalogue/moredetail.pl >index a4ed85e03a..90f2de0b07 100755 >--- a/catalogue/moredetail.pl >+++ b/catalogue/moredetail.pl >@@ -151,7 +151,8 @@ foreach my $item (@items){ > > my $item_info = $item->unblessed; > $item_info->{object} = $item; >- $item_info->{itemtype} = $itemtypes->{$item->effective_itemtype}; >+ $item_info->{itype} = $itemtypes->{ $item->itype }->{'translated_description'} if exists $itemtypes->{ $item->itype }; >+ $item_info->{effective_itemtype} = $itemtypes->{$item->effective_itemtype}; > $item_info->{'ccode'} = $ccodes->{ $item->ccode } if $ccodes && $item->ccode && exists $ccodes->{ $item->ccode }; > if ( defined $item->copynumber ) { > $item_info->{'displaycopy'} = 1; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >index 5c8dacb0a4..7b8cf7c8ba 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >@@ -89,7 +89,7 @@ > > [% FOREACH ITEM_DAT IN ITEM_DATA %] > [% SET not_for_loan = 0 %] >- [% IF ITEM_DAT.notforloan || ITEM_DAT.itemtype.notforloan %] >+ [% IF ITEM_DAT.notforloan || ITEM_DAT.effective_itemtype.notforloan %] > [% SET not_for_loan = 1 %] > [% SET not_for_loan_description = AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.notforloan', authorised_value => item.notforloan ) %] > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31315
:
138824
|
138897
|
139926
| 139927