Bug 31315 - Remove GetItemsInfo from moredetail
Summary: Remove GetItemsInfo from moredetail
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Joonas Kylmälä
URL:
Keywords:
Depends on: 31306
Blocks: 27272 32272 32583 32585
  Show dependency treegraph
 
Reported: 2022-08-08 14:22 UTC by Jonathan Druart
Modified: 2023-12-28 20:43 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31315: Remove GetHostItemsInfo and GetItemsInfo from moredetail (12.89 KB, patch)
2022-08-08 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31315: Remove GetHostItemsInfo and GetItemsInfo from moredetail (12.93 KB, patch)
2022-08-09 11:17 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31315: Remove GetHostItemsInfo and GetItemsInfo from moredetail (13.08 KB, patch)
2022-08-28 15:30 UTC, Joonas Kylmälä
Details | Diff | Splinter Review
Bug 31315: (QA follow-up) Show itemtype description instead of database code (2.24 KB, patch)
2022-08-28 15:30 UTC, Joonas Kylmälä
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-08-08 14:22:56 UTC
Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with moredetail
Comment 1 Jonathan Druart 2022-08-08 14:51:26 UTC
Created attachment 138824 [details] [review]
Bug 31315: Remove GetHostItemsInfo and GetItemsInfo from moredetail

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search.

Here we are going to deal with catalogue/moredetail

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly
Comment 2 Owen Leonard 2022-08-09 11:17:50 UTC
Created attachment 138897 [details] [review]
Bug 31315: Remove GetHostItemsInfo and GetItemsInfo from moredetail

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search.

Here we are going to deal with catalogue/moredetail

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Joonas Kylmälä 2022-08-20 13:18:43 UTC
Item type field shows after this patch only the itemtype code, not the description.
Comment 4 Joonas Kylmälä 2022-08-28 15:30:45 UTC
Created attachment 139926 [details] [review]
Bug 31315: Remove GetHostItemsInfo and GetItemsInfo from moredetail

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search.

Here we are going to deal with catalogue/moredetail

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Comment 5 Joonas Kylmälä 2022-08-28 15:30:50 UTC
Created attachment 139927 [details] [review]
Bug 31315: (QA follow-up) Show itemtype description instead of database code

This restores the previous definition for itype that displayed the
description instead of itemtype.

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Comment 6 Tomás Cohen Arazi 2022-08-31 11:52:12 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Lucas Gass 2022-10-31 19:03:43 UTC
Enhancement will not be included in 22.05.x series