Bugzilla – Attachment 141852 Details for
Bug 31783
Table settings page needs page-section class
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31783: Add page-section to columns_settings.tt page
Bug-31783-Add-page-section-to-columnssettingstt-pa.patch (text/plain), 2.67 KB, created by
Lucas Gass
on 2022-10-13 23:17:25 UTC
(
hide
)
Description:
Bug 31783: Add page-section to columns_settings.tt page
Filename:
MIME Type:
Creator:
Lucas Gass
Created:
2022-10-13 23:17:25 UTC
Size:
2.67 KB
patch
obsolete
>From 7d7f15196f148d22afaaceeade91faf3388fe386 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 13 Oct 2022 23:13:22 +0000 >Subject: [PATCH] Bug 31783: Add page-section to columns_settings.tt page > >This patch adds the page-section class to the tables on the Table settings page. > >To test: > >1. Apply patch and go to Administration > Table settings >2. Make sure the tables look good with the new page-section class, which is added to an existing div in this case. >3. Make sure that changing some table setting still works and you can properly save new settings. > >Note: This patch moves the fieldset which contains the Save button into the page-section div. >--- > .../prog/en/modules/admin/columns_settings.tt | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >index 30ee078718..998d54f174 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >@@ -21,7 +21,7 @@ > [% IF tables.$pagename.keys and tables.$pagename.keys.size > 0 %] > [% FOR tablename IN tables.$pagename.keys.sort %] > [% SET table_id = pagename _ '#' _ tablename %] >- <div class="datatable_config" id="[% table_id | html %]"> >+ <div class="datatable_config page-section" id="[% table_id | html %]"> > <input type="hidden" name="table_id" value="[% table_id| html %]" /> > [% IF pagename == 'additem' AND tablename == 'itemst' %] > <div class="alert">Changes made below will only apply to item subfields that are mapped to the 'items' table. <a href="/cgi-bin/koha/admin/koha2marclinks.pl?tablename=items">Go to Koha to MARC mapping</a></div> >@@ -136,12 +136,11 @@ > </select> > </p> > [% END %] >- >+ <fieldset class="action"> >+ <input type="submit" value="Save" /> >+ </fieldset> > </div> > [% END %] >- <fieldset class="action"> >- <input type="submit" value="Save" /> >- </fieldset> > [% ELSE %] > There is no table to configure for this module. > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31783
: 141852