Bug 31783 - Table settings page needs page-section class
Summary: Table settings page needs page-section class
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-13 23:12 UTC by Lucas Gass
Modified: 2023-06-08 22:26 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 31783: Add page-section to columns_settings.tt page (2.67 KB, patch)
2022-10-13 23:17 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2022-10-13 23:12:19 UTC
We need the page-section div added to the columns_settings.tt page to ensure proper contrast for even/odd rows on the tables.
Comment 1 Lucas Gass 2022-10-13 23:17:25 UTC
Created attachment 141852 [details] [review]
Bug 31783: Add page-section to columns_settings.tt page

This patch adds the page-section class to the tables on the Table settings page.

To test:

1. Apply patch and go to Administration > Table settings
2. Make sure the tables look good with the new page-section class, which is added to an existing div in this case.
3. Make sure that changing some table setting still works and you can properly save new settings.

Note: This patch moves the fieldset which contains the Save button into the page-section div.
Comment 2 Owen Leonard 2022-10-14 11:35:29 UTC
I think I disagree on this one. The main difference between the current interface and the pre-redesign one is the table borders. The table row highlighting is even a little darker in the redesign.

In my opinion the interface is too busy with the added page-section class.