Attachment 142097 Details for Bug 29662 – Bug 29662: (bug 27526 follow-up) Prefill all subfields if SubfieldsToUseWhenPrefill is empty

[patch] Bug 29662: (bug 27526 follow-up) Prefill all subfields if SubfieldsToUseWhenPrefill is empty

Bug-29662-bug-27526-follow-up-Prefill-all-subfield.patch (text/plain), 1.90 KB, created by Katrin Fischer on 2022-10-18 20:31:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-10-18 20:31:52 UTC

Size: 1.90 KB

patch

obsolete

>From 881288d8560102c534ca823f3f87b225801e1fda Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 13 Dec 2021 11:50:33 +0100
>Subject: [PATCH] Bug 29662: (bug 27526 follow-up) Prefill all subfields if
> SubfieldsToUseWhenPrefill is empty
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Signed-off-by: Thibault KeromnÃ¨s <thibault.keromnes@univ-paris8.fr>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> Koha/UI/Form/Builder/Item.pm | 2 ++
> cataloguing/additem.pl       | 2 --
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/UI/Form/Builder/Item.pm b/Koha/UI/Form/Builder/Item.pm
>index 429f88cb58..568a00e401 100644
>--- a/Koha/UI/Form/Builder/Item.pm
>+++ b/Koha/UI/Form/Builder/Item.pm
>@@ -429,6 +429,8 @@ Flag to restrict the edition if the user does not have necessary permissions.
> 
> List of subfields to prefill (value of syspref SubfieldsToUseWhenPrefill)
> 
>+If empty all subfields will be prefilled. For none, you can pass an array with a single false value.
>+
> =item subfields_to_allow
> 
> List of subfields to allow (value of syspref SubfieldsToAllowForRestrictedBatchmod or SubfieldsToAllowForRestrictedEditing)
>diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl
>index bdd2061978..4617cb54db 100755
>--- a/cataloguing/additem.pl
>+++ b/cataloguing/additem.pl
>@@ -607,8 +607,6 @@ my $branchcode = $input->param('branch') || C4::Context->userenv->{branch};
> my @subfields_to_prefill;
> if ( $nextop eq 'additem' && $op ne 'dupeitem' && $prefillitem ) {
>     @subfields_to_prefill = split(' ', C4::Context->preference('SubfieldsToUseWhenPrefill'));
>-    # Setting to 1 element if SubfieldsToUseWhenPrefill is empty to prevent all the subfields to be prefilled
>-    @subfields_to_prefill = ("") unless @subfields_to_prefill;
> }
> 
> # Getting list of subfields to keep when restricted editing is enabled
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 29662: 128436 | 140344 | 142097 | 142098