To recreate: - turn on PrefillItem - confirm SubfieldsToUseWhenPrefill is empty - create an item, confirm no values are prefilled for next item - set at least one subfield in SubfieldsToUseWhenPrefill - create an item, confirm specified subfield(s) get prefilled for next item In previous versions, leaving SubfieldsToUseWhenPrefill blank meant all subfields were prefilled.
Do you know when the regression happened? On bug 27526 I have explicitly taken this use case into account so I guess I compared with current master (21.06).
Created attachment 128436 [details] [review] Bug 29662: (bug 27526 follow-up) Prefill all subfields if SubfieldsToUseWhenPrefill is empty
This patch removes the code that dealt with that specific case, but it would be good to know when this regression occurred.
Hello, Can someone please give a test plan for this patch? Cheers, Hayley
Hi Hayley, I think you can do the following: Before applying the patch: - turn on PrefillItem system preference - confirm SubfieldsToUseWhenPrefill system preference is empty - create an item, confirm no values are prefilled for next item - set at least one subfield in SubfieldsToUseWhenPrefill - create an item, confirm specified subfield(s) get prefilled for next item Apply patch: - create an item, confirm it behaves the same as before with your defined subfield getting prefilled - Empty SubfieldsToUseWhenPrefill system preferene - create an item, confirm that now all item subfields are prefilled
Andrew, does this patch fix the problem you reported?
Created attachment 140344 [details] [review] Bug 29662: (bug 27526 follow-up) Prefill all subfields if SubfieldsToUseWhenPrefill is empty Signed-off-by: Thibault Keromnès <thibault.keromnes@univ-paris8.fr>
Leaving a note for myself or another QA person: I could not see what broke the feature yet, but I can confirm that leaving it empty was meant to copy all the fields: From bug 7412 that implemented the feature: By default, all subfields are prefilled when the PrefillItem syspref is on, unless you specify which fields you want to prefill in the SubfieldsToUseWhenPrefill syspref. With a value of "f u v", only the $f, $u and $v will be prefilled, for example.
Created attachment 142097 [details] [review] Bug 29662: (bug 27526 follow-up) Prefill all subfields if SubfieldsToUseWhenPrefill is empty Signed-off-by: Thibault Keromnès <thibault.keromnes@univ-paris8.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 142098 [details] [review] Bug 29662: (QA folow-up) Add explanation for empty to system preference description This amends the system preference description for PrefillItem to explain what happens when the pref is left empty. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
*** Bug 29663 has been marked as a duplicate of this bug. ***
Pushed to master for 22.11. Nice work everyone, thanks!