Bugzilla – Attachment 142754 Details for
Bug 32022
Style tweaks to fieldsets and page-section
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32022: (follow-up) Ensure action background takes presidence
Bug-32022-follow-up-Ensure-action-background-takes.patch (text/plain), 1.45 KB, created by
Jonathan Druart
on 2022-10-28 08:24:02 UTC
(
hide
)
Description:
Bug 32022: (follow-up) Ensure action background takes presidence
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-10-28 08:24:02 UTC
Size:
1.45 KB
patch
obsolete
>From c2316ae9adc41dac37d33eeb8510ca86760d6a5a Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 28 Oct 2022 08:53:08 +0100 >Subject: [PATCH] Bug 32022: (follow-up) Ensure action background takes > presidence > >The action class sets the background to transparent, but because it's >often used in conjunction with the fieldset which includes the card >mixin the background rule was getting overridden to white. > >Test plan >1. Consider the same cases as the original patch >2. Confirm that the last test now shows the buttons outside of the card > but nicely spaced to clearly belong to it. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss >index b669a9ea1cd..aa2e8701017 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_mixins.scss >@@ -42,7 +42,7 @@ $nav-menu-bullet: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/s > @mixin card { > margin-bottom: 1rem; > padding: 1rem; >- &:not(.bg-danger):not(.bg-warning):not(.bg-info):not(.bg-success):not(.bg-primary) { >+ &:not(.bg-danger):not(.bg-warning):not(.bg-info):not(.bg-success):not(.bg-primary):not(.action) { > background-color: white; > } > } >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32022
:
142731
|
142750
|
142751
|
142753
| 142754 |
153615
|
153616