Bugzilla – Attachment 145406 Details for
Bug 15869
Change framework on overlay
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15869: (QA follow-up) Don't pass placeholder framework '_USE_ORIG'
Bug-15869-QA-follow-up-Dont-pass-placeholder-frame.patch (text/plain), 1.39 KB, created by
Nick Clemens
on 2023-01-18 19:58:16 UTC
(
hide
)
Description:
Bug 15869: (QA follow-up) Don't pass placeholder framework '_USE_ORIG'
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2023-01-18 19:58:16 UTC
Size:
1.39 KB
patch
obsolete
>From de105a2f928bf7a6d7e03e164efd0511dc2b5508 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 18 Jan 2023 19:53:54 +0000 >Subject: [PATCH] Bug 15869: (QA follow-up) Don't pass placeholder framework > '_USE_ORIG' > >This param in the dropdown is meant to signify no change, distinct from >"" when means to set to default. In rebasing this condition was lost, this patch >restores undef of the variable to avoid setting framework to an invalid value > >To test: >1 - Stage a record with a match (export and import a record) >2 - Attempt to import and overlay with option 'When replacing records use this framework:' 'Keep original framework' >3 - It fails, logs note 'value too long for field frameworkcode' >4 - Apply this patch >5 - Try again, it succeeds - framework is not changed >--- > tools/manage-marc-import.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/tools/manage-marc-import.pl b/tools/manage-marc-import.pl >index af94ab2a16..e48b479029 100755 >--- a/tools/manage-marc-import.pl >+++ b/tools/manage-marc-import.pl >@@ -90,6 +90,7 @@ if ($op eq "") { > } elsif ($op eq "commit-batch") { > my $frameworkcode = $input->param('framework'); > my $overlay_framework = $input->param('overlay_framework'); >+ $overlay_framework = undef if $overlay_framework = '_USE_ORIG'; > try { > my $job_id = Koha::BackgroundJob::MARCImportCommitBatch->new->enqueue( > { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15869
:
55543
|
70800
|
77018
|
140857
|
140858
|
142257
|
142258
|
143033
|
145271
|
145272
|
145273
|
145274
| 145406