Bugzilla – Attachment 153409 Details for
Bug 33952
Add Koha::Biblio->normalized_isbn
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33952: Add tests
Bug-33952-Add-tests.patch (text/plain), 1.39 KB, created by
Nick Clemens (kidclamp)
on 2023-07-13 16:06:56 UTC
(
hide
)
Description:
Bug 33952: Add tests
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-07-13 16:06:56 UTC
Size:
1.39 KB
patch
obsolete
>From f8f73c2c8bb1a7072fbbe7937dec72666a5edd34 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 8 Jun 2023 12:29:38 +0200 >Subject: [PATCH] Bug 33952: Add tests > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/db_dependent/Koha/Biblio.t | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t >index 38164b6494..61852492d4 100755 >--- a/t/db_dependent/Koha/Biblio.t >+++ b/t/db_dependent/Koha/Biblio.t >@@ -17,7 +17,7 @@ > > use Modern::Perl; > >-use Test::More tests => 24; >+use Test::More tests => 25; > use Test::Exception; > use Test::Warn; > >@@ -1126,6 +1126,18 @@ subtest 'item_groups() tests' => sub { > $schema->storage->txn_rollback; > }; > >+subtest 'normalized_isbn' => sub { >+ plan tests => 1; >+ >+ # We will move the tests from GetNormalizedISBN here when it will get replaced >+ my $biblio = $builder->build_sample_biblio(); >+ $biblio->biblioitem->set( { isbn => '9781250067128 | 125006712X' } )->store; >+ is( >+ $biblio->normalized_isbn, C4::Koha::GetNormalizedISBN( $biblio->biblioitem->isbn ), >+ 'normalized_isbn is a wrapper around C4::Koha::GetNormalizedISBN' >+ ); >+}; >+ > sub component_record1 { > my $marc = MARC::Record->new; > $marc->append_fields( >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33952
:
152146
|
152147
|
152718
|
152719
|
153005
| 153409 |
153410