Bug 33952 - Add Koha::Biblio->normalized_isbn
Summary: Add Koha::Biblio->normalized_isbn
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 33949 33953
  Show dependency treegraph
 
Reported: 2023-06-08 10:10 UTC by Jonathan Druart
Modified: 2023-07-18 11:27 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33952: Add tests (1.28 KB, patch)
2023-06-08 10:55 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33952: Koha::Biblio->normalized_isbn (1.30 KB, patch)
2023-06-08 10:55 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33952: Add tests (1.34 KB, patch)
2023-06-27 10:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33952: Koha::Biblio->normalized_isbn (1.37 KB, patch)
2023-06-27 10:25 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33952: Koha::Biblio->normalized_isbn (1.43 KB, patch)
2023-07-04 07:37 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33952: Add tests (1.39 KB, patch)
2023-07-13 16:06 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 33952: Koha::Biblio->normalized_isbn (1.49 KB, patch)
2023-07-13 16:06 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-06-08 10:10:43 UTC

    
Comment 1 Jonathan Druart 2023-06-08 10:55:13 UTC
Created attachment 152146 [details] [review]
Bug 33952: Add tests
Comment 2 Jonathan Druart 2023-06-08 10:55:16 UTC
Created attachment 152147 [details] [review]
Bug 33952: Koha::Biblio->normalized_isbn

to squash get_normalized_isbn
Comment 3 Martin Renvoize 2023-06-27 10:25:31 UTC
Created attachment 152718 [details] [review]
Bug 33952: Add tests

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2023-06-27 10:25:34 UTC
Created attachment 152719 [details] [review]
Bug 33952: Koha::Biblio->normalized_isbn

to squash get_normalized_isbn

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2023-06-27 10:26:36 UTC
At first thought, I'd love to have seen us not rely upon C4::Koha:: in here.. but when inspecting that code I decided we could drop that at a later date and let this move forward.

Signing off
Comment 6 Jonathan Druart 2023-07-04 07:36:34 UTC
Yes I should have added more context. This is needed for bug 33947 where we need to call ->normalized_isbn on a Koha::Biblio object.
Comment 7 Jonathan Druart 2023-07-04 07:37:50 UTC
Created attachment 153005 [details] [review]
Bug 33952: Koha::Biblio->normalized_isbn

This is needed for bug 33947 where we need to call ->normalized_isbn on a Koha::Biblio object.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Nick Clemens (kidclamp) 2023-07-13 16:06:56 UTC
Created attachment 153409 [details] [review]
Bug 33952: Add tests

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 9 Nick Clemens (kidclamp) 2023-07-13 16:06:58 UTC
Created attachment 153410 [details] [review]
Bug 33952: Koha::Biblio->normalized_isbn

This is needed for bug 33947 where we need to call ->normalized_isbn on a Koha::Biblio object.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 10 Tomás Cohen Arazi 2023-07-13 18:21:26 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 11 Martin Renvoize 2023-07-18 11:27:46 UTC
Not required for anything in 23.05.x series yet, we can backport later if it becomes required.