Created attachment 152146 [details] [review] Bug 33952: Add tests
Created attachment 152147 [details] [review] Bug 33952: Koha::Biblio->normalized_isbn to squash get_normalized_isbn
Created attachment 152718 [details] [review] Bug 33952: Add tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 152719 [details] [review] Bug 33952: Koha::Biblio->normalized_isbn to squash get_normalized_isbn Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
At first thought, I'd love to have seen us not rely upon C4::Koha:: in here.. but when inspecting that code I decided we could drop that at a later date and let this move forward. Signing off
Yes I should have added more context. This is needed for bug 33947 where we need to call ->normalized_isbn on a Koha::Biblio object.
Created attachment 153005 [details] [review] Bug 33952: Koha::Biblio->normalized_isbn This is needed for bug 33947 where we need to call ->normalized_isbn on a Koha::Biblio object. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 153409 [details] [review] Bug 33952: Add tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 153410 [details] [review] Bug 33952: Koha::Biblio->normalized_isbn This is needed for bug 33947 where we need to call ->normalized_isbn on a Koha::Biblio object. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.11. Nice work everyone, thanks!
Not required for anything in 23.05.x series yet, we can backport later if it becomes required.