Bugzilla – Attachment 155913 Details for
Bug 33499
Make interface URL clickable on vendor details
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33499: (QA follow-up) Open external links in new tab
Bug-33499-QA-follow-up-Open-external-links-in-new-.patch (text/plain), 2.13 KB, created by
Katrin Fischer
on 2023-09-19 20:38:33 UTC
(
hide
)
Description:
Bug 33499: (QA follow-up) Open external links in new tab
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-09-19 20:38:33 UTC
Size:
2.13 KB
patch
obsolete
>From b54b350d5d1b36e1e45dacf7e01135812801ffaf Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Tue, 19 Sep 2023 20:36:19 +0000 >Subject: [PATCH] Bug 33499: (QA follow-up) Open external links in new tab > >Adds target="_blank" to the vendor website and interface URLs, >as we can expect them to be external sites. > >Also changes mark-up a little so that the URL is shown without >an additional space in front, lining up with the other fields. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >index 2450eb2e9a..3042418cc6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >@@ -377,7 +377,7 @@ div.rows { padding: 1rem; } > <li><span class="label">Phone: </span>[% phone | html %]</li> > <li><span class="label">Fax: </span>[% fax | html %]</li> > [% IF ( url ) %] >- <li><span class="label">Website: </span><a href="[% url | url %]">[% url | html %]</a></li> >+ <li><span class="label">Website: </span><a href="[% url | url %]" target="_blank">[% url | html %]</a></li> > [% END %] > [% IF ( accountnumber ) %] > <li><span class="label">Account number: </span>[% accountnumber | html %]</li> >@@ -425,8 +425,7 @@ div.rows { padding: 1rem; } > [% END %] > [% IF i.uri %] > <li> >- <span class="label">URI: </span> >- <a href="[% i.uri | url %]">[% i.uri | html %]</a> >+ <span class="label">URI: </span><a href="[% i.uri | url %]" target="_blank">[% i.uri | html %]</a> > </li> > [% END %] > [% IF i.login %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33499
:
155889
|
155895
|
155912
| 155913