There are some inconsistencies on this page we could/should fix. * The labels of the ordering information and subscriptions section are bold, but all other labels are not. * The sections with repeating information (contacts and interfaces) could be improved for better readability. * The information takes up a lot of space. I wonder if we could reorder/regroup the information in a better way maybe?
Could we also add an hyperlink for the vendor interface URI? I was expecting to be able to click on it, but it's not a link, so I have to copy/paste it in my browser. https://snipboard.io/IsYrAF.jpg
I think some of this has been resolved since on another bug, I'll make it about the URL :)
Created attachment 155889 [details] [review] Bug 33499: Make interface URL clickable on vendor details This patch adds markup around the vendor details interface URL so that it is a clickable link. To test, apply the patch and go to Acquisitions. - Search for a vendor - If you don't have a vendor with interfaces defined, edit one - Under Interfaces -> Interface details, fill out the form, including the URI field. - Add more than one interface - Save your changes and then view the vendor details page - In the Interfaces section the interfaces you defined should have clickable links.
Created attachment 155895 [details] [review] Bug 33499: Make interface URL clickable on vendor details This patch adds markup around the vendor details interface URL so that it is a clickable link. To test, apply the patch and go to Acquisitions. - Search for a vendor - If you don't have a vendor with interfaces defined, edit one - Under Interfaces -> Interface details, fill out the form, including the URI field. - Add more than one interface - Save your changes and then view the vendor details page - In the Interfaces section the interfaces you defined should have clickable links. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 155912 [details] [review] Bug 33499: Make interface URL clickable on vendor details This patch adds markup around the vendor details interface URL so that it is a clickable link. To test, apply the patch and go to Acquisitions. - Search for a vendor - If you don't have a vendor with interfaces defined, edit one - Under Interfaces -> Interface details, fill out the form, including the URI field. - Add more than one interface - Save your changes and then view the vendor details page - In the Interfaces section the interfaces you defined should have clickable links. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 155913 [details] [review] Bug 33499: (QA follow-up) Open external links in new tab Adds target="_blank" to the vendor website and interface URLs, as we can expect them to be external sites. Also changes mark-up a little so that the URL is shown without an additional space in front, lining up with the other fields. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
acqui/supplier.tt changed with Bug 34197 not in 23.05.x So I chose to not backport