Bug 33499 - Make interface URL clickable on vendor details
Summary: Make interface URL clickable on vendor details
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 33104
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-11 21:10 UTC by Katrin Fischer
Modified: 2023-11-30 16:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33499: Make interface URL clickable on vendor details (1.85 KB, patch)
2023-09-19 11:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33499: Make interface URL clickable on vendor details (1.93 KB, patch)
2023-09-19 13:23 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 33499: Make interface URL clickable on vendor details (1.98 KB, patch)
2023-09-19 20:38 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33499: (QA follow-up) Open external links in new tab (2.13 KB, patch)
2023-09-19 20:38 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-04-11 21:10:23 UTC
There are some inconsistencies on this page we could/should fix.

* The labels of the ordering information and subscriptions section are bold, but all other labels are not.
* The sections with repeating information (contacts and interfaces) could be improved for better readability.
* The information takes up a lot of space. I wonder if we could reorder/regroup the information in a better way maybe?
Comment 1 Caroline Cyr La Rose 2023-09-18 19:38:42 UTC
Could we also add an hyperlink for the vendor interface URI? I was expecting to be able to click on it, but it's not a link, so I have to copy/paste it in my browser.
https://snipboard.io/IsYrAF.jpg
Comment 2 Katrin Fischer 2023-09-18 20:10:42 UTC
I think some of this has been resolved since on another bug, I'll make it about the URL :)
Comment 3 Owen Leonard 2023-09-19 11:04:58 UTC
Created attachment 155889 [details] [review]
Bug 33499: Make interface URL clickable on vendor details

This patch adds markup around the vendor details interface URL so that
it is a clickable link.

To test, apply the patch and go to Acquisitions.

- Search for a vendor
- If you don't have a vendor with interfaces defined, edit one
  - Under Interfaces -> Interface details, fill out the form, including
    the URI field.
  - Add more than one interface
- Save your changes and then view the vendor details page
- In the Interfaces section the interfaces you defined should have
  clickable links.
Comment 4 Caroline Cyr La Rose 2023-09-19 13:23:23 UTC
Created attachment 155895 [details] [review]
Bug 33499: Make interface URL clickable on vendor details

This patch adds markup around the vendor details interface URL so that
it is a clickable link.

To test, apply the patch and go to Acquisitions.

- Search for a vendor
- If you don't have a vendor with interfaces defined, edit one
  - Under Interfaces -> Interface details, fill out the form, including
    the URI field.
  - Add more than one interface
- Save your changes and then view the vendor details page
- In the Interfaces section the interfaces you defined should have
  clickable links.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 5 Katrin Fischer 2023-09-19 20:38:30 UTC
Created attachment 155912 [details] [review]
Bug 33499: Make interface URL clickable on vendor details

This patch adds markup around the vendor details interface URL so that
it is a clickable link.

To test, apply the patch and go to Acquisitions.

- Search for a vendor
- If you don't have a vendor with interfaces defined, edit one
  - Under Interfaces -> Interface details, fill out the form, including
    the URI field.
  - Add more than one interface
- Save your changes and then view the vendor details page
- In the Interfaces section the interfaces you defined should have
  clickable links.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2023-09-19 20:38:33 UTC
Created attachment 155913 [details] [review]
Bug 33499: (QA follow-up) Open external links in new tab

Adds target="_blank" to the vendor website and interface URLs,
as we can expect them to be external sites.

Also changes mark-up a little so that the URL is shown without
an additional space in front, lining up with the other fields.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2023-09-22 15:39:10 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-09-22 20:30:18 UTC
acqui/supplier.tt changed with Bug 34197 not in 23.05.x

So I chose to not backport