Attachment 156378 Details for Bug 34917 – Bug 34917: Fix default sort column of table in suggestion.tt

[patch] Bug 34917: Fix default sort column of table in suggestion.tt

Bug-34917-Fix-default-sort-column-of-table-in-sugg.patch (text/plain), 1.56 KB, created by Katrin Fischer on 2023-09-29 11:19:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-09-29 11:19:34 UTC

Size: 1.56 KB

patch

obsolete

>From 3806634b634fb7ad64e60a4a17c54c3e773bcade Mon Sep 17 00:00:00 2001
>From: Jacob O'Mara <jacobomara901@gmail.com>
>Date: Tue, 26 Sep 2023 15:19:45 +0100
>Subject: [PATCH] Bug 34917: Fix default sort column of table in suggestion.tt
>
>Test plan:
>1. Navigate to Acquisitions and load the suggestions management page
>2. Ensure that there are some suggestions in the table
>3. Observe that the default sort is on the "Suggester Category" column
>4. Apply Patch
>5. Observe that the default sort is now on the "Suggested on" column
>   instead
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
>---
> .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt      | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index 1ff0fb6c83..937fe63e20 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -1347,7 +1347,7 @@
>                 [% FOREACH suggestion IN suggestions %]
>                     [% IF suggestion.suggestions.size %]
>                         KohaTable("table_[% loop.count| html %]", {
>-                            "sorting": [[ 3, "asc" ]],
>+                            "sorting": [[ 4, "asc" ]],
>                             "autoWidth": false,
>                         }, table_settings );
>                     [% END %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34917: 156233 | 156245 | 156246 | 156378