Bugzilla – Attachment 157655 Details for
Bug 35132
Cookie consent modal is always visible in the ERM module
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35132: Add missing "scoped" attribute in ERM module
Bug-35132-Add-missing-scoped-attribute-in-ERM-modu.patch (text/plain), 1.51 KB, created by
Matt Blenkinsop
on 2023-10-23 15:00:27 UTC
(
hide
)
Description:
Bug 35132: Add missing "scoped" attribute in ERM module
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2023-10-23 15:00:27 UTC
Size:
1.51 KB
patch
obsolete
>From 88809fce7a5d1f0f0a128f7469278338ed11d4e6 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Mon, 23 Oct 2023 14:58:10 +0000 >Subject: [PATCH] Bug 35132: Add missing "scoped" attribute in ERM module > >The "scoped" attribute is missing from the CSS in EHoldingsEBSCOPackageAgreements and this conflicts with the modalclass used for cookie consent when in the ERM module > >Test plan: >1) Enable syspref "CookieConsent" >2) Delete any existing cookie for Cookie consent in your browser >3) Refresh the page >4) The cookie consent bar should be visible at the bottom of the screen >5) Navigate to the ERM module >6) The consent bar will still be visible but so will the modal - this should not be the case >7) Apply patch >8) yarn build >9) Refresh the page, the modal should now be hidden >--- > .../js/vue/components/ERM/EHoldingsEBSCOPackageAgreements.vue | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageAgreements.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageAgreements.vue >index dd1914af97..37d5c24389 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageAgreements.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageAgreements.vue >@@ -134,7 +134,7 @@ export default { > name: "EHoldingsEBSCOPackageAgreements", > } > </script> >-<style> >+<style scoped> > .modal { > position: fixed; > z-index: 9998; >-- >2.37.1 (Apple Git-137.1)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35132
: 157655