Bug 35132 - Cookie consent modal is always visible in the ERM module
Summary: Cookie consent modal is always visible in the ERM module
Status: RESOLVED DUPLICATE of bug 33491
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Matt Blenkinsop
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-23 14:57 UTC by Matt Blenkinsop
Modified: 2023-10-23 15:05 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 35132: Add missing "scoped" attribute in ERM module (1.51 KB, patch)
2023-10-23 15:00 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2023-10-23 14:57:12 UTC
To reproduce:
1) Enable syspref "CookieConsent"
2) Delete any existing cookie for Cookie consent in your browser
3) Refresh the page
4) The cookie consent bar should be visible at the bottom of the screen
5) Navigate to the ERM module
6) The consent bar will still be visible but so will the modal - this should not be the case
Comment 1 Matt Blenkinsop 2023-10-23 15:00:27 UTC
Created attachment 157655 [details] [review]
Bug 35132: Add missing "scoped" attribute in ERM module

The "scoped" attribute is missing from the CSS in EHoldingsEBSCOPackageAgreements and this conflicts with the modalclass used for cookie consent when in the ERM module

Test plan:
1) Enable syspref "CookieConsent"
2) Delete any existing cookie for Cookie consent in your browser
3) Refresh the page
4) The cookie consent bar should be visible at the bottom of the screen
5) Navigate to the ERM module
6) The consent bar will still be visible but so will the modal - this should not be the case
7) Apply patch
8) yarn build
9) Refresh the page, the modal should now be hidden
Comment 2 Matt Blenkinsop 2023-10-23 15:05:38 UTC
Resolved in bug 33491 - marking duplicate

*** This bug has been marked as a duplicate of bug 33491 ***