View | Details | Raw Unified | Return to bug 19097
Collapse All | Expand All

(-)a/C4/Biblio.pm (-2 / +1 lines)
Lines 2214-2221 sub TransformHtmlToMarc { Link Here
2214
    my $record = MARC::Record->new();
2214
    my $record = MARC::Record->new();
2215
    my @fields;
2215
    my @fields;
2216
    my ($biblionumbertagfield, $biblionumbertagsubfield) = (-1, -1);
2216
    my ($biblionumbertagfield, $biblionumbertagsubfield) = (-1, -1);
2217
    ($biblionumbertagfield, $biblionumbertagsubfield) =
2217
    ( $biblionumbertagfield, $biblionumbertagsubfield ) = &GetMarcFromKohaField("biblio.biblionumber") if $isbiblio;
2218
        &GetMarcFromKohaField( "biblio.biblionumber", '' ) if $isbiblio;
2219
#FIXME This code assumes that the CGI params will be in the same order as the fields in the template; this is no absolute guarantee!
2218
#FIXME This code assumes that the CGI params will be in the same order as the fields in the template; this is no absolute guarantee!
2220
    for (my $i = 0; $params[$i]; $i++ ) {    # browse all CGI params
2219
    for (my $i = 0; $params[$i]; $i++ ) {    # browse all CGI params
2221
        my $param    = $params[$i];
2220
        my $param    = $params[$i];
(-)a/C4/Items.pm (-3 / +1 lines)
Lines 778-786 sub Item2Marc { Link Here
778
    };
778
    };
779
    my $framework = C4::Biblio::GetFrameworkCode( $biblionumber );
779
    my $framework = C4::Biblio::GetFrameworkCode( $biblionumber );
780
    my $itemmarc = C4::Biblio::TransformKohaToMarc( $mungeditem, { framework => $framework } );
780
    my $itemmarc = C4::Biblio::TransformKohaToMarc( $mungeditem, { framework => $framework } );
781
    my ( $itemtag, $itemsubfield ) = C4::Biblio::GetMarcFromKohaField(
781
    my ( $itemtag, $itemsubfield ) = C4::Biblio::GetMarcFromKohaField('items.itemnumber');
782
        "items.itemnumber", $framework,
783
    );
784
782
785
    my $unlinked_item_subfields = _parse_unlinked_item_subfields_from_xml($mungeditem->{'items.more_subfields_xml'});
783
    my $unlinked_item_subfields = _parse_unlinked_item_subfields_from_xml($mungeditem->{'items.more_subfields_xml'});
786
    if (defined $unlinked_item_subfields and $#$unlinked_item_subfields > -1) {
784
    if (defined $unlinked_item_subfields and $#$unlinked_item_subfields > -1) {
(-)a/Koha/EDI.pm (-2 / +1 lines)
Lines 476-483 sub receipt_items { Link Here
476
            my $order = Koha::Acquisition::Orders->find($ordernumber);
476
            my $order = Koha::Acquisition::Orders->find($ordernumber);
477
            $biblionumber = $order->biblionumber;
477
            $biblionumber = $order->biblionumber;
478
            my $frameworkcode = GetFrameworkCode($biblionumber);
478
            my $frameworkcode = GetFrameworkCode($biblionumber);
479
            ($itemfield) = GetMarcFromKohaField( 'items.itemnumber',
479
            ($itemfield) = GetMarcFromKohaField('items.itemnumber');
480
                $frameworkcode );
481
        }
480
        }
482
    }
481
    }
483
482
(-)a/t/db_dependent/Suggestions.t (-7 / +6 lines)
Lines 378-388 my $record = MarcRecordFromNewSuggestion($suggestion2); Link Here
378
378
379
is("MARC::Record", ref($record), "MarcRecordFromNewSuggestion should return a MARC::Record object");
379
is("MARC::Record", ref($record), "MarcRecordFromNewSuggestion should return a MARC::Record object");
380
380
381
my ($title_tag, $title_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.title', '');
381
my ($title_tag, $title_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.title');
382
382
383
is($record->field( $title_tag )->subfield( $title_subfield ), "Cuisine d'automne", "Record from suggestion title should be 'Cuisine d'automne'");
383
is($record->field( $title_tag )->subfield( $title_subfield ), "Cuisine d'automne", "Record from suggestion title should be 'Cuisine d'automne'");
384
384
385
my ($author_tag, $author_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.author', '');
385
my ($author_tag, $author_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.author');
386
386
387
is($record->field( $author_tag )->subfield( $author_subfield ), "Catherine", "Record from suggestion author should be 'Catherine'");
387
is($record->field( $author_tag )->subfield( $author_subfield ), "Catherine", "Record from suggestion author should be 'Catherine'");
388
388
Lines 601-616 subtest 'Suggestion with ISBN' => sub { Link Here
601
    my $record = MarcRecordFromNewSuggestion( $suggestion_with_isbn );
601
    my $record = MarcRecordFromNewSuggestion( $suggestion_with_isbn );
602
    is("MARC::Record", ref($record), "MarcRecordFromNewSuggestion should return a MARC::Record object");
602
    is("MARC::Record", ref($record), "MarcRecordFromNewSuggestion should return a MARC::Record object");
603
603
604
    my ($isbn_tag, $isbn_subfield) = C4::Biblio::GetMarcFromKohaField('biblioitems.isbn', '');
604
    my ($isbn_tag, $isbn_subfield) = C4::Biblio::GetMarcFromKohaField('biblioitems.isbn');
605
    is($record->field( $isbn_tag )->subfield( $isbn_subfield ), "1940997232", "ISBN Record from suggestion ISBN should be '1940997232'");
605
    is($record->field( $isbn_tag )->subfield( $isbn_subfield ), "1940997232", "ISBN Record from suggestion ISBN should be '1940997232'");
606
606
607
    my ($issn_tag, $issn_subfield) = C4::Biblio::GetMarcFromKohaField('biblioitems.issn', '');
607
    my ($issn_tag, $issn_subfield) = C4::Biblio::GetMarcFromKohaField('biblioitems.issn');
608
    is($record->field( $issn_tag )->subfield( $issn_subfield ), "1940997232", "ISSN Record from suggestion ISBN should also be '1940997232'");
608
    is($record->field( $issn_tag )->subfield( $issn_subfield ), "1940997232", "ISSN Record from suggestion ISBN should also be '1940997232'");
609
609
610
    my ($title_tag, $title_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.title', '');
610
    my ($title_tag, $title_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.title');
611
    is($record->field( $title_tag), undef, "Record from suggestion title should be empty");
611
    is($record->field( $title_tag), undef, "Record from suggestion title should be empty");
612
612
613
    my ($author_tag, $author_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.author', '');
613
    my ($author_tag, $author_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.author');
614
    is($record->field( $author_tag), undef, "Record from suggestion author should be empty");
614
    is($record->field( $author_tag), undef, "Record from suggestion author should be empty");
615
};
615
};
616
616
617
- 

Return to bug 19097