Bug 19097 - Koha to MARC mappings (Part 3): Correct remaining GetMarcFromKohaField and TransformMarcToKoha calls
Summary: Koha to MARC mappings (Part 3): Correct remaining GetMarcFromKohaField and Tr...
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on: 19096 22721
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-14 07:45 UTC by Marcel de Rooy
Modified: 2022-06-07 13:32 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2017-08-14 07:45:05 UTC

    
Comment 1 Marcel de Rooy 2017-08-14 11:38:41 UTC
After bug 19096, we will need some cleanup. This patch set does only remove obsoleted parameters, so essentially it is a no-op.
Comment 2 Marcel de Rooy 2017-10-30 10:59:14 UTC
Moving this QA comment on bug 19096 about sub GetMarcFromKohaField here also:

return wantarray ? @retval : ( @retval ? $retval[0] : undef ); 
This is not necessary, do not do that please.
Caller can do
my ( $v ) = the_sub();
Not blocker.
Comment 3 Marcel de Rooy 2022-06-07 13:05:51 UTC
Looks like bug 30813 did most of the work now.
Comment 4 Marcel de Rooy 2022-06-07 13:32:48 UTC
(In reply to Marcel de Rooy from comment #3)
> Looks like bug 30813 did most of the work now.

But not all. Will make it more concrete.