Bugzilla – Attachment 159963 Details for
Bug 35426
Improve layout of bookings modal form
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35426: Improve layout of bookings modal form
Bug-35426-Improve-layout-of-bookings-modal-form.patch (text/plain), 3.00 KB, created by
Tomás Cohen Arazi (tcohen)
on 2023-12-18 12:56:22 UTC
(
hide
)
Description:
Bug 35426: Improve layout of bookings modal form
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2023-12-18 12:56:22 UTC
Size:
3.00 KB
patch
obsolete
>From 26b1341b89a24707ea57595af25f61910142616f Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 28 Nov 2023 18:46:11 +0000 >Subject: [PATCH] Bug 35426: Improve layout of bookings modal form > >This patch changes the class on the bookings modal form's fieldset in >order to make the form work better in the small space offered by the >modal. > >Also changed: The hint for the patron search field has been moved below >the field for consistency. > >To test, apply the patch and search for a title in the staff interface. > >- View the detail page. >- If you don't see a "Place booking" button in the toolbar, > click "Items" in the sidebar menu. > - Locate the "Priority" heading, and change the "Bookable" setting to > "Yes." >- Click the "PLace booking" button in the toolbar. > - The bookings modal form should appear, and the form layout should be > improved. > >Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../intranet-tmpl/prog/en/includes/modals/place_booking.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/place_booking.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/place_booking.inc >index bfc9010877a..1726e96ed63 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/place_booking.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/place_booking.inc >@@ -9,14 +9,13 @@ > </div> > <div class="modal-body"> > <div id="booking_result"></div> >- <fieldset class="rows"> >+ <fieldset class="brief"> > <input type="hidden" name="biblio_id" id="booking_id"> > <input type="hidden" name="biblio_id" id="booking_biblio_id"> > <input type="hidden" name="start_date" id="booking_start_date"> > <input type="hidden" name="end_date" id="booking_end_date"> > <ol> > <li> >- <div class="hint">Enter patron card number or partial name:</div> > <label class="required" for="booking_patron_id">Patron: </label> > <select name="booking_patron_id" id="booking_patron_id" required="required"> > <option></option> >@@ -24,6 +23,7 @@ > <option value="[% borrowernumber | uri %]" selected="selected">[% patron.firstname | html %] [% patron.surname | html %] ([% patron.cardnumber | html %] )</option> > [% END %] > </select> >+ <div class="hint">Enter patron card number or partial name</div> > </li> > <label for="booking_item_id">Item: </label> > <select name="booking_item_id" id="booking_item_id" disabled="true"> >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35426
:
159312
|
159454
| 159963 |
162974