Bug 35426 - Improve layout of bookings modal form
Summary: Improve layout of bookings modal form
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 29002
Blocks: 35532
  Show dependency treegraph
 
Reported: 2023-11-28 18:45 UTC by Owen Leonard
Modified: 2024-02-19 10:08 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35426: Improve layout of bookings modal form (2.88 KB, patch)
2023-11-28 19:03 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35426: Improve layout of bookings modal form (2.95 KB, patch)
2023-12-01 15:31 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 35426: Improve layout of bookings modal form (3.00 KB, patch)
2023-12-18 12:56 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-11-28 18:45:38 UTC
The bookings modal form, triggered on the staff interface page when you click the "Place bookings" button, has an awkward layout because the fieldset with "rows" class doesn't work well there. Changing the class to "brief" makes it work better.
Comment 1 Owen Leonard 2023-11-28 19:03:37 UTC
Created attachment 159312 [details] [review]
Bug 35426: Improve layout of bookings modal form

This patch changes the class on the bookings modal form's fieldset in
order to make the form work better in the small space offered by the
modal.

Also changed: The hint for the patron search field has been moved below
the field for consistency.

To test, apply the patch and search for a title in the staff interface.

- View the detail page.
- If you don't see a "Place booking" button in the toolbar,
  click "Items" in the sidebar menu.
  - Locate the "Priority" heading, and change the "Bookable" setting to
    "Yes."
- Click the "PLace booking" button in the toolbar.
  - The bookings modal form should appear, and the form layout should be
    improved.
Comment 2 ByWater Sandboxes 2023-12-01 15:31:25 UTC
Created attachment 159454 [details] [review]
Bug 35426: Improve layout of bookings modal form

This patch changes the class on the bookings modal form's fieldset in
order to make the form work better in the small space offered by the
modal.

Also changed: The hint for the patron search field has been moved below
the field for consistency.

To test, apply the patch and search for a title in the staff interface.

- View the detail page.
- If you don't see a "Place booking" button in the toolbar,
  click "Items" in the sidebar menu.
  - Locate the "Priority" heading, and change the "Bookable" setting to
    "Yes."
- Click the "PLace booking" button in the toolbar.
  - The bookings modal form should appear, and the form layout should be
    improved.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 Tomás Cohen Arazi 2023-12-18 12:56:22 UTC
Created attachment 159963 [details] [review]
Bug 35426: Improve layout of bookings modal form

This patch changes the class on the bookings modal form's fieldset in
order to make the form work better in the small space offered by the
modal.

Also changed: The hint for the patron search field has been moved below
the field for consistency.

To test, apply the patch and search for a title in the staff interface.

- View the detail page.
- If you don't see a "Place booking" button in the toolbar,
  click "Items" in the sidebar menu.
  - Locate the "Priority" heading, and change the "Bookable" setting to
    "Yes."
- Click the "PLace booking" button in the toolbar.
  - The bookings modal form should appear, and the form layout should be
    improved.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>