Bugzilla – Attachment 162488 Details for
Bug 36170
Wrong warning in memberentry
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36170: Wrong error variable in memberentry
Bug-36170-Wrong-error-variable-in-memberentry.patch (text/plain), 1.18 KB, created by
Jonathan Druart
on 2024-02-27 08:53:10 UTC
(
hide
)
Description:
Bug 36170: Wrong error variable in memberentry
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-02-27 08:53:10 UTC
Size:
1.18 KB
patch
obsolete
>From 7ab19d4bcd1e281fbf7031dd1fb2aecdfc3ec0c3 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 21 Feb 2024 13:46:29 +0100 >Subject: [PATCH] Bug 36170: Wrong error variable in memberentry > >It is hidding an important error. > >$@ is never set here, we need $_ (inside a try-catch) >--- > members/memberentry.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index 57e780cfecd..e2423122115 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -437,7 +437,7 @@ if ((!$nok) and $nodouble and ($op eq 'insert' or $op eq 'save')){ > } else { > # FIXME Urgent error handling here, we cannot fail without relevant feedback > # Lot of code will need to be removed from this script to handle exceptions raised by Koha::Patron->store >- warn "Patron creation failed! - $@"; # Maybe we must die instead of just warn >+ warn "Patron creation failed! - $_"; # Maybe we must die instead of just warn > push @messages, {error => 'error_on_insert_patron'}; > } > $op = "add"; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36170
: 162488