Bug 36170 - Wrong warning in memberentry
Summary: Wrong warning in memberentry
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 32426
Blocks:
  Show dependency treegraph
 
Reported: 2024-02-27 08:51 UTC by Jonathan Druart
Modified: 2024-03-19 19:48 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04


Attachments
Bug 36170: Wrong error variable in memberentry (1.18 KB, patch)
2024-02-27 08:53 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-02-27 08:51:25 UTC
-                warn "Patron creation failed! - $@"; # Maybe we must die instead of just warn

$@ is never set here, we need $_ (inside a try-catch)
Comment 1 Jonathan Druart 2024-02-27 08:53:10 UTC
Created attachment 162488 [details] [review]
Bug 36170: Wrong error variable in memberentry

It is hidding an important error.

$@ is never set here, we need $_ (inside a try-catch)
Comment 2 Katrin Fischer 2024-03-07 15:38:09 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 3 Fridolin Somers 2024-03-11 10:12:56 UTC
Pushed to 23.11.x for 23.11.04
Comment 4 Lucas Gass 2024-03-19 19:48:30 UTC
Backported to 23.05.x for upcoming 23.05.10