Bugzilla – Attachment 162670 Details for
Bug 35329
Move patron searches to a modal
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35329: (follow-up) Add styling to info and error
Bug-35329-follow-up-Add-styling-to-info-and-error.patch (text/plain), 4.99 KB, created by
Jonathan Druart
on 2024-03-01 15:03:56 UTC
(
hide
)
Description:
Bug 35329: (follow-up) Add styling to info and error
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-03-01 15:03:56 UTC
Size:
4.99 KB
patch
obsolete
>From fc3e538aa01b253641871f26b871844257f860aa Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 1 Mar 2024 15:32:40 +0100 >Subject: [PATCH] Bug 35329: (follow-up) Add styling to info and error > >--- > t/db_dependent/selenium/patrons_search.t | 22 ++++++++++++++-------- > 1 file changed, 14 insertions(+), 8 deletions(-) > >diff --git a/t/db_dependent/selenium/patrons_search.t b/t/db_dependent/selenium/patrons_search.t >index 30f4a959d2e..f757ea7fb00 100755 >--- a/t/db_dependent/selenium/patrons_search.t >+++ b/t/db_dependent/selenium/patrons_search.t >@@ -87,6 +87,8 @@ sub setup { > value => { > surname => "test_patron_" . $i++, > firstname => $firstname, >+ middle_name => q{}, # We don't want to copy the logic from patron_to_html >+ othernames => q{}, > categorycode => $patron_category->categorycode, > branchcode => $library->branchcode, > borrowernotes => $borrowernotes, >@@ -103,6 +105,8 @@ sub setup { > value => { > surname => "test", > firstname => "not_p_a_t_r_o_n", # won't match 'patron' >+ middle_name => q{}, # We don't want to copy the logic from patron_to_html >+ othernames => q{}, > categorycode => $patron_category->categorycode, > branchcode => $library->branchcode, > borrowernotes => $borrowernotes, >@@ -126,6 +130,8 @@ sub setup { > value => { > surname => "test_patron_27", > firstname => $firstname, >+ middle_name => q{}, # We don't want to copy the logic from patron_to_html >+ othernames => q{}, > categorycode => $patron_category->categorycode, > branchcode => $library_2->branchcode, > borrowernotes => $borrowernotes, >@@ -252,8 +258,8 @@ subtest 'Search patrons' => sub { > is( > $driver->get_title, > sprintf( >- "Modify patron %s %s %s (%s) %s (%s) (%s) ⺠Patrons ⺠Koha", >- $first_patron->title, $first_patron->firstname, $first_patron->middle_name, $first_patron->othernames, $first_patron->surname, $first_patron->cardnumber, >+ "Modify patron %s %s %s (%s) (%s) ⺠Patrons ⺠Koha", >+ $first_patron->title, $first_patron->firstname, $first_patron->surname, $first_patron->cardnumber, > $first_patron->category->description, > ), > 'Page title is correct after following modification link' >@@ -493,7 +499,7 @@ subtest 'Search patrons in modal' => sub { > is( > $driver->find_element('//div[@id="patron_preview_modal"]//h1')->get_text(), > sprintf( >- "%s %s %s (%s) %s (%s)", $patron->title, $patron->firstname, $patron->middle_name, $patron->othernames, >+ "%s %s %s (%s)", $patron->title, $patron->firstname, > $patron->surname, $patron->cardnumber > ) > ); >@@ -577,8 +583,8 @@ subtest 'Search patrons in modal' => sub { > is( > $driver->find_element('//div[@id="patron_preview_modal"]//h1')->get_text(), > sprintf( >- "%s %s %s (%s) %s (%s)", $patron->title, $patron->firstname, $patron->middle_name, $patron->othernames, >- $patron->surname, $patron->cardnumber >+ "%s %s %s (%s)", $patron->title, $patron->firstname, >+ $patron->surname, $patron->cardnumber > ) > ); > >@@ -639,7 +645,7 @@ subtest 'Search patrons in modal' => sub { > is( > $driver->find_element('//div[@id="patron_preview_modal"]//h1')->get_text(), > sprintf( >- "%s %s %s (%s) %s (%s)", $patron->title, $patron->firstname, $patron->middle_name, $patron->othernames, >+ "%s %s %s (%s)", $patron->title, $patron->firstname, > $patron->surname, $patron->cardnumber > ) > ); >@@ -662,7 +668,7 @@ subtest 'Search patrons in modal' => sub { > > # Info has been added about the patron > is( >- $driver->find_element('//div[@id="patron_search_modal_users"]//div[@class="info"]')->get_text, >+ $driver->find_element('//div[@id="patron_search_modal_users"]//div[@class="info dialog message"]')->get_text, > sprintf( "Patron '%s %s' added.", $patron->firstname, $patron->surname ) > ); > >@@ -674,7 +680,7 @@ subtest 'Search patrons in modal' => sub { > > # Warning has been added about the patron > is( >- $driver->find_element('//div[@id="patron_search_modal_users"]//div[@class="error"]')->get_text, >+ $driver->find_element('//div[@id="patron_search_modal_users"]//div[@class="error dialog alert"]')->get_text, > sprintf( "Patron '%s %s' is already in the list.", $patron->firstname, $patron->surname ) > ); > >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35329
:
160698
|
160699
|
160700
|
160701
|
160702
|
160703
|
160704
|
160705
|
160706
|
160728
|
160729
|
160733
|
160734
|
160735
|
160736
|
160737
|
160738
|
160739
|
160740
|
160741
|
160742
|
160743
|
160759
|
160760
|
160761
|
160762
|
160763
|
160768
|
160769
|
160770
|
160771
|
160773
|
160774
|
160940
|
160941
|
160943
|
160944
|
160945
|
160946
|
160947
|
160948
|
160949
|
160950
|
160951
|
160952
|
160953
|
160954
|
160955
|
160956
|
160957
|
160958
|
160959
|
161165
|
161166
|
161183
|
161184
|
161185
|
161186
|
161187
|
161188
|
161189
|
161190
|
161191
|
161192
|
161193
|
161194
|
161195
|
161196
|
161197
|
161198
|
161199
|
161259
|
161260
|
161274
|
161275
|
161276
|
161277
|
161278
|
161279
|
161280
|
161281
|
161282
|
161283
|
161284
|
161285
|
161286
|
161287
|
161288
|
161289
|
161290
|
161291
|
161292
|
161293
|
161294
|
161295
|
161398
|
161399
|
161400
|
161401
|
161402
|
161403
|
161404
|
161405
|
161406
|
161407
|
161408
|
161409
|
161410
|
161411
|
161412
|
161413
|
161414
|
161415
|
161416
|
161417
|
162436
|
162437
|
162438
|
162439
|
162440
|
162441
|
162442
|
162443
|
162444
|
162445
|
162446
|
162447
|
162448
|
162449
|
162450
|
162451
|
162452
|
162453
|
162454
|
162455
|
162456
|
162457
| 162670 |
162671
|
162713
|
162714