The patron searches are made in a popup window, we should move it to a modal: 1. More friendly for end users 2. Will be able to test correctly from cypress 3. Easier to maintain (code will be less ugly).
There are 2 remotes branches on my gitlab repo: * move_to_modal * move_to_modal-simple See message from last commit of move_to_modal to know the known problems. Then try the other branch. There are some downside as well but might be considered good enough?
Created attachment 160698 [details] [review] Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal.
Created attachment 160699 [details] [review] Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted.
Created attachment 160700 [details] [review] Bug 35329: Move patron search to modal - basket Add user to an acquisition basket
Created attachment 160701 [details] [review] Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals.
Created attachment 160702 [details] [review] Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons".
Created attachment 160703 [details] [review] Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users.
Created attachment 160704 [details] [review] Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license
Created attachment 160705 [details] [review] Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses).
Created attachment 160706 [details] [review] Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results
(In reply to Jonathan Druart from comment #2) > Created attachment 160698 [details] [review] [review] > Bug 35329: move patron search to modal - Add guarantor This patch is co-authored-by: Owen, thanks! :)
Here's what I've found so far: - The search from neworderempty.pl doesn't work at all. The form shows up but doesn't work to return results. - On some pages there is feedback when you click an "Add" button from the search results. If you select a patron who has a space in borrowers.firstname, e.g. "John Quincy" the message looks like this: "Patron 'John%20Quincy Adams' added." - Intermittently I get this error: Uncaught TypeError: can't access property "description", categories_map[data.toLowerCase()] is undefined ...but I haven't been able to pin down how to reproduce it.
Created attachment 160728 [details] [review] Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12).
(In reply to Owen Leonard from comment #12) > Here's what I've found so far: > > - The search from neworderempty.pl doesn't work at all. The form shows up > but doesn't work to return results. Should be fixed on "Bug 35329: Fix neworderempty" > - On some pages there is feedback when you click an "Add" button from the > search results. If you select a patron who has a space in > borrowers.firstname, e.g. "John Quincy" the message looks like this: > > "Patron 'John%20Quincy Adams' added." Reported on a separate bug (it affects master): bug 35756 > - Intermittently I get this error: > > Uncaught TypeError: can't access property "description", > categories_map[data.toLowerCase()] is undefined > > ...but I haven't been able to pin down how to reproduce it. This can happen if one of patron's category is not defined in the patron categories admin area (not possible, we have a FK, but maybe it's NULL?). Or if you have created a patron category in a separate window and run the search from the modal without having refreshed it. Just guesses here...
Created attachment 160729 [details] [review] Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page
Remaining work: 1. Add/fix some styling 2. Fix Select2 styling (width is too short) 3. Add E2E tests
Created attachment 160733 [details] [review] Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal.
Created attachment 160734 [details] [review] Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted.
Created attachment 160735 [details] [review] Bug 35329: Move patron search to modal - basket Add user to an acquisition basket
Created attachment 160736 [details] [review] Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals.
Created attachment 160737 [details] [review] Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons".
Created attachment 160738 [details] [review] Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users.
Created attachment 160739 [details] [review] Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license
Created attachment 160740 [details] [review] Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses).
Created attachment 160741 [details] [review] Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results
Created attachment 160742 [details] [review] Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12).
Created attachment 160743 [details] [review] Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page
Created attachment 160759 [details] [review] Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns.
Created attachment 160760 [details] [review] Bug 35329: Prevent XSS
Created attachment 160761 [details] [review] Bug 35329: Prevent XSS
Created attachment 160762 [details] [review] Bug 35329: (follow-up) Label changes for improved accessibility This patch alters the patron search form so that <label>s wrap the <input> fields, allowing the label to be clickable without having to associate it with a unique id. CSS has been modified to accommodate this change. The patch also adds missing Bootstrap classes to the "Clear" button, and swaps out the "hint" class for the "note" class on the permissions information ("Only staff with superlibrarian or acquisitions permissions..."). After this patch, form field labels in the patron search modal should be clickable to give focus to the field (except for Sort 1 and Sort 2 -- label don't work that way with Select2).
Created attachment 160763 [details] [review] Bug 35329: Add selenium tests
Created attachment 160768 [details] [review] Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns.
Created attachment 160769 [details] [review] Bug 35329: Prevent XSS
Created attachment 160770 [details] [review] Bug 35329: (follow-up) Label changes for improved accessibility This patch alters the patron search form so that <label>s wrap the <input> fields, allowing the label to be clickable without having to associate it with a unique id. CSS has been modified to accommodate this change. The patch also adds missing Bootstrap classes to the "Clear" button, and swaps out the "hint" class for the "note" class on the permissions information ("Only staff with superlibrarian or acquisitions permissions..."). After this patch, form field labels in the patron search modal should be clickable to give focus to the field (except for Sort 1 and Sort 2 -- label don't work that way with Select2).
Created attachment 160771 [details] [review] Bug 35329: Add selenium tests
Created attachment 160773 [details] [review] Bug 35329: Add selenium tests
Created attachment 160774 [details] [review] Bug 35329: Add cypress tests
Created attachment 160940 [details] [review] Bug 35329: Add POD + tidy Selenium.pm
Created attachment 160941 [details] [review] Bug 35329: Add POD + tidy Selenium.pm
Created attachment 160943 [details] [review] Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160944 [details] [review] Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160945 [details] [review] Bug 35329: Move patron search to modal - basket Add user to an acquisition basket Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160946 [details] [review] Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160947 [details] [review] Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160948 [details] [review] Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160949 [details] [review] Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160950 [details] [review] Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160951 [details] [review] Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160952 [details] [review] Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160953 [details] [review] Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160954 [details] [review] Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160955 [details] [review] Bug 35329: Prevent XSS Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160956 [details] [review] Bug 35329: (follow-up) Label changes for improved accessibility This patch alters the patron search form so that <label>s wrap the <input> fields, allowing the label to be clickable without having to associate it with a unique id. CSS has been modified to accommodate this change. The patch also adds missing Bootstrap classes to the "Clear" button, and swaps out the "hint" class for the "note" class on the permissions information ("Only staff with superlibrarian or acquisitions permissions..."). After this patch, form field labels in the patron search modal should be clickable to give focus to the field (except for Sort 1 and Sort 2 -- label don't work that way with Select2). Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160957 [details] [review] Bug 35329: Add selenium tests Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160958 [details] [review] Bug 35329: Add cypress tests Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 160959 [details] [review] Bug 35329: Add POD + tidy Selenium.pm Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Minor comment, I think the result of an action could be made more apparent.. it's rather hidden away.. also, if re-opening the modal, the result of the last operation is still visible. I tested with New Order Empty to deduct the above.
Next comment.. could we perhaps put the results next to rather than under the filters form in the modal? It feels odd to have so much whitespace in the modal and have the actual useful content almost hidden off screen.. widescreen aspect ratios are pretty common these days?
Created attachment 161165 [details] Widescreen display
Created attachment 161166 [details] Almost invisible feedback
So.. those two could be new bug follow-ups as they're enhancements on top of this.
We should have a message similar to that on the funds ownership search in the basket manager search.. we limit that search to users with particular permissions too.
For consistency, I feel like whenever a search can be used to add to a list of patrons, we should expose the select boxes and add selected functionlity. I don't think this should be specifically limited to patron card creator batches.
Created attachment 161183 [details] [review] Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161184 [details] [review] Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161185 [details] [review] Bug 35329: Move patron search to modal - basket Add user to an acquisition basket Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161186 [details] [review] Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161187 [details] [review] Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161188 [details] [review] Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161189 [details] [review] Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161190 [details] [review] Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161191 [details] [review] Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161192 [details] [review] Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161193 [details] [review] Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161194 [details] [review] Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161195 [details] [review] Bug 35329: Prevent XSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161196 [details] [review] Bug 35329: (follow-up) Label changes for improved accessibility This patch alters the patron search form so that <label>s wrap the <input> fields, allowing the label to be clickable without having to associate it with a unique id. CSS has been modified to accommodate this change. The patch also adds missing Bootstrap classes to the "Clear" button, and swaps out the "hint" class for the "note" class on the permissions information ("Only staff with superlibrarian or acquisitions permissions..."). After this patch, form field labels in the patron search modal should be clickable to give focus to the field (except for Sort 1 and Sort 2 -- label don't work that way with Select2). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161197 [details] [review] Bug 35329: Add selenium tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161198 [details] [review] Bug 35329: Add cypress tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161199 [details] [review] Bug 35329: Add POD + tidy Selenium.pm Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Right.. I've decided this has enough work on it already.. the functionality all works well for me and I'm unable to break anything. The consistency improvements are just that, improvements/enhancements on top of this so I'm going to report them as new bugs depending on this one and let this one pass as is. Passing QA
(In reply to Martin Renvoize from comment #63) > We should have a message similar to that on the funds ownership search in > the basket manager search.. we limit that search to users with particular > permissions too. OK, I changed my mind on the PQA.. as far as I can tell this is actually a regression. We're calling patron_search_js as apposed to patron_search_table as our include in this case and thus the 'note' divs that display information about the search limits do not appear in this case.. it appears like they should be. There's also a mismatch in the filter names.. 'baskets_managers' vs 'orders_managers'.. I think this does need fixing before we go PQA... I had a quick look and couldn't work out the logic flow here I'm afraid :(
Created attachment 161259 [details] [review] Bug 35329: Fix filter vars scope
Created attachment 161260 [details] [review] Bug 35329: Add styling to info and error There were 2 "class" attribute and the second was ignored. This could still be improved, but then we should adjust the css from staff-global, but won't be trivial to test.
(In reply to Martin Renvoize from comment #58) > Minor comment, I think the result of an action could be made more apparent.. > it's rather hidden away.. Added some styling on "Add styling to info and error", but could still be improved I think. > also, if re-opening the modal, the result of the > last operation is still visible. Yes, I didn't know if it would be considered a bug or not, and it was not trivial to implement. Opened bug 35864 for discussion. (In reply to Martin Renvoize from comment #59) > Next comment.. could we perhaps put the results next to rather than under > the filters form in the modal? > > It feels odd to have so much whitespace in the modal and have the actual > useful content almost hidden off screen.. widescreen aspect ratios are > pretty common these days? Good idea, but definitely for a separate bug. Opened bug 35862. (In reply to Martin Renvoize from comment #63) > We should have a message similar to that on the funds ownership search in > the basket manager search.. we limit that search to users with particular > permissions too. Yes, this is a bug, fixed in "Fix filter vars scope". (In reply to Martin Renvoize from comment #64) > For consistency, I feel like whenever a search can be used to add to a list > of patrons, we should expose the select boxes and add selected functionlity. > I don't think this should be specifically limited to patron card creator > batches. No behavior changes here, but yes that could be nice. Opened bug 35861. (In reply to Martin Renvoize from comment #83) > There's also a mismatch in the filter names.. 'baskets_managers' vs > 'orders_managers'.. I think this does need fixing before we go PQA... I had > a quick look and couldn't work out the logic flow here I'm afraid :( I don't think so. However orders_managers is never used (neither on master) and we should investigate that.
> (In reply to Martin Renvoize from comment #83) > > There's also a mismatch in the filter names.. 'baskets_managers' vs > > 'orders_managers'.. I think this does need fixing before we go PQA... I had > > a quick look and couldn't work out the logic flow here I'm afraid :( > > I don't think so. However orders_managers is never used (neither on master) > and we should investigate that. Ok, opened bug 35865.
Oops, just noticed you have opened bugs already! Marked bug 35846 and bug 35861 as duplicate!
Created attachment 161274 [details] [review] Bug 35329: Fix filter vars scope Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161275 [details] [review] Bug 35329: Add styling to info and error There were 2 "class" attribute and the second was ignored. This could still be improved, but then we should adjust the css from staff-global, but won't be trivial to test. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
OK.. with the follow-ups we've resolved all my concerns.. anything else falls into the enhancement on top category and there are bugs opened and linked for that. Passing QA
Created attachment 161276 [details] [review] Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161277 [details] [review] Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161278 [details] [review] Bug 35329: Move patron search to modal - basket Add user to an acquisition basket Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161279 [details] [review] Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161280 [details] [review] Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161281 [details] [review] Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161282 [details] [review] Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161283 [details] [review] Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161284 [details] [review] Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161285 [details] [review] Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161286 [details] [review] Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161287 [details] [review] Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161288 [details] [review] Bug 35329: Prevent XSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161289 [details] [review] Bug 35329: (follow-up) Label changes for improved accessibility This patch alters the patron search form so that <label>s wrap the <input> fields, allowing the label to be clickable without having to associate it with a unique id. CSS has been modified to accommodate this change. The patch also adds missing Bootstrap classes to the "Clear" button, and swaps out the "hint" class for the "note" class on the permissions information ("Only staff with superlibrarian or acquisitions permissions..."). After this patch, form field labels in the patron search modal should be clickable to give focus to the field (except for Sort 1 and Sort 2 -- label don't work that way with Select2). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161290 [details] [review] Bug 35329: Add selenium tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161291 [details] [review] Bug 35329: Add cypress tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161292 [details] [review] Bug 35329: Add POD + tidy Selenium.pm Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161293 [details] [review] Bug 35329: Fix filter vars scope Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161294 [details] [review] Bug 35329: Add styling to info and error There were 2 "class" attribute and the second was ignored. This could still be improved, but then we should adjust the css from staff-global, but won't be trivial to test. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161295 [details] [review] Bug 35329: (QA follow-up) Fix for bug 35865 This restores the missing hint that's restored by bug 35865 ahead of this patchset
Small rebase so I could move bug 35865 (a bugfix) above this in the dependencies and then make sure we don't lose the fix from there when applying this one to master.
Created attachment 161398 [details] [review] Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161399 [details] [review] Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161400 [details] [review] Bug 35329: Move patron search to modal - basket Add user to an acquisition basket Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161401 [details] [review] Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161402 [details] [review] Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161403 [details] [review] Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161404 [details] [review] Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161405 [details] [review] Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161406 [details] [review] Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161407 [details] [review] Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161408 [details] [review] Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161409 [details] [review] Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161410 [details] [review] Bug 35329: Prevent XSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161411 [details] [review] Bug 35329: (follow-up) Label changes for improved accessibility This patch alters the patron search form so that <label>s wrap the <input> fields, allowing the label to be clickable without having to associate it with a unique id. CSS has been modified to accommodate this change. The patch also adds missing Bootstrap classes to the "Clear" button, and swaps out the "hint" class for the "note" class on the permissions information ("Only staff with superlibrarian or acquisitions permissions..."). After this patch, form field labels in the patron search modal should be clickable to give focus to the field (except for Sort 1 and Sort 2 -- label don't work that way with Select2). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161412 [details] [review] Bug 35329: Add selenium tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161413 [details] [review] Bug 35329: Add cypress tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161414 [details] [review] Bug 35329: Add POD + tidy Selenium.pm Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161415 [details] [review] Bug 35329: Fix filter vars scope Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161416 [details] [review] Bug 35329: Add styling to info and error There were 2 "class" attribute and the second was ignored. This could still be improved, but then we should adjust the css from staff-global, but won't be trivial to test. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161417 [details] [review] Bug 35329: (QA follow-up) Fix for bug 35865 This restores the missing hint that's restored by bug 35865 ahead of this patchset
Minor rebase on top of bug 33457
Created attachment 162436 [details] [review] Bug 35329: move patron search to modal - Add guarantor This is the first of many patches to come. We will rewrite the patron search popup to convert it to a Bootstrap's modal. I faced different problems on different pages, it is preferable to test each page on top of the whole patchset, to make sure a futur change will not break previous pages (and this is why they are all on the same bug report). For each page we will test that: * the different filters work * the "Clear" filters button work * the "Add" or "Select" patron button works * the nested modal to display patron's details (when clicking on their name or cardnumber) works On this patch we are testing the guarantor search: Create a edit a patron and click "Add guarantor" to open the modal. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162437 [details] [review] Bug 35329: Move patron search to modal - neworderempty Test plan: Create a new acquisition order and add users. FIXME: Note that rules for .modal-dialog .dialog.message need to be adjusted. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162438 [details] [review] Bug 35329: Move patron search to modal - basket Add user to an acquisition basket Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162439 [details] [review] Bug 35329: Move patron search to modal - funds This is a tricky one. We can have several modals per page, patron-search.inc needs to be adjusted to not use ids but classes. Also we need to declare JS variables with 'var' instead of 'let' (which does not allow redefinition of the same variable). Test plan: Create or modify a fund "Select owner" and "Add users" to open the modals. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162440 [details] [review] Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162441 [details] [review] Bug 35329: Move patron search to modal - routing list The behaviour is a bit different here. Adding a patron from the popup refreshed the parent page with the newly added patron. With this patch the refresh of the page will happen when the modal is closed (if patrons have been added). Test plan: Create a subscription, receive one item, create a routing list. Add users. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162442 [details] [review] Bug 35329: Move patron search to modal - erm Test plan: Edit an agreement or a license Add new user and click "Select user" to open the modal Test with different user for the same agreement/license Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162443 [details] [review] Bug 35329: Move patron search to modal - suggestion Test plan: Edit a suggestion Click "Set patron" to change the suggester Click "Select manager" to set the manager On the suggestion list view, you can also select a manager. Make sure you are testing with different tabs (suggestions with different statuses). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162444 [details] [review] Bug 35329: Move patron search to modal - remove members/search.pl git grep members/search.pl should not return any results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162445 [details] [review] Bug 35329: Fix neworderempty Hum I had to put it that way but I cannot remember why. Moving patron_search_js after patron_search_modal fixes the search problem (see comment 12). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162446 [details] [review] Bug 35329: Remove fixedHeader If fixedHeader is set for the result table in the modal, the header will still appear (quite randomly) on the main view. To recreate the problem: Go to /cgi-bin/koha/members/memberentry.pl Click Add guarantor Search Close the modal Scroll down => The header of the table will be displayed randomly at the top of the page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162447 [details] [review] Bug 35329: (follow-up) Trigger Select2 upon modal open If we wait until the modal is visible Select2 can correctly calculate the width needed for the Sort 1 and Sort 2 dropdowns. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162448 [details] [review] Bug 35329: Prevent XSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162449 [details] [review] Bug 35329: (follow-up) Label changes for improved accessibility This patch alters the patron search form so that <label>s wrap the <input> fields, allowing the label to be clickable without having to associate it with a unique id. CSS has been modified to accommodate this change. The patch also adds missing Bootstrap classes to the "Clear" button, and swaps out the "hint" class for the "note" class on the permissions information ("Only staff with superlibrarian or acquisitions permissions..."). After this patch, form field labels in the patron search modal should be clickable to give focus to the field (except for Sort 1 and Sort 2 -- label don't work that way with Select2). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162450 [details] [review] Bug 35329: Add selenium tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162451 [details] [review] Bug 35329: Add cypress tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162452 [details] [review] Bug 35329: Add POD + tidy Selenium.pm Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162453 [details] [review] Bug 35329: Fix filter vars scope Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162454 [details] [review] Bug 35329: Add styling to info and error There were 2 "class" attribute and the second was ignored. This could still be improved, but then we should adjust the css from staff-global, but won't be trivial to test. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 162455 [details] [review] Bug 35329: (QA follow-up) Fix for bug 35865 This restores the missing hint that's restored by bug 35865 ahead of this patchset
Created attachment 162456 [details] [review] Bug 35329: Adjustment for 34478
Created attachment 162457 [details] [review] Bug 35329: Handle duplicate without 500 This is not perfect but way better than before!
Patches rebased and adjusted on top of bug 34478 (and friends).
Pushed to master for 24.05.00.
Created attachment 162670 [details] [review] Bug 35329: (follow-up) Add styling to info and error
Created attachment 162671 [details] [review] Bug 35329: Fix conflict with 33457
Last 2 patches pushed to master.
Same tests are still failing with those 2 patches, rescheduling another run to see if it's a random failure (I don't recreate locally). Also noted the following JS error in the log, which is not expected at all being superlibrarian: selenium_1 | JavaScript error: http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha//members/members-home.pl, line 2756: TypeError: libraries_map[data] is undefined
Created attachment 162713 [details] [review] Bug 35329: Fix autocomplete when placing a hold There was a JS error Uncaught TypeError: node.autocomplete(...).data(...) is undefined
Created attachment 162714 [details] [review] Bug 35329: Fix selenium tests if no fund exist
Enhancement not pushed to 23.11.x