View | Details | Raw Unified | Return to bug 19097
Collapse All | Expand All

(-)a/C4/Biblio.pm (-2 / +1 lines)
Lines 2222-2229 sub TransformHtmlToMarc { Link Here
2222
    my $record = MARC::Record->new();
2222
    my $record = MARC::Record->new();
2223
    my @fields;
2223
    my @fields;
2224
    my ($biblionumbertagfield, $biblionumbertagsubfield) = (-1, -1);
2224
    my ($biblionumbertagfield, $biblionumbertagsubfield) = (-1, -1);
2225
    ($biblionumbertagfield, $biblionumbertagsubfield) =
2225
    ( $biblionumbertagfield, $biblionumbertagsubfield ) = &GetMarcFromKohaField("biblio.biblionumber") if $isbiblio;
2226
        &GetMarcFromKohaField( "biblio.biblionumber", '' ) if $isbiblio;
2227
#FIXME This code assumes that the CGI params will be in the same order as the fields in the template; this is no absolute guarantee!
2226
#FIXME This code assumes that the CGI params will be in the same order as the fields in the template; this is no absolute guarantee!
2228
    for (my $i = 0; $params[$i]; $i++ ) {    # browse all CGI params
2227
    for (my $i = 0; $params[$i]; $i++ ) {    # browse all CGI params
2229
        my $param    = $params[$i];
2228
        my $param    = $params[$i];
(-)a/C4/Items.pm (-3 / +1 lines)
Lines 778-786 sub Item2Marc { Link Here
778
    };
778
    };
779
    my $framework = C4::Biblio::GetFrameworkCode( $biblionumber );
779
    my $framework = C4::Biblio::GetFrameworkCode( $biblionumber );
780
    my $itemmarc = C4::Biblio::TransformKohaToMarc( $mungeditem, { framework => $framework } );
780
    my $itemmarc = C4::Biblio::TransformKohaToMarc( $mungeditem, { framework => $framework } );
781
    my ( $itemtag, $itemsubfield ) = C4::Biblio::GetMarcFromKohaField(
781
    my ( $itemtag, $itemsubfield ) = C4::Biblio::GetMarcFromKohaField('items.itemnumber');
782
        "items.itemnumber", $framework,
783
    );
784
782
785
    my $unlinked_item_subfields = _parse_unlinked_item_subfields_from_xml($mungeditem->{'items.more_subfields_xml'});
783
    my $unlinked_item_subfields = _parse_unlinked_item_subfields_from_xml($mungeditem->{'items.more_subfields_xml'});
786
    if (defined $unlinked_item_subfields and $#$unlinked_item_subfields > -1) {
784
    if (defined $unlinked_item_subfields and $#$unlinked_item_subfields > -1) {
(-)a/Koha/EDI.pm (-2 / +1 lines)
Lines 476-483 sub receipt_items { Link Here
476
            my $order = Koha::Acquisition::Orders->find($ordernumber);
476
            my $order = Koha::Acquisition::Orders->find($ordernumber);
477
            $biblionumber = $order->biblionumber;
477
            $biblionumber = $order->biblionumber;
478
            my $frameworkcode = GetFrameworkCode($biblionumber);
478
            my $frameworkcode = GetFrameworkCode($biblionumber);
479
            ($itemfield) = GetMarcFromKohaField( 'items.itemnumber',
479
            ($itemfield) = GetMarcFromKohaField('items.itemnumber');
480
                $frameworkcode );
481
        }
480
        }
482
    }
481
    }
483
482
(-)a/t/db_dependent/Suggestions.t (-7 / +6 lines)
Lines 379-389 my $record = MarcRecordFromNewSuggestion($suggestion2); Link Here
379
379
380
is("MARC::Record", ref($record), "MarcRecordFromNewSuggestion should return a MARC::Record object");
380
is("MARC::Record", ref($record), "MarcRecordFromNewSuggestion should return a MARC::Record object");
381
381
382
my ($title_tag, $title_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.title', '');
382
my ($title_tag, $title_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.title');
383
383
384
is($record->field( $title_tag )->subfield( $title_subfield ), "Cuisine d'automne", "Record from suggestion title should be 'Cuisine d'automne'");
384
is($record->field( $title_tag )->subfield( $title_subfield ), "Cuisine d'automne", "Record from suggestion title should be 'Cuisine d'automne'");
385
385
386
my ($author_tag, $author_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.author', '');
386
my ($author_tag, $author_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.author');
387
387
388
is($record->field( $author_tag )->subfield( $author_subfield ), "Catherine", "Record from suggestion author should be 'Catherine'");
388
is($record->field( $author_tag )->subfield( $author_subfield ), "Catherine", "Record from suggestion author should be 'Catherine'");
389
389
Lines 649-664 subtest 'Suggestion with ISBN' => sub { Link Here
649
    my $record = MarcRecordFromNewSuggestion( $suggestion_with_isbn );
649
    my $record = MarcRecordFromNewSuggestion( $suggestion_with_isbn );
650
    is("MARC::Record", ref($record), "MarcRecordFromNewSuggestion should return a MARC::Record object");
650
    is("MARC::Record", ref($record), "MarcRecordFromNewSuggestion should return a MARC::Record object");
651
651
652
    my ($isbn_tag, $isbn_subfield) = C4::Biblio::GetMarcFromKohaField('biblioitems.isbn', '');
652
    my ($isbn_tag, $isbn_subfield) = C4::Biblio::GetMarcFromKohaField('biblioitems.isbn');
653
    is($record->field( $isbn_tag )->subfield( $isbn_subfield ), "1940997232", "ISBN Record from suggestion ISBN should be '1940997232'");
653
    is($record->field( $isbn_tag )->subfield( $isbn_subfield ), "1940997232", "ISBN Record from suggestion ISBN should be '1940997232'");
654
654
655
    my ($issn_tag, $issn_subfield) = C4::Biblio::GetMarcFromKohaField('biblioitems.issn', '');
655
    my ($issn_tag, $issn_subfield) = C4::Biblio::GetMarcFromKohaField('biblioitems.issn');
656
    is($record->field( $issn_tag )->subfield( $issn_subfield ), "1940997232", "ISSN Record from suggestion ISBN should also be '1940997232'");
656
    is($record->field( $issn_tag )->subfield( $issn_subfield ), "1940997232", "ISSN Record from suggestion ISBN should also be '1940997232'");
657
657
658
    my ($title_tag, $title_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.title', '');
658
    my ($title_tag, $title_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.title');
659
    is($record->field( $title_tag), undef, "Record from suggestion title should be empty");
659
    is($record->field( $title_tag), undef, "Record from suggestion title should be empty");
660
660
661
    my ($author_tag, $author_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.author', '');
661
    my ($author_tag, $author_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.author');
662
    is($record->field( $author_tag), undef, "Record from suggestion author should be empty");
662
    is($record->field( $author_tag), undef, "Record from suggestion author should be empty");
663
};
663
};
664
664
665
- 

Return to bug 19097