Bugzilla – Attachment 20439 Details for
Bug 7639
system preference to forgive fines on lost items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 7639 - system preference to forgive fines on lost items - QA Followup - Fix update description
PASSED-QA-Bug-7639---system-preference-to-forgive-.patch (text/plain), 1.99 KB, created by
Katrin Fischer
on 2013-08-18 15:45:15 UTC
(
hide
)
Description:
[PASSED QA] Bug 7639 - system preference to forgive fines on lost items - QA Followup - Fix update description
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-08-18 15:45:15 UTC
Size:
1.99 KB
patch
obsolete
>From ad7e12560cff5f4baf3ca72789cb7bb6efbcdb2b Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 15 Jul 2013 08:41:51 -0400 >Subject: [PATCH] [PASSED QA] Bug 7639 - system preference to forgive fines on > lost items - QA Followup - Fix update description > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >With these patches we now have 3 preferences that deal with >fines/fees and lost items: > >Replacement price >- On marking lost: WhenLostChargeReplacementFee >- On return: RefundLostItemFeeOnReturn (preexisting) > >Overdue fines >- On marking lost: WhenLostForgiveFine > >System preferences work according to their description. > >Further notes: >- Patches pass all tests and QA script. >- LostItem is changed and needs unit tests. > All occurrences of LostItem have been changed. >- Database update is ok. I had to fix the sysprefs.sql > file that has been recently rewritten and alphabetized. >--- > installer/data/mysql/updatedatabase.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 25548ff..60b177f 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -7072,7 +7072,7 @@ $DBversion = "3.13.00.XXX"; > if (C4::Context->preference("Version") < TransformToNum($DBversion)) { > $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES('WhenLostForgiveFine','0',NULL,'If ON, Forgives the fines on an item when it is lost.','YesNo')"); > $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES('WhenLostChargeReplacementFee','1',NULL,'If ON, Charge the replacement price when a patron loses an item.','YesNo')"); >- print "Upgrade to $DBversion done (Bug 7639: Added sysprefs WhenLostForgiveFine and WhenLostChargeReplacementFee)\n"; >+ print "Upgrade to $DBversion done (Bug 7639: system preferences to forgive fines on lost items)\n"; > SetVersion ($DBversion); > } > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7639
:
9281
|
9282
|
9436
|
10662
|
10663
|
13006
|
13007
|
14961
|
14962
|
15088
|
15089
|
16593
|
16607
|
16608
|
16609
|
16729
|
16730
|
16731
|
18929
|
18930
|
18932
|
18964
|
18965
|
18966
|
19654
|
19655
|
19656
|
19657
|
20436
|
20437
|
20438
| 20439 |
20456
|
20487