Bugzilla – Attachment 21897 Details for
Bug 10987
Too many 'see also' and 'usedfor/see from' labels occurences
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 10987: Too many 'see also' and 'see from' labels occurences
SIGNED-OFF-Bug-10987-Too-many-see-also-and-see-fro.patch (text/plain), 6.80 KB, created by
Bernardo Gonzalez Kriegel
on 2013-10-09 12:12:51 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 10987: Too many 'see also' and 'see from' labels occurences
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2013-10-09 12:12:51 UTC
Size:
6.80 KB
patch
obsolete
>From 756a10a1ccc22926701a7214cfae425eb01d6a86 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Wed, 2 Oct 2013 15:42:13 -0300 >Subject: [PATCH] [SIGNED-OFF] Bug 10987: Too many 'see also' and 'see from' > labels occurences > >If an authority record has more than one 4xx$a (or 5xx$a) entries the >corresponding labels 'see also' and 'used for/see from' are repeated. > >To test: >- Have authority records with more than one entry on the 4xx (or 5xx) fields. >- Do a search, check "see also:" (or 'used for/see from') appear more than once. >- Apply the patch >- Reload and check it looks nicer :-D >- Repeat for: staff auth search, opac using ccsr, opac using prog >- Signoff > >Regards >To+ > >Sponsored-by: Universidad Nacional de Cordoba > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Work as decribed. No koha-qa errors >Nice view on staff and both opac >--- > .../intranet-tmpl/prog/en/css/staff-global.css | 6 ++++-- > .../en/includes/authorities-search-results.inc | 21 ++++++++++---------- > koha-tmpl/opac-tmpl/ccsr/en/css/opac.css | 6 ++++-- > koha-tmpl/opac-tmpl/prog/en/css/opac.css | 6 ++++-- > .../en/includes/authorities-search-results.inc | 21 ++++++++++---------- > 5 files changed, 32 insertions(+), 28 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >index 308e3a0..513f7b7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >@@ -2258,11 +2258,13 @@ ul.ui-tabs-nav li { > } > > .authref { >- text-indent: 2em; >+ font-style: normal; >+ text-indent: 4em; > } > >-.authref .label { >+.seefrom, .seealso { > font-style: italic; >+ text-indent: 2em; > } > > #authfinderops { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc >index 0ef537a..9131666 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc >@@ -14,13 +14,6 @@ > <span class="RT">RT: [% heading | html %]</span> > [% END %] > [% ELSE %] >- <span class="label"> >- [% IF ( type=='seefrom' ) %] >- used for/see from: >- [% ELSIF ( type=='seealso' ) %] >- see also: >- [% END %] >- </span> > <span class="heading"> > [% IF ( type=='seealso' ) %] > [% IF ( authid ) %] >@@ -83,9 +76,11 @@ > </div> > [% END %] > [% ELSE %] >- [% IF ( summary.seefrom ) %] >+ [% IF ( summary.seefrom.size > 1 ) %] >+ <div class="seefrom"> >+ <span class="seefrom">used for/see from:</span> > [% FOREACH seefro IN summary.seefrom %] >- <div class="seefrom authref"> >+ <div class="authref"> > [% PROCESS showreference > heading=seefro.heading > type=seefro.type >@@ -93,10 +88,13 @@ > %] > </div> > [% END %] >+ </div> > [% END %] >- [% IF ( summary.seealso ) %] >+ [% IF ( summary.seealso.size > 1 ) %] >+ <div class="seealso"> >+ <span class="seealso">see also:</span> > [% FOREACH seeals IN summary.seealso %] >- <div class="seealso authref"> >+ <div class="authref"> > [% PROCESS showreference > heading=seeals.heading > type=seeals.type >@@ -104,6 +102,7 @@ > %] > </div> > [% END %] >+ </div> > [% END %] > [% END %] > [% END %] >diff --git a/koha-tmpl/opac-tmpl/ccsr/en/css/opac.css b/koha-tmpl/opac-tmpl/ccsr/en/css/opac.css >index 0901d6b..f0b8744 100644 >--- a/koha-tmpl/opac-tmpl/ccsr/en/css/opac.css >+++ b/koha-tmpl/opac-tmpl/ccsr/en/css/opac.css >@@ -2640,11 +2640,13 @@ ul.ui-tabs-nav li { > } > > .authref { >- text-indent: 2em; >+ font-style: normal; >+ text-indent: 4em; > } > >-.authref .label { >+.seefrom, .seealso { > font-style: italic; >+ text-indent: 2em; > } > > .authstanza { >diff --git a/koha-tmpl/opac-tmpl/prog/en/css/opac.css b/koha-tmpl/opac-tmpl/prog/en/css/opac.css >index c2902c1..c977b62 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/css/opac.css >+++ b/koha-tmpl/opac-tmpl/prog/en/css/opac.css >@@ -2779,11 +2779,13 @@ ul.ui-tabs-nav li { > } > > .authref { >- text-indent: 2em; >+ font-style: normal; >+ text-indent: 4em; > } > >-.authref .label { >+.seefrom, .seealso { > font-style: italic; >+ text-indent: 2em; > } > > .authstanza { >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc b/koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc >index 9a2ffde..5406de3 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc >@@ -13,13 +13,6 @@ > <span class="RT">RT: [% heading | html %]</span> > [% END %] > [% ELSE %] >- <span class="label"> >- [% IF ( type=='seefrom' ) %] >- used for/see from: >- [% ELSIF ( type=='seealso' ) %] >- see also: >- [% END %] >- </span> > <span class="heading"> > [% IF ( type=='seealso' ) %] > [% IF ( authid ) %] >@@ -82,19 +75,24 @@ > </div> > [% END %] > [% ELSE %] >- [% IF ( summary.seefrom ) %] >+ [% IF ( summary.seefrom.size > 1 ) %] >+ <div class="seefrom"> >+ <span class="seefrom">used for/see from:</span> > [% FOREACH seefro IN summary.seefrom %] >- <div class="seefrom authref"> >+ <div class="authref"> > [% PROCESS showreference > heading=seefro.heading > type=seefro.type > %] > </div> > [% END %] >+ </div> > [% END %] >- [% IF ( summary.seealso ) %] >+ [% IF ( summary.seealso.size > 1 ) %] >+ <div class="seealso"> >+ <span class="seealso">see also:</span> > [% FOREACH seeals IN summary.seealso %] >- <div class="seealso authref"> >+ <div class="authref"> > [% PROCESS showreference > heading=seeals.heading > type=seeals.type >@@ -102,6 +100,7 @@ > %] > </div> > [% END %] >+ </div> > [% END %] > [% END %] > [% END %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10987
:
21733
|
21897
|
22788
|
23399
|
24464