Bugzilla – Attachment 3124 Details for
Bug 5733
Empty cart in intranet when session is closed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed follow-up fix
0001-Follow-up-fix-for-Bug-5733-Empty-cart-in-intranet-wh.patch (text/plain), 2.00 KB, created by
Owen Leonard
on 2011-02-10 17:03:32 UTC
(
hide
)
Description:
Proposed follow-up fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2011-02-10 17:03:32 UTC
Size:
2.00 KB
patch
obsolete
>From 11256569287e3b64a4abda2a97b4facd4b462b43 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 10 Feb 2011 11:24:02 -0500 >Subject: [PATCH] Follow-up fix for Bug 5733 - Empty cart in intranet when session is closed >Content-Type: text/plain; charset="utf-8" > >Modifying empty cart function to take a paramter: if true, >cart will be emptied without a prompt. > >Removing unnecessary "javascript:" pseudo-protocol. >--- > .../intranet-tmpl/prog/en/includes/header.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/js/basket.js | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc >index b830e62..ea556c4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc >@@ -64,7 +64,7 @@ > <span class="loggedinusername"> > <!-- TMPL_VAR NAME="loggedinusername" --> > </span> >- (<a href="/cgi-bin/koha/mainpage.pl?logout.x=1"<!-- TMPL_IF NAME="intranetbookbag" --> onclick="javascript:delBasket(true);"<!-- /TMPL_IF -->>Log Out</a>) | >+ (<a href="/cgi-bin/koha/mainpage.pl?logout.x=1"<!-- TMPL_IF NAME="intranetbookbag" --> onclick="delBasket(true);"<!-- /TMPL_IF -->>Log Out</a>) | > <!-- TMPL_ELSE --> > You are not logged in | > <!-- /TMPL_IF --> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/basket.js b/koha-tmpl/intranet-tmpl/prog/en/js/basket.js >index 0ab6711..9946cf7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/basket.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/basket.js >@@ -299,10 +299,10 @@ function delRecord (n, s) { > } > > >-function delBasket() { >- >- var rep = false; >- rep = confirm(MSG_CONFIRM_DEL_BASKET); >+function delBasket(rep) { >+ if (rep == undefined){ >+ rep = confirm(MSG_CONFIRM_DEL_BASKET); >+ } > if (rep) { > delCookie(nameCookie); > document.location = "about:blank"; >-- >1.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5733
:
3119
| 3124