Bugzilla – Attachment 33961 Details for
Bug 13335
Holds and priority display via OPACShowHoldQueueDetails confusing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF]Bug 13335 - Holds and priority display via OPACShowHoldQueueDetails confusing
SIGNED-OFFBug-13335---Holds-and-priority-display-v.patch (text/plain), 3.45 KB, created by
Christopher Brannon
on 2014-11-26 19:39:28 UTC
(
hide
)
Description:
[SIGNED OFF]Bug 13335 - Holds and priority display via OPACShowHoldQueueDetails confusing
Filename:
MIME Type:
Creator:
Christopher Brannon
Created:
2014-11-26 19:39:28 UTC
Size:
3.45 KB
patch
obsolete
>From 9f2aefb3bd5c1544d68bf4ca75e5b20095e56436 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 25 Nov 2014 10:16:47 -0500 >Subject: [PATCH] [SIGNED OFF]Bug 13335 - Holds and priority display via OPACShowHoldQueueDetails confusing > >No matter what the selection of OPACShowHoldQueueDetails is, if it is >enabled it displays a line "Holds and priority:" even if you've opted to >hide one of those! > >Test Plan: >1) Apply this patch >2) Test each setting of OPACShowHoldQueueDetails >3) Ensure each setting displays the correct fields ( or lack thereof ) > >Signed-off-by: Christopher Brannon <cbrannon@debian.localdomain> >--- > .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 16 +++++++++++----- > opac/opac-reserve.pl | 2 -- > 2 files changed, 11 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index 6558e6e..a0442be 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -173,12 +173,18 @@ > </li> > [% END %] > >- [% IF showholds || showpriority %] >+ [% SET OPACShowHoldQueueDetails = Koha.Preference('OPACShowHoldQueueDetails') %] >+ [% IF OPACShowHoldQueueDetails == 'holds_priority' || OPACShowHoldQueueDetails == 'priority' %] > <li class="priority"> >- <span class="label">Holds and priority: </span> >- [% IF showpriority %] [% bibitemloo.rank %] [% END %] >- [% IF showholds && showpriority %] out of [% END %] >- [% IF showholds %] [% bibitemloo.reservecount %] [% END %] >+ <span class="label">Your priority: </span> >+ [% bibitemloo.rank %] >+ </li> >+ [% END %] >+ >+ [% IF OPACShowHoldQueueDetails == 'holds_priority' || OPACShowHoldQueueDetails == 'holds' %] >+ <li class="holds-count"> >+ <span class="label">Number of holds: </span> >+ [% bibitemloo.reservecount %] > </li> > [% END %] > >diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl >index ba778db..60e53cb 100755 >--- a/opac/opac-reserve.pl >+++ b/opac/opac-reserve.pl >@@ -573,8 +573,6 @@ $template->param(OpacHoldNotes=>$show_notes); > > # display infos > $template->param(bibitemloop => $biblioLoop); >-$template->param( showholds=>$show_holds_count); >-$template->param( showpriority=>$show_priority); > # can set reserve date in future > if ( > C4::Context->preference( 'AllowHoldDateInFuture' ) && >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13335
:
33919
|
33920
|
33960
|
33961
|
34527