No matter what the selection of OPACShowHoldQueueDetails is, if it is enabled it displays a line "Holds and priority:" even if you've opted to hide one of those!
Created attachment 33919 [details] [review] Bug 13335 - Holds and priority display via OPACShowHoldQueueDetails confusing
Created attachment 33920 [details] [review] Bug 13335 - Holds and priority display via OPACShowHoldQueueDetails confusing No matter what the selection of OPACShowHoldQueueDetails is, if it is enabled it displays a line "Holds and priority:" even if you've opted to hide one of those! Test Plan: 1) Apply this patch 2) Test each setting of OPACShowHoldQueueDetails 3) Ensure each setting displays the correct fields ( or lack thereof )
Created attachment 33960 [details] [review] Bug 13335 - Holds and priority display via OPACShowHoldQueueDetails confusing No matter what the selection of OPACShowHoldQueueDetails is, if it is enabled it displays a line "Holds and priority:" even if you've opted to hide one of those! Test Plan: 1) Apply this patch 2) Test each setting of OPACShowHoldQueueDetails 3) Ensure each setting displays the correct fields ( or lack thereof ) Signed-off-by: Christopher Brannon <cbrannon@debian.localdomain>
Created attachment 33961 [details] [review] [SIGNED OFF]Bug 13335 - Holds and priority display via OPACShowHoldQueueDetails confusing No matter what the selection of OPACShowHoldQueueDetails is, if it is enabled it displays a line "Holds and priority:" even if you've opted to hide one of those! Test Plan: 1) Apply this patch 2) Test each setting of OPACShowHoldQueueDetails 3) Ensure each setting displays the correct fields ( or lack thereof ) Signed-off-by: Christopher Brannon <cbrannon@debian.localdomain>
Created attachment 34527 [details] [review] Bug 13335 - Holds and priority display via OPACShowHoldQueueDetails confusing No matter what the selection of OPACShowHoldQueueDetails is, if it is enabled it displays a line "Holds and priority:" even if you've opted to hide one of those! Test Plan: 1) Apply this patch 2) Test each setting of OPACShowHoldQueueDetails 3) Ensure each setting displays the correct fields ( or lack thereof ) Signed-off-by: Christopher Brannon <cbrannon@debian.localdomain> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patch pushed to master. Thanks Kyle!
Pushes to 3.18.x will be in 3.18.4